Devicetree
 help / color / mirror / Atom feed
* [PATCH 0/4] camcc-sm8750/eliza: Declare interconnect dependency for TITAN_TOP_GDSC
@ 2026-11-18  7:45 Wenmeng Liu
  2026-11-18  7:45 ` [PATCH 1/4] clk: qcom: camcc-sm8750: Declare icc path " Wenmeng Liu
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Wenmeng Liu @ 2026-11-18  7:45 UTC (permalink / raw)
  To: Bjorn Andersson, Abel Vesa, Stephen Boyd, Brian Masney,
	Jerome Brunet, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, linux-clk, devicetree, Wenmeng Liu

The TITAN_TOP GDSC hosts the camera NoC (camnoc). If MMNOC is left without
any client vote while TITAN_TOP is still on, MMNOC attempts a power
collapse while camnoc may still be active. The collapse then gets stuck,
and so does the MMNOC BCM, so any later bandwidth request through it times
out in RPMh:

  Error sending AMC RPMH requests (-110)

This can happen whenever the last MMNOC vote goes away while TITAN_TOP is
kept on by another user, e.g. when the CAMSS driver runtime suspends while
the GDSC is still held by the device link during probe.

Fix this by declaring the interconnect path on the TITAN_TOP GDSC itself,
so that MMNOC is kept voted for as long as the GDSC is on. This uses the
GDSC interconnect support added for the Milos camera clock controller [1].
On Milos the missing vote prevents the GDSC from being enabled, while on
SM8750 and Eliza it shows up as the MMNOC collapse getting stuck, but the
underlying dependency of TITAN_TOP on MMNOC is the same.

[1] https://lore.kernel.org/all/20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com/

---
Wenmeng Liu (4):
      clk: qcom: camcc-sm8750: Declare icc path dependency for TITAN_TOP_GDSC
      clk: qcom: camcc-eliza: Declare icc path dependency for TITAN_TOP_GDSC
      arm64: dts: qcom: sm8750: Add interconnects to camcc
      arm64: dts: qcom: eliza: Add interconnects to camcc

 arch/arm64/boot/dts/qcom/eliza.dtsi  | 3 +++
 arch/arm64/boot/dts/qcom/sm8750.dtsi | 3 +++
 drivers/clk/qcom/camcc-eliza.c       | 6 ++++++
 drivers/clk/qcom/camcc-sm8750.c      | 6 ++++++
 4 files changed, 18 insertions(+)
---
base-commit: 7cfbf79c66c63e807ea452abf0546e6f6d6833a6
change-id: 20261118-camcc-fix-5548d108f801

Best regards,
-- 
Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-18  7:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  7:45 [PATCH 0/4] camcc-sm8750/eliza: Declare interconnect dependency for TITAN_TOP_GDSC Wenmeng Liu
2026-11-18  7:45 ` [PATCH 1/4] clk: qcom: camcc-sm8750: Declare icc path " Wenmeng Liu
2026-11-18  7:45 ` [PATCH 2/4] clk: qcom: camcc-eliza: " Wenmeng Liu
2026-11-18  7:53   ` sashiko-bot
2026-11-18  7:45 ` [PATCH 3/4] arm64: dts: qcom: sm8750: Add interconnects to camcc Wenmeng Liu
2026-11-18  7:45 ` [PATCH 4/4] arm64: dts: qcom: eliza: " Wenmeng Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox