Devicetree
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: rtc: haoyu,hym8563: document vcc-supply
@ 2026-11-18  8:05 pjh456
  2026-11-18  8:29 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: pjh456 @ 2026-11-18  8:05 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: linux-rtc, devicetree, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley

The HYM8563 has an optional VDD supply.  Document it so boards can
describe the regulator and defer probe until it is available.

Assisted-by: DeepSeek:deepseek-v4.1-flash
Assisted-by: Qwen:Qwen3.8-Flash-Next
Signed-off-by: pjh456 <147148383@qq.com>
---
 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
index 0b9f39ef0edc..b27b250d3c2e 100644
--- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
+++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
@@ -29,6 +29,9 @@ properties:
   wakeup-source:
     description: Enables wake up of host system on alarm.
 
+  vcc-supply:
+    description: Main power supply (VDD).
+
 allOf:
   - $ref: rtc.yaml
 

base-commit: 7e1392a42ea288d70a266f6553fe06f57f8647ea
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: rtc: haoyu,hym8563: document vcc-supply
  2026-11-18  8:05 [PATCH] dt-bindings: rtc: haoyu,hym8563: document vcc-supply pjh456
@ 2026-11-18  8:29 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-18  8:29 UTC (permalink / raw)
  To: pjh456; +Cc: linux-rtc, devicetree, robh, conor+dt, Alexandre Belloni

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: rtc: haoyu,hym8563: VDD supply documented as
  vcc-supply
--

commit b43da37686bbff8c05e2939d152dd97bed1884f1
Author: pjh456 <147148383@qq.com>

dt-bindings: rtc: haoyu,hym8563: document vcc-supply

This commit adds a vcc-supply property to the Haoyu HYM8563 RTC Device
Tree binding schema to describe its optional VDD supply.

> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
> index 0b9f39ef0edc3..b27b250d3c2e3 100644
> --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
> +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
> @@ -29,6 +29,9 @@ properties:
>    wakeup-source:
>      description: Enables wake up of host system on alarm.
>  
> +  vcc-supply:
> +    description: Main power supply (VDD).
> +

[Severity: Medium]
Should this property be named vdd-supply instead of vcc-supply?

Both the description and the HYM8563 datasheet identify the IC supply pin
as VDD, and neither hym8563_probe() in drivers/rtc/rtc-hym8563.c nor any
in-tree haoyu,hym8563 Device Tree node currently uses vcc-supply.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_B11DE1495C3C54CE186ED508E2CE5CE41106@qq.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-18  8:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  8:05 [PATCH] dt-bindings: rtc: haoyu,hym8563: document vcc-supply pjh456
2026-11-18  8:29 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox