From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines
Date: Wed, 18 Nov 2026 11:30:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-220825@kernel.org> (raw)
In-Reply-To: <20261118112407.103412-1-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: nord: QCOM_GPI_SPI dmas added to uart nodes
instead of spi
--
commit ec82fd4963709d74e7ab22bb82bb9af984ad44a7
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines
This commit moves QCOM_GPI_SPI DMA channels from UART nodes to their SPI
sibling nodes for SE 0-3, 7, 8, 11, and 12, and adds QCOM_GPI_SPI DMA
channels for SE 4 and SE 14-19.
> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> index 56778dd444e4e..a9534cba07550 100644
> --- a/arch/arm64/boot/dts/qcom/nord.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi
> @@ -1094,6 +1094,10 @@ uart14: serial@880000 {
> reg = <0x0 0x00880000 0x0 0x4000>;
> interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 0 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 0 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1125,6 +1129,10 @@ uart15: serial@884000 {
> reg = <0x0 0x00884000 0x0 0x4000>;
> interrupts = <GIC_SPI 583 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 1 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 1 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1156,6 +1164,10 @@ uart16: serial@888000 {
> reg = <0x0 0x00888000 0x0 0x4000>;
> interrupts = <GIC_SPI 584 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 2 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 2 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1187,6 +1199,10 @@ uart17: serial@88c000 {
> reg = <0x0 0x0088c000 0x0 0x4000>;
> interrupts = <GIC_SPI 585 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 3 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 3 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1218,6 +1234,10 @@ uart18: serial@890000 {
> reg = <0x0 0x00890000 0x0 0x4000>;
> interrupts = <GIC_SPI 586 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 4 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 4 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1249,6 +1269,10 @@ uart19: serial@894000 {
> reg = <0x0 0x00894000 0x0 0x4000>;
> interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 5 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 5 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
[ ... ]
> @@ -1485,6 +1509,10 @@ uart4: serial@990000 {
> reg = <0x0 0x00990000 0x0 0x4000>;
> interrupts = <GIC_SPI 516 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma0 0 4 QCOM_GPI_SPI>,
> + <&gpi_dma0 1 4 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
[Severity: High]
Are these QCOM_GPI_SPI channels added to uart4 and uart14..uart19 instead
of spi4 and spi14..spi19? This leaves those seven SPI nodes unable to use
GPI DMA and adds disallowed dmas properties to the corresponding GENI UART
nodes.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118112407.103412-1-shengchao.guo@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-11-18 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 11:24 [PATCH] arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines Shawn Guo
2026-11-18 11:30 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220825@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox