* [PATCH] arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines
@ 2026-11-18 11:24 Shawn Guo
2026-11-18 11:30 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Guo @ 2026-11-18 11:24 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bartosz Golaszewski, devicetree, linux-arm-msm,
linux-kernel, Shawn Guo
Commit d8005dd04efc ("arm64: dts: qcom: nord: wire up GPI DMA for QUP
I2C/SPI engines") put the QCOM_GPI_SPI channels of SE 0-3, 7, 8, 11
and 12 into the uartN nodes instead of their spiN siblings, and left
spi4 and spi14..spi19 without any. The UART nodes now carry dmas
properties the GENI UART binding doesn't allow, and 15 of 18 SPI
engines can't use GPI DMA.
Move the channels from the UART nodes to the SPI nodes, and add the
missing ones for spi4 and spi14..spi19.
Fixes: d8005dd04efc ("arm64: dts: qcom: nord: wire up GPI DMA for QUP I2C/SPI engines")
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/nord.dtsi | 92 +++++++++++++++++++-----------
1 file changed, 60 insertions(+), 32 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
index 39de48e5bff0..256bc766ea6e 100644
--- a/arch/arm64/boot/dts/qcom/nord.dtsi
+++ b/arch/arm64/boot/dts/qcom/nord.dtsi
@@ -1136,6 +1136,10 @@ spi14: spi@880000 {
reg = <0x0 0x00880000 0x0 0x4000>;
interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma2 0 0 QCOM_GPI_SPI>,
+ <&gpi_dma2 1 0 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1167,6 +1171,10 @@ spi15: spi@884000 {
reg = <0x0 0x00884000 0x0 0x4000>;
interrupts = <GIC_SPI 583 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma2 0 1 QCOM_GPI_SPI>,
+ <&gpi_dma2 1 1 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1198,6 +1206,10 @@ spi16: spi@888000 {
reg = <0x0 0x00888000 0x0 0x4000>;
interrupts = <GIC_SPI 584 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma2 0 2 QCOM_GPI_SPI>,
+ <&gpi_dma2 1 2 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1229,6 +1241,10 @@ spi17: spi@88c000 {
reg = <0x0 0x0088c000 0x0 0x4000>;
interrupts = <GIC_SPI 585 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma2 0 3 QCOM_GPI_SPI>,
+ <&gpi_dma2 1 3 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1260,6 +1276,10 @@ spi18: spi@890000 {
reg = <0x0 0x00890000 0x0 0x4000>;
interrupts = <GIC_SPI 586 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma2 0 4 QCOM_GPI_SPI>,
+ <&gpi_dma2 1 4 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1291,6 +1311,10 @@ spi19: spi@894000 {
reg = <0x0 0x00894000 0x0 0x4000>;
interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma2 0 5 QCOM_GPI_SPI>,
+ <&gpi_dma2 1 5 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1387,6 +1411,10 @@ spi0: spi@980000 {
reg = <0x0 0x00980000 0x0 0x4000>;
interrupts = <GIC_SPI 314 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma0 0 0 QCOM_GPI_SPI>,
+ <&gpi_dma0 1 0 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1395,10 +1423,6 @@ uart0: serial@980000 {
reg = <0x0 0x00980000 0x0 0x4000>;
interrupts = <GIC_SPI 314 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&gpi_dma0 0 0 QCOM_GPI_SPI>,
- <&gpi_dma0 1 0 QCOM_GPI_SPI>;
- dma-names = "tx", "rx";
-
status = "disabled";
};
@@ -1422,6 +1446,10 @@ spi1: spi@984000 {
reg = <0x0 0x00984000 0x0 0x4000>;
interrupts = <GIC_SPI 513 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma0 0 1 QCOM_GPI_SPI>,
+ <&gpi_dma0 1 1 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1430,10 +1458,6 @@ uart1: serial@984000 {
reg = <0x0 0x00984000 0x0 0x4000>;
interrupts = <GIC_SPI 513 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&gpi_dma0 0 1 QCOM_GPI_SPI>,
- <&gpi_dma0 1 1 QCOM_GPI_SPI>;
- dma-names = "tx", "rx";
-
status = "disabled";
};
@@ -1457,6 +1481,10 @@ spi2: spi@988000 {
reg = <0x0 0x00988000 0x0 0x4000>;
interrupts = <GIC_SPI 514 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma0 0 2 QCOM_GPI_SPI>,
+ <&gpi_dma0 1 2 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1465,10 +1493,6 @@ uart2: serial@988000 {
reg = <0x0 0x00988000 0x0 0x4000>;
interrupts = <GIC_SPI 514 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&gpi_dma0 0 2 QCOM_GPI_SPI>,
- <&gpi_dma0 1 2 QCOM_GPI_SPI>;
- dma-names = "tx", "rx";
-
status = "disabled";
};
@@ -1492,6 +1516,10 @@ spi3: spi@98c000 {
reg = <0x0 0x0098c000 0x0 0x4000>;
interrupts = <GIC_SPI 515 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma0 0 3 QCOM_GPI_SPI>,
+ <&gpi_dma0 1 3 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1500,10 +1528,6 @@ uart3: serial@98c000 {
reg = <0x0 0x0098c000 0x0 0x4000>;
interrupts = <GIC_SPI 515 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&gpi_dma0 0 3 QCOM_GPI_SPI>,
- <&gpi_dma0 1 3 QCOM_GPI_SPI>;
- dma-names = "tx", "rx";
-
status = "disabled";
};
@@ -1527,6 +1551,10 @@ spi4: spi@990000 {
reg = <0x0 0x00990000 0x0 0x4000>;
interrupts = <GIC_SPI 516 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma0 0 4 QCOM_GPI_SPI>,
+ <&gpi_dma0 1 4 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1623,6 +1651,10 @@ spi7: spi@a80000 {
reg = <0x0 0x00a80000 0x0 0x4000>;
interrupts = <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma1 0 0 QCOM_GPI_SPI>,
+ <&gpi_dma1 1 0 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1631,10 +1663,6 @@ uart7: serial@a80000 {
reg = <0x0 0x00a80000 0x0 0x4000>;
interrupts = <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&gpi_dma1 0 0 QCOM_GPI_SPI>,
- <&gpi_dma1 1 0 QCOM_GPI_SPI>;
- dma-names = "tx", "rx";
-
status = "disabled";
};
@@ -1658,6 +1686,10 @@ spi8: spi@a84000 {
reg = <0x0 0x00a84000 0x0 0x4000>;
interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma1 0 1 QCOM_GPI_SPI>,
+ <&gpi_dma1 1 1 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1666,10 +1698,6 @@ uart8: serial@a84000 {
reg = <0x0 0x00a84000 0x0 0x4000>;
interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&gpi_dma1 0 1 QCOM_GPI_SPI>,
- <&gpi_dma1 1 1 QCOM_GPI_SPI>;
- dma-names = "tx", "rx";
-
status = "disabled";
};
@@ -1739,6 +1767,10 @@ spi11: spi@a90000 {
reg = <0x0 0x00a90000 0x0 0x4000>;
interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma1 0 4 QCOM_GPI_SPI>,
+ <&gpi_dma1 1 4 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1747,10 +1779,6 @@ uart11: serial@a90000 {
reg = <0x0 0x00a90000 0x0 0x4000>;
interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&gpi_dma1 0 4 QCOM_GPI_SPI>,
- <&gpi_dma1 1 4 QCOM_GPI_SPI>;
- dma-names = "tx", "rx";
-
status = "disabled";
};
@@ -1774,6 +1802,10 @@ spi12: spi@a94000 {
reg = <0x0 0x00a94000 0x0 0x4000>;
interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&gpi_dma1 0 5 QCOM_GPI_SPI>,
+ <&gpi_dma1 1 5 QCOM_GPI_SPI>;
+ dma-names = "tx", "rx";
+
status = "disabled";
};
@@ -1782,10 +1814,6 @@ uart12: serial@a94000 {
reg = <0x0 0x00a94000 0x0 0x4000>;
interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&gpi_dma1 0 5 QCOM_GPI_SPI>,
- <&gpi_dma1 1 5 QCOM_GPI_SPI>;
- dma-names = "tx", "rx";
-
status = "disabled";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines
2026-11-18 11:24 [PATCH] arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines Shawn Guo
@ 2026-11-18 11:30 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-18 11:30 UTC (permalink / raw)
To: Shawn Guo; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: nord: QCOM_GPI_SPI dmas added to uart nodes
instead of spi
--
commit ec82fd4963709d74e7ab22bb82bb9af984ad44a7
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines
This commit moves QCOM_GPI_SPI DMA channels from UART nodes to their SPI
sibling nodes for SE 0-3, 7, 8, 11, and 12, and adds QCOM_GPI_SPI DMA
channels for SE 4 and SE 14-19.
> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> index 56778dd444e4e..a9534cba07550 100644
> --- a/arch/arm64/boot/dts/qcom/nord.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi
> @@ -1094,6 +1094,10 @@ uart14: serial@880000 {
> reg = <0x0 0x00880000 0x0 0x4000>;
> interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 0 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 0 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1125,6 +1129,10 @@ uart15: serial@884000 {
> reg = <0x0 0x00884000 0x0 0x4000>;
> interrupts = <GIC_SPI 583 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 1 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 1 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1156,6 +1164,10 @@ uart16: serial@888000 {
> reg = <0x0 0x00888000 0x0 0x4000>;
> interrupts = <GIC_SPI 584 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 2 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 2 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1187,6 +1199,10 @@ uart17: serial@88c000 {
> reg = <0x0 0x0088c000 0x0 0x4000>;
> interrupts = <GIC_SPI 585 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 3 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 3 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1218,6 +1234,10 @@ uart18: serial@890000 {
> reg = <0x0 0x00890000 0x0 0x4000>;
> interrupts = <GIC_SPI 586 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 4 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 4 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
>
> @@ -1249,6 +1269,10 @@ uart19: serial@894000 {
> reg = <0x0 0x00894000 0x0 0x4000>;
> interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma2 0 5 QCOM_GPI_SPI>,
> + <&gpi_dma2 1 5 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
[ ... ]
> @@ -1485,6 +1509,10 @@ uart4: serial@990000 {
> reg = <0x0 0x00990000 0x0 0x4000>;
> interrupts = <GIC_SPI 516 IRQ_TYPE_LEVEL_HIGH>;
>
> + dmas = <&gpi_dma0 0 4 QCOM_GPI_SPI>,
> + <&gpi_dma0 1 4 QCOM_GPI_SPI>;
> + dma-names = "tx", "rx";
> +
> status = "disabled";
> };
[Severity: High]
Are these QCOM_GPI_SPI channels added to uart4 and uart14..uart19 instead
of spi4 and spi14..spi19? This leaves those seven SPI nodes unable to use
GPI DMA and adds disallowed dmas properties to the corresponding GENI UART
nodes.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118112407.103412-1-shengchao.guo@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-18 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 11:24 [PATCH] arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines Shawn Guo
2026-11-18 11:30 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox