Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hans de Goede" <johannes.goede@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix touchscreen power on
Date: Wed, 18 Nov 2026 15:41:43 +0000	[thread overview]
Message-ID: <sashiko-outbox-221359@kernel.org> (raw)
In-Reply-To: <20261118153326.12640-1-johannes.goede@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: missing Fixes trailer for touchscreen power-on
  delay fix
--

commit 618cd8b22a525766134a0a260252f46c6dbcf50a
Author: Hans de Goede <johannes.goede@oss.qualcomm.com>

> arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix touchscreen power on
>
> When the i2c-hid driver is builtin the touchpad on the ThinkPad T14s
> fails to probe at boot. When the driver is builtin the touchscreen gets
> probed immediately after being taken out of reset. At this point
> the touchscreen is not ready to talk on the I2C bus yet, causing
> the probe to fail.
>
> The touchscreen on this laptop needs a delay of 200ms (taken from ACPI
> power-sequences) before it will accept I2C transfers.
>
> Add a post-power-on-delay-ms = 200 property to the touchscreen DT node
> to fix this.
>
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

[Severity: Low]
Since this fixes the touchscreen@10 node introduced without
post-power-on-delay-ms, should this include:

  Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6")

Also, the first sentence of the commit message says "touchpad" where
"touchscreen" is meant.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118153326.12640-1-johannes.goede@oss.qualcomm.com?part=1

      reply	other threads:[~2026-11-18 15:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:33 [PATCH] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix touchscreen power on Hans de Goede
2026-11-18 15:41 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221359@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox