Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix touchscreen power on
@ 2026-11-18 15:33 Hans de Goede
  2026-11-18 15:41 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2026-11-18 15:33 UTC (permalink / raw)
  To: Bjorn Andersson, Krzysztof Kozlowski, Konrad Dybcio, Abel Vesa
  Cc: Hans de Goede, linux-arm-msm, devicetree

When the i2c-hid driver is builtin the touchpad on the ThinkPad T14s
fails to probe at boot. When the driver is builtin the touchscreen gets
probed immediately after being taken out of reset. At this point
the touchscreen is not ready to talk on the I2C bus yet, causing
the probe to fail.

The touchscreen on this laptop needs a delay of 200ms (taken from ACPI
power-sequences) before it will accept I2C transfers.

Add a post-power-on-delay-ms = 200 property to the touchscreen DT node
to fix this.

Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
index 7c9424248120..16b25e596f0d 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
@@ -1349,6 +1349,7 @@ touchscreen@10 {
 		reg = <0x10>;
 
 		hid-descr-addr = <0x1>;
+		post-power-on-delay-ms = <200>;
 		interrupts-extended = <&tlmm 51 IRQ_TYPE_LEVEL_LOW>;
 
 		vdd-supply = <&vreg_misc_3p3>;
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix touchscreen power on
  2026-11-18 15:33 [PATCH] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix touchscreen power on Hans de Goede
@ 2026-11-18 15:41 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-18 15:41 UTC (permalink / raw)
  To: Hans de Goede; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: missing Fixes trailer for touchscreen power-on
  delay fix
--

commit 618cd8b22a525766134a0a260252f46c6dbcf50a
Author: Hans de Goede <johannes.goede@oss.qualcomm.com>

> arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix touchscreen power on
>
> When the i2c-hid driver is builtin the touchpad on the ThinkPad T14s
> fails to probe at boot. When the driver is builtin the touchscreen gets
> probed immediately after being taken out of reset. At this point
> the touchscreen is not ready to talk on the I2C bus yet, causing
> the probe to fail.
>
> The touchscreen on this laptop needs a delay of 200ms (taken from ACPI
> power-sequences) before it will accept I2C transfers.
>
> Add a post-power-on-delay-ms = 200 property to the touchscreen DT node
> to fix this.
>
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

[Severity: Low]
Since this fixes the touchscreen@10 node introduced without
post-power-on-delay-ms, should this include:

  Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6")

Also, the first sentence of the commit message says "touchpad" where
"touchscreen" is meant.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118153326.12640-1-johannes.goede@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-18 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 15:33 [PATCH] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix touchscreen power on Hans de Goede
2026-11-18 15:41 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox