Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "David Heidelberg" <david@ixit.cz>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 06/12] arm64: dts: qcom: pm660: Add node for PMIC VBUS booster
Date: Wed, 18 Nov 2026 17:35:27 +0000	[thread overview]
Message-ID: <sashiko-outbox-221663@kernel.org> (raw)
In-Reply-To: <20261118-pmi8998-vbus-v2-6-3c77a72b280a@ixit.cz>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: pm660: compatible mismatch with
  usb-vbus-regulator schema
--

commit 4860c32276902904ecaa66c748be4bfd758d569f
Author: David Heidelberg <david@ixit.cz>

arm64: dts: qcom: pm660: Add node for PMIC VBUS booster

This commit adds the USB VBUS output regulator device tree node for the
PM660 PMIC.

> diff --git a/arch/arm64/boot/dts/qcom/pm660.dtsi b/arch/arm64/boot/dts/qcom/pm660.dtsi
> index 156b2ddff0dcb..fe9ef304d64e7 100644
> --- a/arch/arm64/boot/dts/qcom/pm660.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm660.dtsi
> @@ -90,6 +90,13 @@ pm660_charger: charger@1000 {
>  			status = "disabled";
>  		};
>  
> +		pm660_vbus: usb-vbus-regulator@1100 {
> +			compatible = "qcom,pm660-vbus-reg", "qcom,pmi8998-vbus-reg";
> +			reg = <0x1100>;
> +
> +			status = "disabled";
> +		};

[Severity: Medium]
Does the fallback compatible "qcom,pmi8998-vbus-reg" here mismatch the
binding schema added in commit "dt-bindings: regulator:
qcom,usb-vbus-regulator: Add pmi8998 and pm660"?

While qcom_usb_vbus_regulator_match in
drivers/regulator/qcom_usb_vbus-regulator.c matches
"qcom,pmi8998-vbus-reg", the binding defines the fallback constant as
"qcom,pm8998-vbus-reg" (missing the "i"):

Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml:
      - items:
          - enum:
              - qcom,pm660-vbus-reg
          - const: qcom,pm8998-vbus-reg

This mismatch causes dtbs_check validation to fail for boards including
pm660.dtsi.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-pmi8998-vbus-v2-0-3c77a72b280a@ixit.cz?part=6

  reply	other threads:[~2026-11-18 17:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 01/12] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998 David Heidelberg via B4 Relay
2026-11-18 17:43   ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 03/12] power: supply: qcom_smbx: Do not interfere with vbus driver David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660 David Heidelberg via B4 Relay
2026-11-18 17:33   ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 05/12] arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 06/12] arm64: dts: qcom: pm660: " David Heidelberg via B4 Relay
2026-11-18 17:35   ` sashiko-bot [this message]
2026-11-18 17:25 ` [PATCH v2 07/12] arm64: dts: qcom: sdm845-google: Enable vbus support David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 08/12] arm64: dts: qcom: sdm845-oneplus: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 09/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 10/12] arm64: dts: qcom: sdm845-lg: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 11/12] arm64: dts: qcom: sdm845-xiaomi-beryllium: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: " David Heidelberg via B4 Relay
2026-11-18 17:37   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221663@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox