From: sashiko-bot@kernel.org
To: "David Heidelberg" <david@ixit.cz>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998
Date: Wed, 18 Nov 2026 17:43:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-221681@kernel.org> (raw)
In-Reply-To: <20261118-pmi8998-vbus-v2-2-3c77a72b280a@ixit.cz>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] regulator: qcom_usb_vbus: pmi8998_data duplicates pm8150b_data
verbatim
--
commit 236079d01ccf3acd0da063e72d90d4189d163862
Author: David Heidelberg <david@ixit.cz>
regulator: qcom_usb_vbus: Add support for pmi8998
This commit adds compatible string and register configuration data for
the PMI8998 USB VBUS regulator.
> diff --git a/drivers/regulator/qcom_usb_vbus-regulator.c b/drivers/regulator/qcom_usb_vbus-regulator.c
> index 88f5a6ba79e6e..0617106a82cda 100644
> --- a/drivers/regulator/qcom_usb_vbus-regulator.c
> +++ b/drivers/regulator/qcom_usb_vbus-regulator.c
> @@ -68,6 +68,17 @@ static const struct qcom_usb_vbus_reg_data pm8150b_data = {
> .ops = &qcom_usb_vbus_reg_ops,
> };
>
> +static const struct qcom_usb_vbus_reg_data pmi8998_data = {
> + .cmd_otg = CMD_OTG,
> + .otg_cfg = OTG_CFG,
> + .otg_en_src_cfg = OTG_EN_SRC_CFG,
> + .csel_reg = OTG_CURRENT_LIMIT_CFG,
> + .csel_mask = OTG_CURRENT_LIMIT_MASK,
> + .curr_table = curr_table,
> + .n_current_limits = ARRAY_SIZE(curr_table),
> + .ops = &qcom_usb_vbus_reg_ops,
> +};
> +
> static const struct regulator_ops qcom_usb_vbus_pm4125_reg_ops = {
> .enable = regulator_enable_regmap,
> .disable = regulator_disable_regmap,
> @@ -166,6 +177,7 @@ static int qcom_usb_vbus_regulator_probe(struct platform_device *pdev)
> static const struct of_device_id qcom_usb_vbus_regulator_match[] = {
> { .compatible = "qcom,pm8150b-vbus-reg", .data = &pm8150b_data },
> { .compatible = "qcom,pm4125-vbus-reg", .data = &pm4125_data },
> + { .compatible = "qcom,pmi8998-vbus-reg", .data = &pmi8998_data },
> { }
> };
> MODULE_DEVICE_TABLE(of, qcom_usb_vbus_regulator_match);
[Severity: Low]
Since pmi8998_data is identical to pm8150b_data defined right above it,
could the qcom,pmi8998-vbus-reg entry in qcom_usb_vbus_regulator_match
point directly to &pm8150b_data instead of duplicating the descriptor?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-pmi8998-vbus-v2-0-3c77a72b280a@ixit.cz?part=2
next prev parent reply other threads:[~2026-11-18 17:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 01/12] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998 David Heidelberg via B4 Relay
2026-11-18 17:43 ` sashiko-bot [this message]
2026-11-18 17:25 ` [PATCH v2 03/12] power: supply: qcom_smbx: Do not interfere with vbus driver David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660 David Heidelberg via B4 Relay
2026-11-18 17:33 ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 05/12] arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 06/12] arm64: dts: qcom: pm660: " David Heidelberg via B4 Relay
2026-11-18 17:35 ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 07/12] arm64: dts: qcom: sdm845-google: Enable vbus support David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 08/12] arm64: dts: qcom: sdm845-oneplus: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 09/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 10/12] arm64: dts: qcom: sdm845-lg: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 11/12] arm64: dts: qcom: sdm845-xiaomi-beryllium: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: " David Heidelberg via B4 Relay
2026-11-18 17:37 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-221681@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox