Devicetree
 help / color / mirror / Atom feed
* [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660
@ 2026-11-18 17:25 David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 01/12] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string David Heidelberg via B4 Relay
                   ` (11 more replies)
  0 siblings, 12 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

Includes basic vbus regulator support for:
 - SHIFT 6MQ
 - Pixel 3 / 3a / 3 XL / 3a XL
 - OnePlus 6 / 6T
 - Xiaomi Poco F1
 - LG G7 / V40

All devices downstream sources using default range 0.5 - 1.5 A.

Validated by looking for `qcom,otg-cl-ua` and default values when
property is not set in the driver.

This series shouldn't change existing behaviour (except register write
execution order). Without Type-C driver this merely replace the write of
the SMB charger to manually control the OTG block.

As a follow-up with the latest upstreamed Type-C driver, this change
will allow setting USB OTG, thus power devices connected to the phone.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v2:
- pmi8998 and pm660 belongs into the different generation than pm8150b.
  Adjust the device-tree, code, and commit msg accordingly. (Konrad)
- Link to v1: https://patch.msgid.link/20261031-pmi8998-vbus-v1-0-4d805e5a0f27@ixit.cz

---
David Heidelberg (12):
      regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string
      regulator: qcom_usb_vbus: Add support for pmi8998
      power: supply: qcom_smbx: Do not interfere with vbus driver
      dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660
      arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster
      arm64: dts: qcom: pm660: Add node for PMIC VBUS booster
      arm64: dts: qcom: sdm845-google: Enable vbus support
      arm64: dts: qcom: sdm845-oneplus: Enable vbus support
      arm64: dts: qcom: sdm845-shift-axolotl: Enable vbus support
      arm64: dts: qcom: sdm845-lg: Enable vbus support
      arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable vbus support
      arm64: dts: qcom: sdm670-google: Enable vbus support

 .../bindings/regulator/qcom,usb-vbus-regulator.yaml        |  5 +++++
 arch/arm64/boot/dts/qcom/pm660.dtsi                        |  7 +++++++
 arch/arm64/boot/dts/qcom/pmi8998.dtsi                      |  7 +++++++
 arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi         |  7 +++++++
 arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi         |  7 +++++++
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi             |  7 +++++++
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi        |  7 +++++++
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts          |  7 +++++++
 .../boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi      |  8 +++++++-
 drivers/power/supply/qcom_smbx.c                           | 14 --------------
 drivers/regulator/qcom_usb_vbus-regulator.c                | 14 +++++++++++++-
 11 files changed, 74 insertions(+), 16 deletions(-)
---
base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
change-id: 20261027-pmi8998-vbus-227837a4dfa0

Best regards,
--  
David Heidelberg <david@ixit.cz>



^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v2 01/12] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998 David Heidelberg via B4 Relay
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

Replace the bogus "GPL v2" with "GPL" as MODULE_LICNSE() string. The
value does not declare the module's exact license, but only lets the
module loader test whether the module is Free Software or not.

See commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs.
"GPL v2" bogosity") in the details of the issue. The fix is to use
"GPL" for all modules under any variant of the GPL.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 drivers/regulator/qcom_usb_vbus-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/qcom_usb_vbus-regulator.c b/drivers/regulator/qcom_usb_vbus-regulator.c
index d909a6f2b7f14..88f5a6ba79e6e 100644
--- a/drivers/regulator/qcom_usb_vbus-regulator.c
+++ b/drivers/regulator/qcom_usb_vbus-regulator.c
@@ -176,9 +176,9 @@ static struct platform_driver qcom_usb_vbus_regulator_driver = {
 		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
 		.of_match_table = qcom_usb_vbus_regulator_match,
 	},
 	.probe		= qcom_usb_vbus_regulator_probe,
 };
 module_platform_driver(qcom_usb_vbus_regulator_driver);
 
 MODULE_DESCRIPTION("Qualcomm USB vbus regulator driver");
-MODULE_LICENSE("GPL v2");
+MODULE_LICENSE("GPL");

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 01/12] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:43   ` sashiko-bot
  2026-11-18 17:25 ` [PATCH v2 03/12] power: supply: qcom_smbx: Do not interfere with vbus driver David Heidelberg via B4 Relay
                   ` (9 subsequent siblings)
  11 siblings, 1 reply; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

The PMI8998 uses different register layout, but due to the limited
functionality of the qcom_usb_vbus driver, the basic registers are the
same as the PM8150B, thus reuse these. For more advanced features it'll
differ.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 drivers/regulator/qcom_usb_vbus-regulator.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/regulator/qcom_usb_vbus-regulator.c b/drivers/regulator/qcom_usb_vbus-regulator.c
index 88f5a6ba79e6e..0617106a82cda 100644
--- a/drivers/regulator/qcom_usb_vbus-regulator.c
+++ b/drivers/regulator/qcom_usb_vbus-regulator.c
@@ -63,16 +63,27 @@ static const struct qcom_usb_vbus_reg_data pm8150b_data = {
 	.otg_en_src_cfg = OTG_EN_SRC_CFG,
 	.csel_reg = OTG_CURRENT_LIMIT_CFG,
 	.csel_mask = OTG_CURRENT_LIMIT_MASK,
 	.curr_table = curr_table,
 	.n_current_limits = ARRAY_SIZE(curr_table),
 	.ops = &qcom_usb_vbus_reg_ops,
 };
 
+static const struct qcom_usb_vbus_reg_data pmi8998_data = {
+	.cmd_otg = CMD_OTG,
+	.otg_cfg = OTG_CFG,
+	.otg_en_src_cfg = OTG_EN_SRC_CFG,
+	.csel_reg = OTG_CURRENT_LIMIT_CFG,
+	.csel_mask = OTG_CURRENT_LIMIT_MASK,
+	.curr_table = curr_table,
+	.n_current_limits = ARRAY_SIZE(curr_table),
+	.ops = &qcom_usb_vbus_reg_ops,
+};
+
 static const struct regulator_ops qcom_usb_vbus_pm4125_reg_ops = {
 	.enable = regulator_enable_regmap,
 	.disable = regulator_disable_regmap,
 	.is_enabled = regulator_is_enabled_regmap,
 	.get_voltage_sel = regulator_get_voltage_sel_regmap,
 	.set_voltage_sel = regulator_set_voltage_sel_regmap,
 	.list_voltage = regulator_list_voltage_table,
 };
@@ -161,16 +172,17 @@ static int qcom_usb_vbus_regulator_probe(struct platform_device *pdev)
 	regmap_update_bits(regmap, base + data->otg_cfg, data->otg_en_src_cfg, 0);
 
 	return 0;
 }
 
 static const struct of_device_id qcom_usb_vbus_regulator_match[] = {
 	{ .compatible = "qcom,pm8150b-vbus-reg", .data = &pm8150b_data },
 	{ .compatible = "qcom,pm4125-vbus-reg",  .data = &pm4125_data },
+	{ .compatible = "qcom,pmi8998-vbus-reg", .data = &pmi8998_data },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, qcom_usb_vbus_regulator_match);
 
 static struct platform_driver qcom_usb_vbus_regulator_driver = {
 	.driver		= {
 		.name	= "qcom-usb-vbus-regulator",
 		.probe_type = PROBE_PREFER_ASYNCHRONOUS,

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 03/12] power: supply: qcom_smbx: Do not interfere with vbus driver
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 01/12] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998 David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660 David Heidelberg via B4 Relay
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

Charger should not touch bits handled by OTG block handled by the vbus
driver.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 drivers/power/supply/qcom_smbx.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/power/supply/qcom_smbx.c b/drivers/power/supply/qcom_smbx.c
index c6188c915703a..a4f5ffd3cd6e5 100644
--- a/drivers/power/supply/qcom_smbx.c
+++ b/drivers/power/supply/qcom_smbx.c
@@ -96,28 +96,16 @@
 #define USBIN_ICL_CHANGE_RT_STS_BIT			BIT(6)
 #define USBIN_SOURCE_CHANGE_RT_STS_BIT			BIT(5)
 #define USBIN_PLUGIN_RT_STS_BIT				BIT(4)
 #define USBIN_OV_RT_STS_BIT				BIT(3)
 #define USBIN_UV_RT_STS_BIT				BIT(2)
 #define USBIN_LT_3P6V_RT_STS_BIT			BIT(1)
 #define USBIN_COLLAPSE_RT_STS_BIT			BIT(0)
 
-#define OTG_CFG						0x153
-#define OTG_RESERVED_MASK				GENMASK(7, 6)
-#define DIS_OTG_ON_TLIM_BIT				BIT(5)
-#define QUICKSTART_OTG_FASTROLESWAP_BIT			BIT(4)
-#define INCREASE_DFP_TIME_BIT				BIT(3)
-#define ENABLE_OTG_IN_DEBUG_MODE_BIT			BIT(2)
-#define OTG_EN_SRC_CFG_BIT				BIT(1)
-#define CONCURRENT_MODE_CFG_BIT				BIT(0)
-
-#define OTG_ENG_OTG_CFG					0x1C0
-#define ENG_BUCKBOOST_HALT1_8_MODE_BIT			BIT(0)
-
 #define APSD_STATUS					0x307
 #define APSD_STATUS_7_BIT				BIT(7)
 #define HVDCP_CHECK_TIMEOUT_BIT				BIT(6)
 #define SLOW_PLUGIN_TIMEOUT_BIT				BIT(5)
 #define ENUMERATION_DONE_BIT				BIT(4)
 #define VADP_CHANGE_DONE_AFTER_AUTH_BIT			BIT(3)
 #define QC_AUTH_DONE_STATUS_BIT				BIT(2)
 #define QC_CHARGER_BIT					BIT(1)
@@ -811,18 +799,16 @@ static const struct smb_init_register smb_init_seq[] = {
 	  .val = VCONN_EN_SRC_BIT },
 	/*
 	 * Disable Type-C factory mode and stay in Attached.SRC state when VCONN
 	 * over-current happens
 	 */
 	{ .addr = TYPE_C_CFG,
 	  .mask = FACTORY_MODE_DETECTION_EN_BIT | VCONN_OC_CFG_BIT,
 	  .val = 0 },
-	/* Configure VBUS for software control */
-	{ .addr = OTG_CFG, .mask = OTG_EN_SRC_CFG_BIT, .val = 0 },
 	/*
 	 * Use VBAT to determine the recharge threshold when battery is full
 	 * rather than the state of charge.
 	 */
 	{ .addr = FG_UPDATE_CFG_2_SEL,
 	  .mask = SOC_LT_CHG_RECHARGE_THRESH_SEL_BIT |
 		  VBT_LT_CHG_RECHARGE_THRESH_SEL_BIT,
 	  .val = VBT_LT_CHG_RECHARGE_THRESH_SEL_BIT },

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (2 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 03/12] power: supply: qcom_smbx: Do not interfere with vbus driver David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:33   ` sashiko-bot
  2026-11-18 17:25 ` [PATCH v2 05/12] arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster David Heidelberg via B4 Relay
                   ` (7 subsequent siblings)
  11 siblings, 1 reply; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

The VBUS register block on the PMI8998 and PM660 PMIC shares the design.
Define corresponding compatible string, having the
qcom,pmi8998-vbus-reg as a fallback.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml       | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
index 024b34d0eb1a6..96f984060ce4d 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
@@ -22,22 +22,27 @@ description: |
   and 5.0 V.
 
 properties:
   compatible:
     oneOf:
       - enum:
           - qcom,pm8150b-vbus-reg
           - qcom,pm4125-vbus-reg
+          - qcom,pmi8998-vbus-reg
       - items:
           - enum:
               - qcom,pm6150-vbus-reg
               - qcom,pm7250b-vbus-reg
               - qcom,pmi632-vbus-reg
           - const: qcom,pm8150b-vbus-reg
+      - items:
+          - enum:
+              - qcom,pm660-vbus-reg
+          - const: qcom,pm8998-vbus-reg
 
   reg:
     maxItems: 1
     description: VBUS output base address
 
 allOf:
   - $ref: regulator.yaml#
   - if:

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 05/12] arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (3 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660 David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 06/12] arm64: dts: qcom: pm660: " David Heidelberg via B4 Relay
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

Add the required DTS node for the USB VBUS output regulator, which is
available on PMI8998. This will provide the VBUS source to connected
peripherals.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/pmi8998.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
index cd3f0790fd420..9d65dd4abcdbb 100644
--- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
@@ -24,16 +24,23 @@ pmi8998_charger: charger@1000 {
 
 			io-channels = <&pmi8998_rradc 3>,
 				      <&pmi8998_rradc 4>;
 			io-channel-names = "usbin_i", "usbin_v";
 
 			status = "disabled";
 		};
 
+		pmi8998_vbus: usb-vbus-regulator@1100 {
+			compatible = "qcom,pmi8998-vbus-reg";
+			reg = <0x1100>;
+
+			status = "disabled";
+		};
+
 		pmi8998_gpios: gpio@c000 {
 			compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
 			gpio-ranges = <&pmi8998_gpios 0 0 14>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 06/12] arm64: dts: qcom: pm660: Add node for PMIC VBUS booster
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (4 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 05/12] arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:35   ` sashiko-bot
  2026-11-18 17:25 ` [PATCH v2 07/12] arm64: dts: qcom: sdm845-google: Enable vbus support David Heidelberg via B4 Relay
                   ` (5 subsequent siblings)
  11 siblings, 1 reply; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

Add the required DTS node for the USB VBUS output regulator, which is
available on PM660. This will provide the VBUS source to connected
peripherals.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/pm660.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm660.dtsi b/arch/arm64/boot/dts/qcom/pm660.dtsi
index 156b2ddff0dcb..fe9ef304d64e7 100644
--- a/arch/arm64/boot/dts/qcom/pm660.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm660.dtsi
@@ -85,16 +85,23 @@ pm660_charger: charger@1000 {
 
 			io-channels = <&pm660_rradc 3>,
 				      <&pm660_rradc 4>;
 			io-channel-names = "usbin_i", "usbin_v";
 
 			status = "disabled";
 		};
 
+		pm660_vbus: usb-vbus-regulator@1100 {
+			compatible = "qcom,pm660-vbus-reg", "qcom,pmi8998-vbus-reg";
+			reg = <0x1100>;
+
+			status = "disabled";
+		};
+
 		pm660_temp: temp-alarm@2400 {
 			compatible = "qcom,spmi-temp-alarm";
 			reg = <0x2400>;
 			interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>;
 			io-channels = <&pm660_adc ADC5_DIE_TEMP>;
 			io-channel-names = "thermal";
 			#thermal-sensor-cells = <0>;
 		};

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 07/12] arm64: dts: qcom: sdm845-google: Enable vbus support
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (5 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 06/12] arm64: dts: qcom: pm660: " David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 08/12] arm64: dts: qcom: sdm845-oneplus: " David Heidelberg via B4 Relay
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

On this device, vbus was setup and switched off by the charger driver.
Enable proper driver.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
index 3c9656b88b696..417c767a1821d 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
@@ -451,16 +451,23 @@ &pm8998_resin {
 };
 
 &pmi8998_charger {
 	monitored-battery = <&battery>;
 
 	status = "okay";
 };
 
+&pmi8998_vbus {
+	regulator-min-microamp = <500000>;
+	regulator-max-microamp = <1500000>;
+
+	status = "okay";
+};
+
 &qupv3_id_0 {
 	status = "okay";
 };
 
 &qupv3_id_1 {
 	status = "okay";
 };
 

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 08/12] arm64: dts: qcom: sdm845-oneplus: Enable vbus support
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (6 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 07/12] arm64: dts: qcom: sdm845-google: Enable vbus support David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 09/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

On this device, vbus was setup and switched off by the charger driver.
Enable proper driver.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index 1df09da3c4d71..4996ce24fee36 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -660,16 +660,23 @@ led-1 {
 		color = <LED_COLOR_ID_YELLOW>;
 		led-sources = <2>;
 		led-max-microamp = <500000>;
 		flash-max-microamp = <1500000>;
 		flash-max-timeout-us = <1280000>;
 	};
 };
 
+&pmi8998_vbus {
+	regulator-min-microamp = <500000>;
+	regulator-max-microamp = <1500000>;
+
+	status = "okay";
+};
+
 &q6afedai {
 	dai@22 {
 		reg = <QUATERNARY_MI2S_RX>;
 		qcom,sd-lines = <1>;
 	};
 
 	dai@23 {
 		reg = <QUATERNARY_MI2S_TX>;

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 09/12] arm64: dts: qcom: sdm845-shift-axolotl: Enable vbus support
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (7 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 08/12] arm64: dts: qcom: sdm845-oneplus: " David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 10/12] arm64: dts: qcom: sdm845-lg: " David Heidelberg via B4 Relay
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

On this device, vbus was setup and switched off by the charger driver.
Enable proper driver.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 1b0eaeafbd517..124717214edd6 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -654,16 +654,23 @@ led-1 {
 		color = <LED_COLOR_ID_YELLOW>;
 		led-sources = <2>;
 		led-max-microamp = <100000>;
 		flash-max-microamp = <1100000>;
 		flash-max-timeout-us = <1280000>;
 	};
 };
 
+&pmi8998_vbus {
+	regulator-min-microamp = <500000>;
+	regulator-max-microamp = <1500000>;
+
+	status = "okay";
+};
+
 &qup_uart9_rx {
 	drive-strength = <2>;
 	bias-pull-up;
 };
 
 &qup_uart9_tx {
 	drive-strength = <2>;
 	bias-disable;

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 10/12] arm64: dts: qcom: sdm845-lg: Enable vbus support
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (8 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 09/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 11/12] arm64: dts: qcom: sdm845-xiaomi-beryllium: " David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: " David Heidelberg via B4 Relay
  11 siblings, 0 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

On this device, vbus was setup and switched off by the charger driver.
Enable proper driver.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 6989532584251..e868cf44956b5 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -548,16 +548,23 @@ led@4 {
 
 		led@5 {
 			reg = <5>;
 			color = <LED_COLOR_ID_RED>;
 		};
 	};
 };
 
+&pmi8998_vbus {
+	regulator-min-microamp = <500000>;
+	regulator-max-microamp = <1500000>;
+
+	status = "okay";
+};
+
 &pmi8998_wled {
 	qcom,current-limit-microamp = <20000>;
 	qcom,ovp-millivolt = <29600>;
 	qcom,switching-freq = <800>;
 	qcom,cabc;
 	status = "okay";
 };
 

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 11/12] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable vbus support
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (9 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 10/12] arm64: dts: qcom: sdm845-lg: " David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:25 ` [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: " David Heidelberg via B4 Relay
  11 siblings, 0 replies; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

On this device, vbus was setup and switched off by the charger driver.
Enable proper driver.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index d57851b0b9419..aab5738253914 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -418,16 +418,23 @@ led-1 {
 	};
 };
 
 &pm8998_resin {
 	linux,code = <KEY_VOLUMEDOWN>;
 	status = "okay";
 };
 
+&pmi8998_vbus {
+	regulator-min-microamp = <500000>;
+	regulator-max-microamp = <1500000>;
+
+	status = "okay";
+};
+
 /* QUAT I2S Uses 1 I2S SD Line for audio on TAS2559/60 amplifiers */
 &q6afedai {
 	dai@22 {
 		reg = <QUATERNARY_MI2S_RX>;
 		qcom,sd-lines = <0>;
 	};
 };
 
@@ -682,9 +689,8 @@ &wifi {
 	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
 	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
 	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
 	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 
 	qcom,calibration-variant = "xiaomi_beryllium";
 	qcom,snoc-host-cap-skip-quirk;
 };
-

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: Enable vbus support
  2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
                   ` (10 preceding siblings ...)
  2026-11-18 17:25 ` [PATCH v2 11/12] arm64: dts: qcom: sdm845-xiaomi-beryllium: " David Heidelberg via B4 Relay
@ 2026-11-18 17:25 ` David Heidelberg via B4 Relay
  2026-11-18 17:37   ` sashiko-bot
  11 siblings, 1 reply; 17+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-18 17:25 UTC (permalink / raw)
  To: Alexey Minnekhanov, Robin Snyders, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
	Bjorn Andersson, Konrad Dybcio, Abel Vesa, Casey Connolly,
	Sebastian Reichel
  Cc: Richard Acayan, linux-arm-msm, linux-kernel, devicetree,
	Sebastian Reichel, linux-pm, phone-devel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

On this device, vbus was setup and switched off by the charger driver.
Enable proper driver.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
index 8f91faf8a9cc5..9c95855b56e7b 100644
--- a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
@@ -604,16 +604,23 @@ cam_vio_pin: cam-vio-state {
 		power-source = <0>;
 	};
 };
 
 &pm660_rradc {
 	status = "okay";
 };
 
+&pm660_vbus {
+	regulator-min-microamp = <500000>;
+	regulator-max-microamp = <1500000>;
+
+	status = "okay";
+};
+
 &pm660l_flash {
 	status = "okay";
 
 	led-0 {
 		function = LED_FUNCTION_FLASH;
 		color = <LED_COLOR_ID_WHITE>;
 		led-sources = <1>, <2>;
 		led-max-microamp = <500000>;

-- 
2.55.0



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660
  2026-11-18 17:25 ` [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660 David Heidelberg via B4 Relay
@ 2026-11-18 17:33   ` sashiko-bot
  0 siblings, 0 replies; 17+ messages in thread
From: sashiko-bot @ 2026-11-18 17:33 UTC (permalink / raw)
  To: David Heidelberg; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: regulator: typo in fallback compatible for
  qcom,pm660-vbus-reg
--

commit d53eae4793d2d86b3e41fd0d2b1c0495b964d938
Author: David Heidelberg <david@ixit.cz>

dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660

This commit adds the qcom,pmi8998-vbus-reg and qcom,pm660-vbus-reg
compatible strings to the Qualcomm USB VBUS regulator DT binding schema.

> diff --git a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> index 024b34d0eb1a6..96f984060ce4d 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> @@ -27,12 +27,17 @@ properties:
>        - enum:
>            - qcom,pm8150b-vbus-reg
>            - qcom,pm4125-vbus-reg
> +          - qcom,pmi8998-vbus-reg
>        - items:
>            - enum:
>                - qcom,pm6150-vbus-reg
>                - qcom,pm7250b-vbus-reg
>                - qcom,pmi632-vbus-reg
>            - const: qcom,pm8150b-vbus-reg
> +      - items:
> +          - enum:
> +              - qcom,pm660-vbus-reg
> +          - const: qcom,pm8998-vbus-reg

[Severity: Medium]
Should the fallback compatible for qcom,pm660-vbus-reg be
qcom,pmi8998-vbus-reg instead of qcom,pm8998-vbus-reg?

The standalone enum above and qcom_usb_vbus_regulator_match[] in
drivers/regulator/qcom_usb_vbus-regulator.c both use
qcom,pmi8998-vbus-reg, so a PM660 node using that fallback will fail
dtbs_check validation against this schema.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-pmi8998-vbus-v2-0-3c77a72b280a@ixit.cz?part=4

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 06/12] arm64: dts: qcom: pm660: Add node for PMIC VBUS booster
  2026-11-18 17:25 ` [PATCH v2 06/12] arm64: dts: qcom: pm660: " David Heidelberg via B4 Relay
@ 2026-11-18 17:35   ` sashiko-bot
  0 siblings, 0 replies; 17+ messages in thread
From: sashiko-bot @ 2026-11-18 17:35 UTC (permalink / raw)
  To: David Heidelberg; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: pm660: compatible mismatch with
  usb-vbus-regulator schema
--

commit 4860c32276902904ecaa66c748be4bfd758d569f
Author: David Heidelberg <david@ixit.cz>

arm64: dts: qcom: pm660: Add node for PMIC VBUS booster

This commit adds the USB VBUS output regulator device tree node for the
PM660 PMIC.

> diff --git a/arch/arm64/boot/dts/qcom/pm660.dtsi b/arch/arm64/boot/dts/qcom/pm660.dtsi
> index 156b2ddff0dcb..fe9ef304d64e7 100644
> --- a/arch/arm64/boot/dts/qcom/pm660.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm660.dtsi
> @@ -90,6 +90,13 @@ pm660_charger: charger@1000 {
>  			status = "disabled";
>  		};
>  
> +		pm660_vbus: usb-vbus-regulator@1100 {
> +			compatible = "qcom,pm660-vbus-reg", "qcom,pmi8998-vbus-reg";
> +			reg = <0x1100>;
> +
> +			status = "disabled";
> +		};

[Severity: Medium]
Does the fallback compatible "qcom,pmi8998-vbus-reg" here mismatch the
binding schema added in commit "dt-bindings: regulator:
qcom,usb-vbus-regulator: Add pmi8998 and pm660"?

While qcom_usb_vbus_regulator_match in
drivers/regulator/qcom_usb_vbus-regulator.c matches
"qcom,pmi8998-vbus-reg", the binding defines the fallback constant as
"qcom,pm8998-vbus-reg" (missing the "i"):

Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml:
      - items:
          - enum:
              - qcom,pm660-vbus-reg
          - const: qcom,pm8998-vbus-reg

This mismatch causes dtbs_check validation to fail for boards including
pm660.dtsi.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-pmi8998-vbus-v2-0-3c77a72b280a@ixit.cz?part=6

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: Enable vbus support
  2026-11-18 17:25 ` [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: " David Heidelberg via B4 Relay
@ 2026-11-18 17:37   ` sashiko-bot
  0 siblings, 0 replies; 17+ messages in thread
From: sashiko-bot @ 2026-11-18 17:37 UTC (permalink / raw)
  To: David Heidelberg; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: sdm670-google: enabling pm660_vbus fails
  dtbs_check
--

commit 6df670bdbe84094d0f566a1be877a69fbfe53de2
Author: David Heidelberg <david@ixit.cz>

arm64: dts: qcom: sdm670-google: Enable vbus support

This commit enables the pm660_vbus regulator with current limits on
Google SDM670 devices.

> diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
> index 8f91faf8a9cc5..9c95855b56e7b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
> @@ -609,6 +609,13 @@ &pm660_rradc {
>  	status = "okay";
>  };
>  
> +&pm660_vbus {
> +	regulator-min-microamp = <500000>;
> +	regulator-max-microamp = <1500000>;
> +
> +	status = "okay";
> +};

[Severity: Low]
Does enabling pm660_vbus cause dtbs_check to fail on sdm670-google DTs?

In arch/arm64/boot/dts/qcom/pm660.dtsi, pm660_vbus uses compatible =
"qcom,pm660-vbus-reg", "qcom,pmi8998-vbus-reg", matching the driver,
whereas Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
requires const: qcom,pm8998-vbus-reg (missing the "i") and omits
qcom,pm660-vbus-reg and qcom,pmi8998-vbus-reg from the allOf rule for
regulator-min-microamp and regulator-max-microamp.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-pmi8998-vbus-v2-0-3c77a72b280a@ixit.cz?part=12

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998
  2026-11-18 17:25 ` [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998 David Heidelberg via B4 Relay
@ 2026-11-18 17:43   ` sashiko-bot
  0 siblings, 0 replies; 17+ messages in thread
From: sashiko-bot @ 2026-11-18 17:43 UTC (permalink / raw)
  To: David Heidelberg; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] regulator: qcom_usb_vbus: pmi8998_data duplicates pm8150b_data
  verbatim
--

commit 236079d01ccf3acd0da063e72d90d4189d163862
Author: David Heidelberg <david@ixit.cz>

regulator: qcom_usb_vbus: Add support for pmi8998

This commit adds compatible string and register configuration data for
the PMI8998 USB VBUS regulator.

> diff --git a/drivers/regulator/qcom_usb_vbus-regulator.c b/drivers/regulator/qcom_usb_vbus-regulator.c
> index 88f5a6ba79e6e..0617106a82cda 100644
> --- a/drivers/regulator/qcom_usb_vbus-regulator.c
> +++ b/drivers/regulator/qcom_usb_vbus-regulator.c
> @@ -68,6 +68,17 @@ static const struct qcom_usb_vbus_reg_data pm8150b_data = {
>  	.ops = &qcom_usb_vbus_reg_ops,
>  };
>  
> +static const struct qcom_usb_vbus_reg_data pmi8998_data = {
> +	.cmd_otg = CMD_OTG,
> +	.otg_cfg = OTG_CFG,
> +	.otg_en_src_cfg = OTG_EN_SRC_CFG,
> +	.csel_reg = OTG_CURRENT_LIMIT_CFG,
> +	.csel_mask = OTG_CURRENT_LIMIT_MASK,
> +	.curr_table = curr_table,
> +	.n_current_limits = ARRAY_SIZE(curr_table),
> +	.ops = &qcom_usb_vbus_reg_ops,
> +};
> +
>  static const struct regulator_ops qcom_usb_vbus_pm4125_reg_ops = {
>  	.enable = regulator_enable_regmap,
>  	.disable = regulator_disable_regmap,
> @@ -166,6 +177,7 @@ static int qcom_usb_vbus_regulator_probe(struct platform_device *pdev)
>  static const struct of_device_id qcom_usb_vbus_regulator_match[] = {
>  	{ .compatible = "qcom,pm8150b-vbus-reg", .data = &pm8150b_data },
>  	{ .compatible = "qcom,pm4125-vbus-reg",  .data = &pm4125_data },
> +	{ .compatible = "qcom,pmi8998-vbus-reg", .data = &pmi8998_data },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, qcom_usb_vbus_regulator_match);

[Severity: Low]
Since pmi8998_data is identical to pm8150b_data defined right above it,
could the qcom,pmi8998-vbus-reg entry in qcom_usb_vbus_regulator_match
point directly to &pm8150b_data instead of duplicating the descriptor?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-pmi8998-vbus-v2-0-3c77a72b280a@ixit.cz?part=2

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2026-11-18 17:43 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 01/12] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998 David Heidelberg via B4 Relay
2026-11-18 17:43   ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 03/12] power: supply: qcom_smbx: Do not interfere with vbus driver David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660 David Heidelberg via B4 Relay
2026-11-18 17:33   ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 05/12] arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 06/12] arm64: dts: qcom: pm660: " David Heidelberg via B4 Relay
2026-11-18 17:35   ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 07/12] arm64: dts: qcom: sdm845-google: Enable vbus support David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 08/12] arm64: dts: qcom: sdm845-oneplus: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 09/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 10/12] arm64: dts: qcom: sdm845-lg: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 11/12] arm64: dts: qcom: sdm845-xiaomi-beryllium: " David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: " David Heidelberg via B4 Relay
2026-11-18 17:37   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox