* [PATCH] arm64: dts: qcom: glymur-crd: Enable pull-up bias for lid sensor
@ 2026-11-18 18:22 Pankaj Patil
2026-11-18 18:34 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Pankaj Patil @ 2026-11-18 18:22 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, Pankaj Patil
Hall-effect sensor on Glymur CRD has a 10k ohm pull-up resistor
Fix the hall-int-n-state node to enable the pull-up bias
Fixes: 627aab9bfe03 ("arm64: dts: qcom: glymur-crd: Enable LID sensor")
Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
index 3a9cd5f3ec2b..74588f4f7a86 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
@@ -819,7 +819,7 @@ edp_reg_en: edp-reg-en-state {
hall_int_n_default: hall-int-n-state {
pins = "gpio92";
function = "gpio";
- bias-disable;
+ bias-pull-up;
};
ec_int_n_default: ec-int-n-state {
---
base-commit: 7cfbf79c66c63e807ea452abf0546e6f6d6833a6
change-id: 20261118-lid_pull_up_fix-123aa8c6b744
Best regards,
--
Pankaj Patil <pankaj.patil@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable pull-up bias for lid sensor
2026-11-18 18:22 [PATCH] arm64: dts: qcom: glymur-crd: Enable pull-up bias for lid sensor Pankaj Patil
@ 2026-11-18 18:34 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-18 18:34 UTC (permalink / raw)
To: Pankaj Patil; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: glymur-crd: TLMM bias-pull-up contradicts
external pull-up
--
commit 33a3a23eacc897dad84afcf17e419a24de929c16
Author: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
arm64: dts: qcom: glymur-crd: Enable pull-up bias for lid sensor
This commit replaces bias-disable with bias-pull-up on gpio92 in the
hall-int-n-state pinctrl node for the lid Hall-effect sensor on Glymur
CRD.
> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> index 3a9cd5f3ec2b8..74588f4f7a86e 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> @@ -819,7 +819,7 @@ edp_reg_en: edp-reg-en-state {
> hall_int_n_default: hall-int-n-state {
> pins = "gpio92";
> function = "gpio";
> - bias-disable;
> + bias-pull-up;
> };
[Severity: Medium]
Should hall_int_n_default enable bias-pull-up if the board already has
an external 10k ohm pull-up resistor?
In msm_config_group_set(), bias-pull-up enables the SoC's internal TLMM
pull-up resistor rather than describing an external board resistor. If
an external 10k ohm pull-up is populated on gpio92, enabling the
internal pull-up in parallel draws extra leakage current whenever the
lid is closed and switch-lid (GPIO_ACTIVE_LOW) is held low; if the
external resistor is unpopulated and the internal pull-up is needed, the
commit message says the opposite.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-lid_pull_up_fix-v1-1-4bb84dc70067@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-18 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 18:22 [PATCH] arm64: dts: qcom: glymur-crd: Enable pull-up bias for lid sensor Pankaj Patil
2026-11-18 18:34 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox