Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Iker Pedrosa" <ikerpedrosam@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] riscv: dts: spacemit: k1: add PowerVR GPU device node
Date: Wed, 18 Nov 2026 19:09:00 +0000	[thread overview]
Message-ID: <sashiko-outbox-221816@kernel.org> (raw)
In-Reply-To: <20261118-orangepi-gpu-v2-1-f68676f844eb@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] riscv: dts: spacemit: build failure from missing
  spacemit,k1-power.h header
--

commit efc5334efe329206674ea5227e542cbbf6e41d33
Author: Iker Pedrosa <ikerpedrosam@gmail.com>

riscv: dts: spacemit: k1: add PowerVR GPU device node

This commit adds the PowerVR Rogue GPU device tree node for the SpacemiT
K1 SoC and enables it by default.

> diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
> index 5d5f7f8a393d3..15bee2137e14e 100644
> --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
> @@ -5,6 +5,7 @@
>  
>  #include <dt-bindings/clock/spacemit,k1-syscon.h>
>  #include <dt-bindings/phy/phy.h>
> +#include <dt-bindings/power/spacemit,k1-power.h>
>  
>  #include "k1-pdma.h"
>  
> @@ -1119,6 +1120,16 @@ multimedia-bus {
>  			#size-cells = <2>;
>  			dma-ranges = <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>,
>  				     <0x0 0x80000000 0x1 0x00000000 0x3 0x80000000>;
> +
> +			gpu: gpu@cac00000 {
> +				compatible = "spacemit,k1-gpu", "img,img-bxe-2-32", "img,img-rogue";
> +				reg = <0x0 0xcac00000 0x0 0x80000>;
> +				interrupts = <75>;
> +				clocks = <&syscon_apmu CLK_GPU>;
> +				clock-names = "core";
> +				resets = <&syscon_apmu RESET_GPU>;
> +				power-domains = <&syscon_apmu K1_PMDOMAIN_GPU>;
> +			};
>  		};
>  
>  		network-bus {

[Severity: High]
Does this break the DTB build when CONFIG_ARCH_SPACEMIT is enabled?
Neither include/dt-bindings/power/spacemit,k1-power.h nor K1_PMDOMAIN_GPU
is present in the tree yet, so preprocessing any SpacemiT K1 board DTS
that includes k1.dtsi fails until the prerequisite power-domain series is
applied.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-orangepi-gpu-v2-1-f68676f844eb@gmail.com?part=1

      reply	other threads:[~2026-11-18 19:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:59 [PATCH v2] riscv: dts: spacemit: k1: add PowerVR GPU device node Iker Pedrosa
2026-11-18 19:09 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221816@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ikerpedrosam@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox