Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Dmitry Yashin" <dmt.yashin@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 3/4] arm64: dts: rockchip: add Forlinx OK3568-C
Date: Wed, 18 Nov 2026 23:53:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-222218@kernel.org> (raw)
In-Reply-To: <20261119-ok3568-c-v3-3-071840643591@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] arm64: dts: rockchip: conflicting GPIO polarity in
  vcc1v8_wifi_bt_reg_on
- [Medium] arm64: dts: rockchip: missing assigned-clocks on gmac0/1 in
  rk3568-ok3568-c
--

commit b8a53fc702b227f666755566c4fdee7cf810512c
Author: Dmitry Yashin <dmt.yashin@gmail.com>

arm64: dts: rockchip: add Forlinx OK3568-C

This commit adds a devicetree for the Forlinx OK3568-C carrier board,
which hosts the FET3568-C System on Module.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-ok3568-c.dts b/arch/arm64/boot/dts/rockchip/rk3568-ok3568-c.dts
> new file mode 100644
> index 0000000000000..94f08fdc11433
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-ok3568-c.dts
> @@ -0,0 +1,566 @@

[ ... ]

> +	vcc1v8_wifi_bt_reg_on: regulator-1v8-vcc-wifi-bt-reg-on {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&wifi_reg_on>;
> +		off-on-delay-us = <20000>;
> +		regulator-name = "vcc1v8_wifi_bt_reg_on";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		startup-delay-us = <200>;
> +	};

[Severity: Medium]
Does vcc1v8_wifi_bt_reg_on specify conflicting polarities with both
enable-active-high and GPIO_ACTIVE_LOW?

For regulator-fixed nodes with enable-active-high, of_gpio_quirk_polarity()
emits a runtime warning and strips OF_GPIO_ACTIVE_LOW.  If the hardware
enable signal is active-low, enable-active-high should be dropped so the
regulator does not invert the polarity and keep the WiFi/BT module powered
off; if it is active-high, gpios should use GPIO_ACTIVE_HIGH.

[ ... ]

> +&gmac0 {
> +	clock_in_out = "output";
> +	phy-handle = <&rgmii_phy0>;
> +	phy-mode = "rgmii-id";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&gmac0_miim
> +		     &gmac0_tx_bus2
> +		     &gmac0_rx_bus2
> +		     &gmac0_rgmii_clk
> +		     &gmac0_rgmii_bus
> +		     &gmac0_clkinout
> +		     &eth0_pins>;
> +	status = "okay";
> +};
> +
> +&gmac1 {
> +	clock_in_out = "output";
> +	phy-handle = <&rgmii_phy1>;
> +	phy-mode = "rgmii-id";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&gmac1m1_miim
> +		     &gmac1m1_tx_bus2
> +		     &gmac1m1_rx_bus2
> +		     &gmac1m1_rgmii_clk
> +		     &gmac1m1_rgmii_bus
> +		     &gmac1m1_clkinout
> +		     &eth1m1_pins>;
> +	status = "okay";
> +};

[Severity: Medium]
Should gmac0 and gmac1 configure assigned-clocks, assigned-clock-parents,
and assigned-clock-rates for RGMII clock output?

On RK3568, rk_gmac_clk_init() does not program the GMAC clock muxes or the
125 MHz base rate in RGMII output mode, and SCLK_GMAC0/1_RGMII_SPEED lacks
CLK_SET_RATE_PARENT so runtime link speed changes only switch dividers on
SCLK_GMAC0/1_RX_TX.  Without assigned-clocks in the devicetree to parent
SCLK_GMAC0/1_RX_TX to SCLK_GMAC0/1_RGMII_SPEED and set SCLK_GMAC0/1 to
125 MHz (via CLK_MAC0/1_2TOP), RGMII clock generation depends on the
bootloader having already configured both clock trees.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-ok3568-c-v3-0-071840643591@gmail.com?part=3

  reply	other threads:[~2026-11-18 23:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 23:29 [PATCH v3 0/4] arm64: dts: rockchip: add Forlinx OK3568-C Dmitry Yashin
2026-11-18 23:29 ` [PATCH v3 1/4] dt-bindings: arm: rockchip: add Forlinx FET3568-C Dmitry Yashin
2026-11-18 23:29 ` [PATCH v3 2/4] arm64: dts: " Dmitry Yashin
2026-11-18 23:29 ` [PATCH v3 3/4] arm64: dts: rockchip: add Forlinx OK3568-C Dmitry Yashin
2026-11-18 23:53   ` sashiko-bot [this message]
2026-11-18 23:29 ` [PATCH v3 4/4] arm64: dts: rockchip: add FIT-PCIE-SATA overlay Dmitry Yashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222218@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmt.yashin@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox