From: sashiko-bot@kernel.org
To: "Griffin Kroah-Hartman" <griffin.kroah@fairphone.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
media-ci@linuxtv.org
Subject: Re: [PATCH v4 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Fix DW9800K support
Date: Thu, 19 Nov 2026 09:56:17 +0000 [thread overview]
Message-ID: <sashiko-outbox-222883@kernel.org> (raw)
In-Reply-To: <20261119-b4-dw9800k_cleanup-v4-3-df26c431595e@fairphone.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: missing Fixes trailer for DW9800K actuator
node fix
--
commit e276ea5d27a32b9dc0ddd0532e1d65d1cfbc8d91
Author: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
> arm64: dts: qcom: qcm6490-fairphone-fp5: Fix DW9800K support
>
> Update the node for the DW9800K for correctness.
>
> Now we correctly select SAC3 mode and enable timing-control with the newly
> updated device tree bindings.
>
> This is a breaking change for a part that was previously functioning,
> but only due to manual register writes in the driver. Now that we have
> the correct documentation we are able to update everything to ensure
> functionality with other devices using this part.
>
> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
[Severity: Low]
This fixes the DW9800K actuator properties and pairs with commit
"media: i2c: dw9719: Update DW9800K driver", which carries a Fixes: tag.
Should this also include:
Fixes: 1cf6be79a865 ("arm64: dts: qcom: qcm6490-fairphone-fp5: Add UW cam actuator")
so stable trees backporting the driver update do not miss the required DTS
update?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-b4-dw9800k_cleanup-v4-0-df26c431595e@fairphone.com?part=3
prev parent reply other threads:[~2026-11-19 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:51 [PATCH v4 0/3] Dongwoon DW9800K update patchset Griffin Kroah-Hartman
2026-11-19 9:51 ` [PATCH v4 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K Griffin Kroah-Hartman
2026-11-19 9:51 ` [PATCH v4 2/3] media: i2c: dw9719: Update DW9800K driver Griffin Kroah-Hartman
2026-11-19 10:02 ` sashiko-bot
2026-11-19 9:51 ` [PATCH v4 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Fix DW9800K support Griffin Kroah-Hartman
2026-11-19 9:56 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222883@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=griffin.kroah@fairphone.com \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox