From: sashiko-bot@kernel.org
To: "Griffin Kroah-Hartman" <griffin.kroah@fairphone.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
media-ci@linuxtv.org
Subject: Re: [PATCH v4 2/3] media: i2c: dw9719: Update DW9800K driver
Date: Thu, 19 Nov 2026 10:02:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-222903@kernel.org> (raw)
In-Reply-To: <20261119-b4-dw9800k_cleanup-v4-2-df26c431595e@fairphone.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] media: dw9719: missing model assignment for DW9800K_ID in
dw9719_power_up()
--
commit 27fb69542cedffbeec27abdb7294190f101ca2f8
Author: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
media: i2c: dw9719: Update DW9800K driver
This commit updates the DW9800K actuator support to detect its hardware
device ID from the INFO register and configure SAC modes, VCM prescale,
and SAC timing according to the datasheet.
> diff --git a/drivers/media/i2c/dw9719.c b/drivers/media/i2c/dw9719.c
> index 5d5da0439dba0..efd81a9d7c133 100644
> --- a/drivers/media/i2c/dw9719.c
> +++ b/drivers/media/i2c/dw9719.c
[ ... ]
> @@ -165,6 +171,11 @@ static int dw9719_power_up(struct dw9719_device *dw9719, bool detect)
> dw9719->sac_mode = DW9761_DEFAULT_SAC;
> dw9719->vcm_freq = DW9761_DEFAULT_VCM_FREQ;
> break;
> + case DW9800K_ID:
> + dw9719->sac_mode = DW9800K_DEFAULT_SAC;
> + dw9719->vcm_freq = DW9800K_DEFAULT_DIV;
> + dw9719->sac_time = DW9800K_DEFAULT_SACT;
> + break;
[Severity: Medium]
Should the DW9800K_ID case also set dw9719->model = DW9800K, like the
DW9719_ID and DW9761_ID cases above it?
If the device is instantiated via a generic or fallback ID where
dw9719->model is not already DW9800K, the switch (dw9719->model) below
will take the wrong branch and write the DW9800K defaults using another
model's register layout.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-b4-dw9800k_cleanup-v4-0-df26c431595e@fairphone.com?part=2
next prev parent reply other threads:[~2026-11-19 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:51 [PATCH v4 0/3] Dongwoon DW9800K update patchset Griffin Kroah-Hartman
2026-11-19 9:51 ` [PATCH v4 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K Griffin Kroah-Hartman
2026-11-19 9:51 ` [PATCH v4 2/3] media: i2c: dw9719: Update DW9800K driver Griffin Kroah-Hartman
2026-11-19 10:02 ` sashiko-bot [this message]
2026-11-19 9:51 ` [PATCH v4 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Fix DW9800K support Griffin Kroah-Hartman
2026-11-19 9:56 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222903@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=griffin.kroah@fairphone.com \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox