Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Komal Bajaj" <komal.bajaj@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v6 5/5] arm64: dts: qcom: sm8750: Add EL2 overlay for remoteproc SMMU mappings
Date: Thu, 19 Nov 2026 11:51:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-223064@kernel.org> (raw)
In-Reply-To: <20261119-shikra-el2-v6-5-0e91a1467e79@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: commit message mentions Shikra and omits
  disabled nodes
--

commit 4293b12aa38fd366536aa13846bd84f70cea3ea7
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

> arm64: dts: qcom: sm8750: Add EL2 overlay for remoteproc SMMU mappings
>
> SM8750 board boot Linux under the Gunyah hypervisor, with Linux running
> at EL1. Linux can also be booted directly at EL2 on these devices.
>
> For EL2 boot, describe the IOMMU streams used by the remote processor
> firmware in the DeviceTree consumed by Linux.
>
> Add an EL2-specific DT overlay and apply it to the Shikra IoT variants
> to produce -el2.dtb artifacts alongside the standard DTBs.
>
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

[Severity: Low]
This isn't a bug, but the commit message mentions applying the overlay to
the Shikra IoT variants, whereas arch/arm64/boot/dts/qcom/Makefile applies
sm8750-el2.dtbo to sm8750-mtp.dtb to build sm8750-mtp-el2.dtb.  In addition,
the subject and changelog only mention the remoteproc SMMU mappings, while
arch/arm64/boot/dts/qcom/sm8750-el2.dtso also disables gpu_zap_shader and
iris.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-shikra-el2-v6-0-0e91a1467e79@oss.qualcomm.com?part=5

      reply	other threads:[~2026-11-19 11:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 11:43 [PATCH v6 0/5] arm64: dts: qcom: Add EL2 overlays for Shikra and SM8750 Komal Bajaj
2026-11-19 11:43 ` [PATCH v6 1/5] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings Komal Bajaj
2026-11-19 11:43 ` [PATCH v6 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints Komal Bajaj
2026-11-19 11:43 ` [PATCH v6 3/5] dt-bindings: remoteproc: qcom,sm8550-pas: Allow 6 iommus for SM8750 ADSP Komal Bajaj
2026-11-19 11:43 ` [PATCH v6 4/5] arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings Komal Bajaj
2026-11-19 11:57   ` sashiko-bot
2026-11-19 11:43 ` [PATCH v6 5/5] arm64: dts: qcom: sm8750: " Komal Bajaj
2026-11-19 11:51   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223064@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=komal.bajaj@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox