From: sashiko-bot@kernel.org
To: "Komal Bajaj" <komal.bajaj@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v6 4/5] arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings
Date: Thu, 19 Nov 2026 11:57:09 +0000 [thread overview]
Message-ID: <sashiko-outbox-223069@kernel.org> (raw)
In-Reply-To: <20261119-shikra-el2-v6-4-0e91a1467e79@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: shikra-el2: q6apmdai iommus fails
q6apm_dai_probe()
--
commit 0d5069de0241cf74b87f4a2a71c79f4b11c8da67
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings
This commit adds an EL2 DeviceTree overlay for Shikra boards to describe
IOMMU stream mappings for remoteproc firmware and applies it to the Shikra
EVK DTB targets.
> diff --git a/arch/arm64/boot/dts/qcom/shikra-el2.dtso b/arch/arm64/boot/dts/qcom/shikra-el2.dtso
> new file mode 100644
> index 0000000000000..89997ed7699ee
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-el2.dtso
> @@ -0,0 +1,38 @@
[ ... ]
> +&q6apmdai {
> + /delete-property/ memory-region;
> + iommus = <&apps_smmu 0x01cc 0x3>;
> +};
[Severity: High]
Does adding iommus to q6apmdai cause q6apm_dai_probe() to fail with
-EINVAL on Shikra EL2 builds?
In arch/arm64/boot/dts/qcom/shikra.dtsi, the ancestor gpr node sets
qcom,domain = <GPR_DOMAIN_ID_MODEM>, and q6apm_dai_probe() rejects any
iommus property when the GPR domain is GPR_DOMAIN_ID_MODEM:
sound/soc/qcom/qdsp6/q6apm-dai.c:q6apm_dai_probe() {
...
if (apm && apm->gdev &&
apm->gdev->domain_id == GPR_DOMAIN_ID_MODEM) {
if (!qcom_scm_is_available())
return -EPROBE_DEFER;
if (pdata->sid >= 0) {
dev_err(dev,
"iommus and mDSP SCM path are mutually exclusive\n");
return -EINVAL;
}
...
}
Because iommus sets pdata->sid to 0xc, the Q6APM front-end DAI driver will
fail to probe and audio will not register in EL2.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-shikra-el2-v6-0-0e91a1467e79@oss.qualcomm.com?part=4
next prev parent reply other threads:[~2026-11-19 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 11:43 [PATCH v6 0/5] arm64: dts: qcom: Add EL2 overlays for Shikra and SM8750 Komal Bajaj
2026-11-19 11:43 ` [PATCH v6 1/5] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings Komal Bajaj
2026-11-19 11:43 ` [PATCH v6 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints Komal Bajaj
2026-11-19 11:43 ` [PATCH v6 3/5] dt-bindings: remoteproc: qcom,sm8550-pas: Allow 6 iommus for SM8750 ADSP Komal Bajaj
2026-11-19 11:43 ` [PATCH v6 4/5] arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings Komal Bajaj
2026-11-19 11:57 ` sashiko-bot [this message]
2026-11-19 11:43 ` [PATCH v6 5/5] arm64: dts: qcom: sm8750: " Komal Bajaj
2026-11-19 11:51 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223069@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=komal.bajaj@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox