Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Louis-Alexis Eyraud" <louisalexis.eyraud@collabora.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-scsi@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v15 16/23] scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths
Date: Thu, 19 Nov 2026 15:19:48 +0000	[thread overview]
Message-ID: <sashiko-outbox-223364@kernel.org> (raw)
In-Reply-To: <20261119-mt8196-ufs-v15-16-aae1eb0382e8@collabora.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] scsi: ufs: mediatek: missing Fixes trailer for
  _ufs_mtk_clk_scale() fixes
--

commit 4421ac01b44e9c03d7a805d55558f0e6f608a409
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

> scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths
>
> Errors should be printed at the correct log level. Additionally, it
> looks like some "goto out"'s were omitted in the scale up case, which
> looks like a mistake, as the scale down branch of the code does use
> them.
>
> Rework the error messages to make them nicer and at the correct
> verbosity, and add the missing gotos.
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Peter Wang <peter.wang@mediatek.com>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

[Severity: Low]
In addition to the missing goto out when clk_set_parent(clki->clk, ...)
fails during scale-up, this patch fixes a clki->clk prepare/enable leak
when clk_prepare_enable(fde_clki->clk) fails.  Both issues were introduced
by 5e5976f5242d ("scsi: ufs: host: mediatek: Support FDE (AES) clock
scaling").  Should this include:

  Fixes: 5e5976f5242d ("scsi: ufs: host: mediatek: Support FDE (AES) clock scaling")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-mt8196-ufs-v15-0-aae1eb0382e8@collabora.com?part=16

  reply	other threads:[~2026-11-19 15:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:05 [PATCH v15 00/23] MediaTek UFS Cleanup and MT8196 Enablement Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 01/23] dt-bindings: phy: Add mediatek,mt8196-ufsphy variant Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 02/23] dt-bindings: ufs: mediatek,ufs: Complete the binding Louis-Alexis Eyraud
2026-11-19 15:25   ` sashiko-bot
2026-11-19 15:05 ` [PATCH v15 03/23] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 04/23] scsi: ufs: mediatek: Move MTK_SIP_UFS_CONTROL to mtk_sip_svc.h Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 05/23] phy: mediatek: ufs: Add support for resets Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 06/23] scsi: ufs: mediatek: Rework resets Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 07/23] scsi: ufs: mediatek: Rework 0.9V regulator Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 08/23] scsi: ufs: mediatek: Add dual 0.9V supply support Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 09/23] scsi: ufs: mediatek: Rework init function Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 10/23] scsi: ufs: mediatek: Rework the crypt-boost stuff Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 11/23] scsi: ufs: mediatek: Handle misc host voltage regulators Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 12/23] scsi: ufs: mediatek: Remove undocumented downstream reset cruft Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 13/23] scsi: ufs: mediatek: Remove vendor kernel quirks cruft Louis-Alexis Eyraud
2026-11-19 15:17   ` sashiko-bot
2026-11-19 15:06 ` [PATCH v15 14/23] scsi: ufs: mediatek: Use the common PHY framework Louis-Alexis Eyraud
2026-11-19 15:26   ` sashiko-bot
2026-11-19 15:06 ` [PATCH v15 15/23] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 16/23] scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths Louis-Alexis Eyraud
2026-11-19 15:19   ` sashiko-bot [this message]
2026-11-19 15:06 ` [PATCH v15 17/23] scsi: ufs: mediatek: Clean up logging prints Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 18/23] scsi: ufs: mediatek: Rework ufs_mtk_wait_idle_state Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 19/23] scsi: ufs: mediatek: Don't acquire dvfsrc-vcore twice Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 20/23] scsi: ufs: mediatek: Rework hardware version reading Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 21/23] scsi: ufs: mediatek: Remove ret local from link_startup_notify Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 22/23] scsi: ufs: mediatek: Remove undocumented "clk-scale-up-vcore-min" Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 23/23] scsi: ufs: mediatek: Add MT8196 compatible, update copyright Louis-Alexis Eyraud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223364@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=louisalexis.eyraud@collabora.com \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox