From: sashiko-bot@kernel.org
To: "Louis-Alexis Eyraud" <louisalexis.eyraud@collabora.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-scsi@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v15 02/23] dt-bindings: ufs: mediatek,ufs: Complete the binding
Date: Thu, 19 Nov 2026 15:25:30 +0000 [thread overview]
Message-ID: <sashiko-outbox-223380@kernel.org> (raw)
In-Reply-To: <20261119-mt8196-ufs-v15-2-aae1eb0382e8@collabora.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: ufs: mediatek: incompatible schema breaks
in-tree mt8195.dtsi
--
commit 897f6726f17b6227ef961cfcc71c9c313c14a3df
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
dt-bindings: ufs: mediatek,ufs: Complete the binding
This commit updates the MediaTek UFS devicetree binding schema to add
resets, controller power supplies, operating-points-v2, and updated
per-SoC clock definitions while disallowing freq-table-hz.
> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> index 15c347f5e6604..945cb986b06b7 100644
> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> @@ -19,11 +19,25 @@ properties:
>
> clocks:
> minItems: 1
> - maxItems: 8
> + maxItems: 10
>
> clock-names:
> minItems: 1
> - maxItems: 8
> + items:
> + - const: main
> + - const: aes
> + - const: tick
> + - const: unipro_sysclk
> + - const: unipro_tick
> + - const: unipro_mp_bclk
> + - const: tx_symbol
> + - const: mem_sub
> + - const: rx_symbol0
> + - const: rx_symbol1
> +
> + operating-points-v2: true
> +
> + freq-table-hz: false
[ ... ]
> @@ -54,29 +96,41 @@ allOf:
> properties:
> compatible:
> contains:
> - enum:
> - - mediatek,mt8195-ufshci
> + const: mediatek,mt8183-ufshci
> then:
> properties:
> clocks:
> - minItems: 8
> + maxItems: 1
> clock-names:
> items:
> - - const: ufs
> - - const: ufs_aes
> - - const: ufs_tick
> - - const: unipro_sysclk
> - - const: unipro_tick
> - - const: unipro_mp_bclk
> - - const: ufs_tx_symbol
> - - const: ufs_mem_sub
> - else:
> + - const: main
> + avdd12-ckbuf-supply: false
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8192-ufshci
> + then:
> properties:
> clocks:
> - maxItems: 1
> + minItems: 3
> + maxItems: 3
> clock-names:
> - items:
> - - const: ufs
> + minItems: 3
> + maxItems: 3
> + avdd09-supply: false
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8195-ufshci
> + then:
> + properties:
> + clocks:
> + minItems: 10
> + clock-names:
> + minItems: 10
> + avdd09-supply: false
[Severity: Medium]
Does renaming clock-names, setting freq-table-hz: false, and requiring 10
clocks for mediatek,mt8195-ufshci break DT ABI compatibility and
dtbs_check for the existing in-tree ufshci@11270000 node in
arch/arm64/boot/dts/mediatek/mt8195.dtsi?
Contrary to the commit message, mediatek,mt8195-ufshci is already used in
mainline (and enabled by mt8395-genio-1200-evk-ufs.dts and
mt8395-radxa-nio-12l.dts) with the 8 previously documented clock names and
freq-table-hz:
arch/arm64/boot/dts/mediatek/mt8195.dtsi {
...
ufshci: ufshci@11270000 {
compatible = "mediatek,mt8195-ufshci";
...
clock-names = "ufs", "ufs_aes", "ufs_tick",
"unipro_sysclk", "unipro_tick",
"unipro_mp_bclk", "ufs_tx_symbol",
"ufs_mem_sub";
freq-table-hz = <0 0>, <0 0>, <0 0>,
<0 0>, <0 0>, <0 0>,
<0 0>, <0 0>;
...
}
Because those changes are not backwards-compatible with the existing DTS,
running make dtbs_check fails on the MT8195 and MT8395 boards.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-mt8196-ufs-v15-0-aae1eb0382e8@collabora.com?part=2
next prev parent reply other threads:[~2026-11-19 15:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 15:05 [PATCH v15 00/23] MediaTek UFS Cleanup and MT8196 Enablement Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 01/23] dt-bindings: phy: Add mediatek,mt8196-ufsphy variant Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 02/23] dt-bindings: ufs: mediatek,ufs: Complete the binding Louis-Alexis Eyraud
2026-11-19 15:25 ` sashiko-bot [this message]
2026-11-19 15:05 ` [PATCH v15 03/23] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 04/23] scsi: ufs: mediatek: Move MTK_SIP_UFS_CONTROL to mtk_sip_svc.h Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 05/23] phy: mediatek: ufs: Add support for resets Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 06/23] scsi: ufs: mediatek: Rework resets Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 07/23] scsi: ufs: mediatek: Rework 0.9V regulator Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 08/23] scsi: ufs: mediatek: Add dual 0.9V supply support Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 09/23] scsi: ufs: mediatek: Rework init function Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 10/23] scsi: ufs: mediatek: Rework the crypt-boost stuff Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 11/23] scsi: ufs: mediatek: Handle misc host voltage regulators Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 12/23] scsi: ufs: mediatek: Remove undocumented downstream reset cruft Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 13/23] scsi: ufs: mediatek: Remove vendor kernel quirks cruft Louis-Alexis Eyraud
2026-11-19 15:17 ` sashiko-bot
2026-11-19 15:06 ` [PATCH v15 14/23] scsi: ufs: mediatek: Use the common PHY framework Louis-Alexis Eyraud
2026-11-19 15:26 ` sashiko-bot
2026-11-19 15:06 ` [PATCH v15 15/23] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 16/23] scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths Louis-Alexis Eyraud
2026-11-19 15:19 ` sashiko-bot
2026-11-19 15:06 ` [PATCH v15 17/23] scsi: ufs: mediatek: Clean up logging prints Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 18/23] scsi: ufs: mediatek: Rework ufs_mtk_wait_idle_state Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 19/23] scsi: ufs: mediatek: Don't acquire dvfsrc-vcore twice Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 20/23] scsi: ufs: mediatek: Rework hardware version reading Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 21/23] scsi: ufs: mediatek: Remove ret local from link_startup_notify Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 22/23] scsi: ufs: mediatek: Remove undocumented "clk-scale-up-vcore-min" Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 23/23] scsi: ufs: mediatek: Add MT8196 compatible, update copyright Louis-Alexis Eyraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223380@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox