Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Dipa Ramesh Mantre" <dipa.mantre@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: shikra: Enable CDSP & Modem cooling
Date: Thu, 19 Nov 2026 16:33:49 +0000	[thread overview]
Message-ID: <sashiko-outbox-223530@kernel.org> (raw)
In-Reply-To: <20261119-b4-shikra_qmi_tmd-v2-1-87089ab2acbe@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: qcom: shikra: missing qcom,pas.h header and
  QCOM_TMD_* macros
- [Low] arm64: dts: qcom: shikra: undocumented #cooling-cells on PAS
  remoteproc nodes
--

commit 8571cc2f99e428cc1ffc7db9c0a71c46f4f27ba0
Author: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>

arm64: dts: qcom: shikra: Enable CDSP & Modem cooling

This commit configures passive thermal trip points and QMI TMD cooling maps
for the CDSP and modem remoteproc nodes on Qualcomm Shikra.

Link: https://lore.kernel.org/r/20260911-shikra_qmi_tmd-v1-2-96c1cca82f30@oss.qualcomm.com

> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index c1f06f692f664..6e5b1aa376692 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -10,6 +10,7 @@
>  #include <dt-bindings/interconnect/qcom,icc.h>
>  #include <dt-bindings/interconnect/qcom,osm-l3.h>
>  #include <dt-bindings/dma/qcom-gpi.h>
> +#include <dt-bindings/thermal/qcom,pas.h>
>  #include <dt-bindings/interconnect/qcom,rpm-icc.h>
>  #include <dt-bindings/interconnect/qcom,shikra.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>

[Severity: Low]
Does this break DTB compilation for Shikra?  include/dt-bindings/thermal/qcom,pas.h
does not exist in the tree, and QCOM_TMD_CDSP_SW, QCOM_TMD_PA, and
QCOM_TMD_MODEM used in the cooling-maps below are undefined.

> @@ -2007,6 +2008,8 @@ remoteproc_mpss: remoteproc@6080000 {
>  			qcom,smem-states = <&modem_smp2p_out 0>;
>  			qcom,smem-state-names = "stop";
>  
> +			#cooling-cells = <3>;
> +
>  			status = "disabled";
>  
>  			glink-edge {
> @@ -2047,6 +2050,8 @@ remoteproc_cdsp: remoteproc@b300000 {
>  			qcom,smem-states = <&cdsp_smp2p_out 0>;
>  			qcom,smem-state-names = "stop";
>  
> +			#cooling-cells = <3>;

[Severity: Low]
Does adding #cooling-cells to remoteproc_mpss and remoteproc_cdsp fail
dtbs_check?  Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
and Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml do not
define #cooling-cells and set unevaluatedProperties: false.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-b4-shikra_qmi_tmd-v2-1-87089ab2acbe@oss.qualcomm.com?part=1

      reply	other threads:[~2026-11-19 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 16:23 [PATCH v2] arm64: dts: qcom: shikra: Enable CDSP & Modem cooling Dipa Ramesh Mantre
2026-11-19 16:33 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223530@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dipa.mantre@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox