* [PATCH v2] arm64: dts: qcom: shikra: Enable CDSP & Modem cooling
@ 2026-11-19 16:23 Dipa Ramesh Mantre
2026-11-19 16:33 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Dipa Ramesh Mantre @ 2026-11-19 16:23 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
gaurav.kohli, Dipa Ramesh Mantre, Abel Vesa
Unlike the CPU, the CDSP/Modem does not throttle its speed automatically
when it reaches high temperatures in shikra.
Set up CDSP/Modem cooling by throttling the CDSP and modem when they
reach 115°C using the QMI TMD cooling device framework.
Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260911-shikra_qmi_tmd-v1-2-96c1cca82f30@oss.qualcomm.com
---
Changes in v2:
- Fix indentation of cooling-device arguments in cooling-maps node
- Link to v1: https://lore.kernel.org/r/20260911-shikra_qmi_tmd-v1-2-96c1cca82f30@oss.qualcomm.com
---
arch/arm64/boot/dts/qcom/shikra.dtsi | 71 ++++++++++++++++++++++++++++++++++--
1 file changed, 68 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
index c1f06f692f66..6e5b1aa37669 100644
--- a/arch/arm64/boot/dts/qcom/shikra.dtsi
+++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
@@ -10,6 +10,7 @@
#include <dt-bindings/interconnect/qcom,icc.h>
#include <dt-bindings/interconnect/qcom,osm-l3.h>
#include <dt-bindings/dma/qcom-gpi.h>
+#include <dt-bindings/thermal/qcom,pas.h>
#include <dt-bindings/interconnect/qcom,rpm-icc.h>
#include <dt-bindings/interconnect/qcom,shikra.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
@@ -2007,6 +2008,8 @@ remoteproc_mpss: remoteproc@6080000 {
qcom,smem-states = <&modem_smp2p_out 0>;
qcom,smem-state-names = "stop";
+ #cooling-cells = <3>;
+
status = "disabled";
glink-edge {
@@ -2047,6 +2050,8 @@ remoteproc_cdsp: remoteproc@b300000 {
qcom,smem-states = <&cdsp_smp2p_out 0>;
qcom,smem-state-names = "stop";
+ #cooling-cells = <3>;
+
status = "disabled";
glink-edge {
@@ -3868,6 +3873,8 @@ map0 {
};
nsp-thermal {
+ polling-delay-passive = <200>;
+
thermal-sensors = <&tsens0 7>;
trips {
@@ -3877,15 +3884,31 @@ trip-point0 {
type = "hot";
};
- nsp-critical {
+ nsp_alert1: nsp-alert1 {
temperature = <115000>;
+ hysteresis = <5000>;
+ type = "passive";
+ };
+
+ nsp-critical {
+ temperature = <118000>;
hysteresis = <0>;
type = "critical";
};
};
+
+ cooling-maps {
+ map0 {
+ trip = <&nsp_alert1>;
+ cooling-device = <&remoteproc_cdsp QCOM_TMD_CDSP_SW
+ THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+ };
};
mdmss0-thermal {
+ polling-delay-passive = <200>;
+
thermal-sensors = <&tsens0 8>;
trips {
@@ -3895,15 +3918,37 @@ trip-point0 {
type = "hot";
};
- mdmss0-critical {
+ mdmss0_alert1: mdmss0-alert1 {
temperature = <115000>;
+ hysteresis = <5000>;
+ type = "passive";
+ };
+
+ mdmss0-critical {
+ temperature = <118000>;
hysteresis = <0>;
type = "critical";
};
};
+
+ cooling-maps {
+ map0 {
+ trip = <&mdmss0_alert1>;
+ cooling-device = <&remoteproc_mpss QCOM_TMD_PA
+ THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+
+ map1 {
+ trip = <&mdmss0_alert1>;
+ cooling-device = <&remoteproc_mpss QCOM_TMD_MODEM
+ THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+ };
};
mdmss1-thermal {
+ polling-delay-passive = <200>;
+
thermal-sensors = <&tsens0 9>;
trips {
@@ -3913,12 +3958,32 @@ trip-point0 {
type = "hot";
};
- mdmss1-critical {
+ mdmss1_alert1: mdmss1-alert1 {
temperature = <115000>;
+ hysteresis = <5000>;
+ type = "passive";
+ };
+
+ mdmss1-critical {
+ temperature = <118000>;
hysteresis = <0>;
type = "critical";
};
};
+
+ cooling-maps {
+ map0 {
+ trip = <&mdmss1_alert1>;
+ cooling-device = <&remoteproc_mpss QCOM_TMD_PA
+ THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+
+ map1 {
+ trip = <&mdmss1_alert1>;
+ cooling-device = <&remoteproc_mpss QCOM_TMD_MODEM
+ THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+ };
};
camera-thermal {
---
base-commit: 944a035ecca915ae947905dcfb03f2b9dc6d032c
change-id: 20261119-b4-shikra_qmi_tmd-c96712a52bad
Best regards,
--
Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: shikra: Enable CDSP & Modem cooling
2026-11-19 16:23 [PATCH v2] arm64: dts: qcom: shikra: Enable CDSP & Modem cooling Dipa Ramesh Mantre
@ 2026-11-19 16:33 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-19 16:33 UTC (permalink / raw)
To: Dipa Ramesh Mantre; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: qcom: shikra: missing qcom,pas.h header and
QCOM_TMD_* macros
- [Low] arm64: dts: qcom: shikra: undocumented #cooling-cells on PAS
remoteproc nodes
--
commit 8571cc2f99e428cc1ffc7db9c0a71c46f4f27ba0
Author: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
arm64: dts: qcom: shikra: Enable CDSP & Modem cooling
This commit configures passive thermal trip points and QMI TMD cooling maps
for the CDSP and modem remoteproc nodes on Qualcomm Shikra.
Link: https://lore.kernel.org/r/20260911-shikra_qmi_tmd-v1-2-96c1cca82f30@oss.qualcomm.com
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index c1f06f692f664..6e5b1aa376692 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -10,6 +10,7 @@
> #include <dt-bindings/interconnect/qcom,icc.h>
> #include <dt-bindings/interconnect/qcom,osm-l3.h>
> #include <dt-bindings/dma/qcom-gpi.h>
> +#include <dt-bindings/thermal/qcom,pas.h>
> #include <dt-bindings/interconnect/qcom,rpm-icc.h>
> #include <dt-bindings/interconnect/qcom,shikra.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
[Severity: Low]
Does this break DTB compilation for Shikra? include/dt-bindings/thermal/qcom,pas.h
does not exist in the tree, and QCOM_TMD_CDSP_SW, QCOM_TMD_PA, and
QCOM_TMD_MODEM used in the cooling-maps below are undefined.
> @@ -2007,6 +2008,8 @@ remoteproc_mpss: remoteproc@6080000 {
> qcom,smem-states = <&modem_smp2p_out 0>;
> qcom,smem-state-names = "stop";
>
> + #cooling-cells = <3>;
> +
> status = "disabled";
>
> glink-edge {
> @@ -2047,6 +2050,8 @@ remoteproc_cdsp: remoteproc@b300000 {
> qcom,smem-states = <&cdsp_smp2p_out 0>;
> qcom,smem-state-names = "stop";
>
> + #cooling-cells = <3>;
[Severity: Low]
Does adding #cooling-cells to remoteproc_mpss and remoteproc_cdsp fail
dtbs_check? Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
and Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml do not
define #cooling-cells and set unevaluatedProperties: false.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-b4-shikra_qmi_tmd-v2-1-87089ab2acbe@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-19 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 16:23 [PATCH v2] arm64: dts: qcom: shikra: Enable CDSP & Modem cooling Dipa Ramesh Mantre
2026-11-19 16:33 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox