Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Enzo Adriano" <enzo.adriano.code@gmail.com>
Cc: devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 2/3] arm64: dts: allwinner: add A733 SoC description
Date: Thu, 19 Nov 2026 18:30:30 +0000	[thread overview]
Message-ID: <sashiko-outbox-223770@kernel.org> (raw)
In-Reply-To: <dbfb7c5ea8b0ade2d48ef8e5cfd0b9e5a9946483.1795034153.git.enzo.adriano.code@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] arm64: dts: allwinner: pio node lists 10 interrupts instead of
  11 on A733
- [Low] arm64: dts: allwinner: undocumented allwinner,sun60i-a733-uart
  compatible
--

commit b822d1469c44857fd000cc1a89105a359018f41b
Author: Enzo Adriano <enzo.adriano.code@gmail.com>

arm64: dts: allwinner: add A733 SoC description

This commit adds the base Devicetree description for the Allwinner A733
SoC, covering CPUs, GIC, timers, clocks, pin controllers, UART, I2C, and
MMC controllers.

Link: https://gist.githubusercontent.com/apritzel/60fd7379b9560a15b8b352986b69d39f/raw/efd9cdf8f26ba5b0c7e138f093af44a1cf322469/sun60i-a733.dts

> diff --git a/arch/arm64/boot/dts/allwinner/sun60i-a733.dtsi b/arch/arm64/boot/dts/allwinner/sun60i-a733.dtsi
> new file mode 100644
> index 0000000000000..b0f642f37803a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun60i-a733.dtsi
> @@ -0,0 +1,657 @@

[ ... ]

> +		pio: pinctrl@2000000 {
> +			compatible = "allwinner,sun60i-a733-pinctrl";
> +			reg = <0x02000000 0x800>;
> +			interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH 0>;

[Severity: High]
Does omitting Port A's interrupt (<GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH 0>) at
index 0 shift all main-domain GPIO bank interrupts off by one?

The binding in Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml
requires 11 interrupts for allwinner,sun60i-a733-pinctrl.  In the driver,
Port A occupies bank 0 with 0 pins, so prepare_function_table() assigns
irqbank 1 through 10 to Ports B through K, and sunxi_irq_base_reg()
indexes the per-bank IRQ registers from Port A at bank 0:

drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c:prepare_function_table() {
    ...
		if (irq_mux) {
			if (bank > last_bank)
				irq_bank++;
			func[lastfunc].muxval = irq_mux;
			func[lastfunc].irqbank = irq_bank;
    ...
}

With only 10 interrupts starting at Port B (GIC_SPI 69), pctl->irq[0..9]
are registered one bank off from the hardware registers.  When any GPIO
interrupt on Ports B through K fires, sunxi_pinctrl_irq_handler() reads
and clears the preceding bank's status register, leaving the interrupt
asserted.

[ ... ]

> +		uart0: serial@2500000 {
> +			compatible = "allwinner,sun60i-a733-uart",
> +				     "snps,dw-apb-uart";

[Severity: Low]
Is "allwinner,sun60i-a733-uart" documented in
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml?

Neither that schema nor this series defines "allwinner,sun60i-a733-uart",
so dtbs_check will fail on uart0 through uart6 and r_uart0 through
r_uart1.  Other Allwinner arm64 SoCs use "snps,dw-apb-uart" alone unless
the SoC-specific compatible is added to the binding.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795034153.git.enzo.adriano.code@gmail.com?part=2

  reply	other threads:[~2026-11-19 18:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 18:09 [PATCH v4 0/3] arm64: dts: allwinner: add A733/Cubie A7S support Enzo Adriano
2026-11-19 18:09 ` [PATCH v4 1/3] dt-bindings: arm: sunxi: document Radxa Cubie A7S Enzo Adriano
2026-11-19 18:09 ` [PATCH v4 2/3] arm64: dts: allwinner: add A733 SoC description Enzo Adriano
2026-11-19 18:30   ` sashiko-bot [this message]
2026-11-19 18:09 ` [PATCH v4 3/3] arm64: dts: allwinner: add Radxa Cubie A7S board Enzo Adriano
2026-11-19 18:26   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223770@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=enzo.adriano.code@gmail.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox