Devicetree
 help / color / mirror / Atom feed
* [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5
@ 2026-11-20 10:48 Alexey Charkov
  2026-11-20 10:48 ` [PATCH 1/7] arm64: dts: rockchip: Describe NanoPi M5 Ethernet PHYs by their ID Alexey Charkov
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Alexey Charkov @ 2026-11-20 10:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	John Clark, Detlev Casanova
  Cc: devicetree, linux-arm-kernel, linux-rockchip, Alexey Charkov

Both ArmSoM Sige5 and NanoPi M5 boards use the same Realtek RGMII PHYs
which currently share an issue preventing them from enumeration unless an
earlier boot stage left them out of reset: at power-on, their reset lines
are asserted, so they cannot answer an MDIO probe. Until they answer, the
OS cannot look up the ID to match a driver. And until the OS has a driver,
nothing releases their reset line.

Fix this by using their known PHY IDs instead of the generic compatible,
so that the deadlock is broken. This also opens up the possibility to
enable the Realtek-specific ALDPS feature (automatic link-down power
saving), which saves around 400 mW for each PHY with no cable attached.

While here, also do a couple of minor cleanups: NanoPi M5 uses a dedicated
crystal to derive the 25MHz reference clock, so it doesn't use the SoC
provided clock, and the current DT property is superfluous and misleading.
RTL8211F datasheet also specifies much shorter reset assertion and
deassertion times than currently used in the DT, so adjust those, too, to
avoid wasting unnecessary time during the reset sequence.

Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
Alexey Charkov (7):
      arm64: dts: rockchip: Describe NanoPi M5 Ethernet PHYs by their ID
      arm64: dts: rockchip: Describe Sige5 Ethernet PHYs by their ID
      arm64: dts: rockchip: Drop NanoPi M5 PHY reference clocks
      arm64: dts: rockchip: Enable ALDPS on NanoPi M5 Ethernet PHYs
      arm64: dts: rockchip: Enable ALDPS on Sige5 Ethernet PHYs
      arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing
      arm64: dts: rockchip: Shorten Sige5 Ethernet PHY reset to datasheet timing

 arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 18 ++++++++++--------
 arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts    | 20 ++++++++++----------
 2 files changed, 20 insertions(+), 18 deletions(-)
---
base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
change-id: 20261120-rk3576-phys-277680a877d7

Best regards,
--  
Alexey Charkov <alchark@flipper.net>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/7] arm64: dts: rockchip: Describe NanoPi M5 Ethernet PHYs by their ID
  2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
@ 2026-11-20 10:48 ` Alexey Charkov
  2026-11-20 10:48 ` [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 " Alexey Charkov
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Alexey Charkov @ 2026-11-20 10:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	John Clark, Detlev Casanova
  Cc: devicetree, linux-arm-kernel, linux-rockchip, Alexey Charkov

Both NanoPi M5 GMACs connect to an RTL8211F PHY with its reset line in
the PHY node. With only the generic C22 compatible, an OS has to read the
PHY ID registers before it can bind a driver, and only that driver
releases the reset line. Unless an earlier boot stage has already
released it, the PHY stays in reset, never answers on MDIO, and neither
Ethernet port comes up. Booting straight from U-Boot SPL in Falcon mode
hits exactly that.

Name the PHY by its ID, so it binds without the ID read and comes out of
reset as it does. Name the node ethernet-phy@1 as well, as the Realtek
PHY binding the ID compatible selects requires.

Fixes: 96cbdfdd3ac2 ("arm64: dts: rockchip: Add FriendlyElec NanoPi M5 support")
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
index c84afecd6e2a..49bbef5730d2 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
@@ -802,8 +802,8 @@ rt5616: audio-codec@1b {
 };
 
 &mdio0 {
-	rgmii_phy0: phy@1 {
-		compatible = "ethernet-phy-ieee802.3-c22";
+	rgmii_phy0: ethernet-phy@1 {
+		compatible = "ethernet-phy-id001c.c916";
 		reg = <0x1>;
 		clocks = <&cru REFCLKO25M_GMAC0_OUT>;
 		interrupt-parent = <&gpio2>;
@@ -817,8 +817,8 @@ rgmii_phy0: phy@1 {
 };
 
 &mdio1 {
-	rgmii_phy1: phy@1 {
-		compatible = "ethernet-phy-ieee802.3-c22";
+	rgmii_phy1: ethernet-phy@1 {
+		compatible = "ethernet-phy-id001c.c916";
 		reg = <0x1>;
 		clocks = <&cru REFCLKO25M_GMAC1_OUT>;
 		interrupt-parent = <&gpio3>;

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 Ethernet PHYs by their ID
  2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
  2026-11-20 10:48 ` [PATCH 1/7] arm64: dts: rockchip: Describe NanoPi M5 Ethernet PHYs by their ID Alexey Charkov
@ 2026-11-20 10:48 ` Alexey Charkov
  2026-11-20 10:56   ` sashiko-bot
  2026-11-20 10:48 ` [PATCH 3/7] arm64: dts: rockchip: Drop NanoPi M5 PHY reference clocks Alexey Charkov
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 10+ messages in thread
From: Alexey Charkov @ 2026-11-20 10:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	John Clark, Detlev Casanova
  Cc: devicetree, linux-arm-kernel, linux-rockchip, Alexey Charkov

Both Sige5 GMACs connect to an RTL8211F PHY (ID 0x001cc916) with its
reset line in the PHY node. With only the generic C22 compatible, an OS
has to read the PHY ID registers before it can bind a driver, and only
that driver releases the reset line. Unless an earlier boot stage has
already released it, the PHY stays in reset, never answers on MDIO, and
neither Ethernet port comes up. Booting straight from U-Boot SPL in
Falcon mode hits exactly that.

Name the PHY by its ID, so it binds without the ID read and comes out of
reset as it does. Name the node ethernet-phy@1 as well, as the Realtek
PHY binding the ID compatible selects requires.

Fixes: 40f742b07ab2 ("arm64: dts: rockchip: Add rk3576-armsom-sige5 board")
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index c5b2f22402f5..b8547395c608 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -775,8 +775,8 @@ es8388: audio-codec@10 {
 };
 
 &mdio0 {
-	rgmii_phy0: phy@1 {
-		compatible = "ethernet-phy-ieee802.3-c22";
+	rgmii_phy0: ethernet-phy@1 {
+		compatible = "ethernet-phy-id001c.c916";
 		reg = <0x1>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&gmac0_rst>;
@@ -787,8 +787,8 @@ rgmii_phy0: phy@1 {
 };
 
 &mdio1 {
-	rgmii_phy1: phy@1 {
-		compatible = "ethernet-phy-ieee802.3-c22";
+	rgmii_phy1: ethernet-phy@1 {
+		compatible = "ethernet-phy-id001c.c916";
 		reg = <0x1>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&gmac1_rst>;

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/7] arm64: dts: rockchip: Drop NanoPi M5 PHY reference clocks
  2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
  2026-11-20 10:48 ` [PATCH 1/7] arm64: dts: rockchip: Describe NanoPi M5 Ethernet PHYs by their ID Alexey Charkov
  2026-11-20 10:48 ` [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 " Alexey Charkov
@ 2026-11-20 10:48 ` Alexey Charkov
  2026-11-20 10:48 ` [PATCH 4/7] arm64: dts: rockchip: Enable ALDPS on NanoPi M5 Ethernet PHYs Alexey Charkov
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Alexey Charkov @ 2026-11-20 10:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	John Clark, Detlev Casanova
  Cc: devicetree, linux-arm-kernel, linux-rockchip, Alexey Charkov

Each NanoPi M5 RTL8211F runs from its own 25MHz crystal (X12, X13), and
the SoC's REFCLKO25M outputs reach neither PHY. Remove the clocks the
PHY nodes claim from the SoC, so nothing enables an output that drives
no PHY.

Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
index 49bbef5730d2..778cb8181639 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
@@ -805,7 +805,6 @@ &mdio0 {
 	rgmii_phy0: ethernet-phy@1 {
 		compatible = "ethernet-phy-id001c.c916";
 		reg = <0x1>;
-		clocks = <&cru REFCLKO25M_GMAC0_OUT>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
 		pinctrl-names = "default";
@@ -820,7 +819,6 @@ &mdio1 {
 	rgmii_phy1: ethernet-phy@1 {
 		compatible = "ethernet-phy-id001c.c916";
 		reg = <0x1>;
-		clocks = <&cru REFCLKO25M_GMAC1_OUT>;
 		interrupt-parent = <&gpio3>;
 		interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
 		pinctrl-names = "default";

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/7] arm64: dts: rockchip: Enable ALDPS on NanoPi M5 Ethernet PHYs
  2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
                   ` (2 preceding siblings ...)
  2026-11-20 10:48 ` [PATCH 3/7] arm64: dts: rockchip: Drop NanoPi M5 PHY reference clocks Alexey Charkov
@ 2026-11-20 10:48 ` Alexey Charkov
  2026-11-20 10:48 ` [PATCH 5/7] arm64: dts: rockchip: Enable ALDPS on Sige5 " Alexey Charkov
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Alexey Charkov @ 2026-11-20 10:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	John Clark, Detlev Casanova
  Cc: devicetree, linux-arm-kernel, linux-rockchip, Alexey Charkov

Let the RTL8211F PHYs power down while no link partner is present
(Advanced Link Down Power Saving), which a PHY leaves disabled after
reset. Both PHYs are also strapped to stop their PLL in that state
(PLLOFF), so an unplugged port draws close to nothing.

Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
index 778cb8181639..638e00b6e165 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
@@ -812,6 +812,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		realtek,aldps-enable;
 	};
 };
 
@@ -826,6 +827,7 @@ rgmii_phy1: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>;
+		realtek,aldps-enable;
 	};
 };
 

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 5/7] arm64: dts: rockchip: Enable ALDPS on Sige5 Ethernet PHYs
  2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
                   ` (3 preceding siblings ...)
  2026-11-20 10:48 ` [PATCH 4/7] arm64: dts: rockchip: Enable ALDPS on NanoPi M5 Ethernet PHYs Alexey Charkov
@ 2026-11-20 10:48 ` Alexey Charkov
  2026-11-20 10:48 ` [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing Alexey Charkov
  2026-11-20 10:48 ` [PATCH 7/7] arm64: dts: rockchip: Shorten Sige5 " Alexey Charkov
  6 siblings, 0 replies; 10+ messages in thread
From: Alexey Charkov @ 2026-11-20 10:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	John Clark, Detlev Casanova
  Cc: devicetree, linux-arm-kernel, linux-rockchip, Alexey Charkov

Let the RTL8211F PHYs power down while no link partner is present
(Advanced Link Down Power Saving), which a PHY leaves disabled after
reset. The PHY on GMAC0 is also strapped to stop its PLL in that state
(PLLOFF pulled up through R338), so an unplugged port draws close to
nothing; the one on GMAC1 leaves the strap open (R368 and R369 not
fitted) and keeps its PLL running, but still saves the rest.

Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index b8547395c608..45a4489863bf 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -783,6 +783,7 @@ rgmii_phy0: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
+		realtek,aldps-enable;
 	};
 };
 
@@ -795,6 +796,7 @@ rgmii_phy1: ethernet-phy@1 {
 		reset-assert-us = <20000>;
 		reset-deassert-us = <100000>;
 		reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>;
+		realtek,aldps-enable;
 	};
 };
 

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing
  2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
                   ` (4 preceding siblings ...)
  2026-11-20 10:48 ` [PATCH 5/7] arm64: dts: rockchip: Enable ALDPS on Sige5 " Alexey Charkov
@ 2026-11-20 10:48 ` Alexey Charkov
  2026-11-20 11:01   ` sashiko-bot
  2026-11-20 10:48 ` [PATCH 7/7] arm64: dts: rockchip: Shorten Sige5 " Alexey Charkov
  6 siblings, 1 reply; 10+ messages in thread
From: Alexey Charkov @ 2026-11-20 10:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	John Clark, Detlev Casanova
  Cc: devicetree, linux-arm-kernel, linux-rockchip, Alexey Charkov

Use the RTL8211F datasheet minimums for the PHY reset: hold PHYRSTB low
for 10ms, then wait 30ms before the first register access (Rev. 1.1,
section 7.17). With 20ms/100ms every reset of a PHY keeps its port from
coming up for 80ms longer than the PHY needs.

Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
index 638e00b6e165..3444198b6cf6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
@@ -809,8 +809,8 @@ rgmii_phy0: ethernet-phy@1 {
 		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&gmac0_int>, <&gmac0_rst>;
-		reset-assert-us = <20000>;
-		reset-deassert-us = <100000>;
+		reset-assert-us = <10000>;
+		reset-deassert-us = <30000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
 		realtek,aldps-enable;
 	};
@@ -824,8 +824,8 @@ rgmii_phy1: ethernet-phy@1 {
 		interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&gmac1_int>, <&gmac1_rst>;
-		reset-assert-us = <20000>;
-		reset-deassert-us = <100000>;
+		reset-assert-us = <10000>;
+		reset-deassert-us = <30000>;
 		reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>;
 		realtek,aldps-enable;
 	};

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 7/7] arm64: dts: rockchip: Shorten Sige5 Ethernet PHY reset to datasheet timing
  2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
                   ` (5 preceding siblings ...)
  2026-11-20 10:48 ` [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing Alexey Charkov
@ 2026-11-20 10:48 ` Alexey Charkov
  6 siblings, 0 replies; 10+ messages in thread
From: Alexey Charkov @ 2026-11-20 10:48 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	John Clark, Detlev Casanova
  Cc: devicetree, linux-arm-kernel, linux-rockchip, Alexey Charkov

Use the RTL8211F datasheet minimums for the PHY reset: hold PHYRSTB low
for 10ms, then wait 30ms before the first register access (Rev. 1.1,
section 7.17). With 20ms/100ms every reset of a PHY keeps its port from
coming up for 80ms longer than the PHY needs.

Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index 45a4489863bf..3e7158ebdab4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -780,8 +780,8 @@ rgmii_phy0: ethernet-phy@1 {
 		reg = <0x1>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&gmac0_rst>;
-		reset-assert-us = <20000>;
-		reset-deassert-us = <100000>;
+		reset-assert-us = <10000>;
+		reset-deassert-us = <30000>;
 		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
 		realtek,aldps-enable;
 	};
@@ -793,8 +793,8 @@ rgmii_phy1: ethernet-phy@1 {
 		reg = <0x1>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&gmac1_rst>;
-		reset-assert-us = <20000>;
-		reset-deassert-us = <100000>;
+		reset-assert-us = <10000>;
+		reset-deassert-us = <30000>;
 		reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>;
 		realtek,aldps-enable;
 	};

-- 
2.56.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 Ethernet PHYs by their ID
  2026-11-20 10:48 ` [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 " Alexey Charkov
@ 2026-11-20 10:56   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-20 10:56 UTC (permalink / raw)
  To: Alexey Charkov; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: rockchip: Fixes tag cites board addition instead of
  63136c6fecf4
--

commit 5dc14b4c5e3f94d0bf427bf2ff5dad981d4f435e
Author: Alexey Charkov <alchark@flipper.net>

> arm64: dts: rockchip: Describe Sige5 Ethernet PHYs by their ID
>
> Both Sige5 GMACs connect to an RTL8211F PHY (ID 0x001cc916) with its
> reset line in the PHY node. With only the generic C22 compatible, an OS
> has to read the PHY ID registers before it can bind a driver, and only
> that driver releases the reset line. Unless an earlier boot stage has
> already released it, the PHY stays in reset, never answers on MDIO, and
> neither Ethernet port comes up. Booting straight from U-Boot SPL in
> Falcon mode hits exactly that.
>
> Name the PHY by its ID, so it binds without the ID read and comes out of
> reset as it does. Name the node ethernet-phy@1 as well, as the Realtek
> PHY binding the ID compatible selects requires.
>
> Fixes: 40f742b07ab2 ("arm64: dts: rockchip: Add rk3576-armsom-sige5 board")
> Signed-off-by: Alexey Charkov <alchark@flipper.net>

[Severity: Low]
In 40f742b07ab2 ("arm64: dts: rockchip: Add rk3576-armsom-sige5 board"),
the PHY reset lines were described via snps,reset-gpio on the gmac0 and
gmac1 nodes, which stmmac_mdio_reset() deasserts before probing the MDIO
bus for PHY IDs.  Commit 63136c6fecf4 ("arm64: dts: rockchip: Use standard
PHY reset properties for RK3576 ArmSoM Sige5") moved those reset lines into
reset-gpios on rgmii_phy0 and rgmii_phy1 while keeping the generic C22
compatible.

Should the Fixes tag instead be:

  Fixes: 63136c6fecf4 ("arm64: dts: rockchip: Use standard PHY reset properties for RK3576 ArmSoM Sige5")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-rk3576-phys-v1-0-6382cd14e3dc@flipper.net?part=2

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing
  2026-11-20 10:48 ` [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing Alexey Charkov
@ 2026-11-20 11:01   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-20 11:01 UTC (permalink / raw)
  To: Alexey Charkov; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: rockchip: RTL8211F reset-deassert-us below 72ms
  minimum
--

commit 0900c61dff0b0908a212846ea06a953d5d033faf
Author: Alexey Charkov <alchark@flipper.net>

arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing

This commit reduces reset-assert-us and reset-deassert-us for the two
RTL8211F Ethernet PHYs on the FriendlyElec NanoPi M5 from 20ms/100ms to
10ms/30ms.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
> index 638e00b6e1658..3444198b6cf66 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
> @@ -809,8 +809,8 @@ rgmii_phy0: ethernet-phy@1 {
>  		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&gmac0_int>, <&gmac0_rst>;
> -		reset-assert-us = <20000>;
> -		reset-deassert-us = <100000>;
> +		reset-assert-us = <10000>;
> +		reset-deassert-us = <30000>;
>  		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
>  		realtek,aldps-enable;
>  	};
> @@ -824,8 +824,8 @@ rgmii_phy1: ethernet-phy@1 {
>  		interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&gmac1_int>, <&gmac1_rst>;
> -		reset-assert-us = <20000>;
> -		reset-deassert-us = <100000>;
> +		reset-assert-us = <10000>;
> +		reset-deassert-us = <30000>;
>  		reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>;
>  		realtek,aldps-enable;
>  	};

[Severity: High]
Is 30000 us for reset-deassert-us on rgmii_phy0 and rgmii_phy1 below the
minimum post-reset settling time required by newer revisions of the
RTL8211F datasheet?

Revision 1.9 of the RTL8211F datasheet increased the post-reset wait after
PHYRSTB deassertion from 30 ms to at least 72 ms for internal circuit
settling before accessing PHY registers.  Because phy_init_hw() accesses
MDIO registers immediately after waiting reset-deassert-us in
phy_device_reset(phydev, 0), a 30 ms delay can cause PHY initialization or
stmmac_hw_setup() DMA reset failures during probe or ip link down/up
cycles, as seen in 1c7412530d5d ("arm64: dts: meson: g12b: odroid-n2: fix
PHY deassert timing requirements").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-rk3576-phys-v1-0-6382cd14e3dc@flipper.net?part=6

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-11-20 11:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
2026-11-20 10:48 ` [PATCH 1/7] arm64: dts: rockchip: Describe NanoPi M5 Ethernet PHYs by their ID Alexey Charkov
2026-11-20 10:48 ` [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 " Alexey Charkov
2026-11-20 10:56   ` sashiko-bot
2026-11-20 10:48 ` [PATCH 3/7] arm64: dts: rockchip: Drop NanoPi M5 PHY reference clocks Alexey Charkov
2026-11-20 10:48 ` [PATCH 4/7] arm64: dts: rockchip: Enable ALDPS on NanoPi M5 Ethernet PHYs Alexey Charkov
2026-11-20 10:48 ` [PATCH 5/7] arm64: dts: rockchip: Enable ALDPS on Sige5 " Alexey Charkov
2026-11-20 10:48 ` [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing Alexey Charkov
2026-11-20 11:01   ` sashiko-bot
2026-11-20 10:48 ` [PATCH 7/7] arm64: dts: rockchip: Shorten Sige5 " Alexey Charkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox