Devicetree
 help / color / mirror / Atom feed
* [PATCH v2 0/3] arm64: dts: freescale: add i.MX937 FRDM board support
@ 2026-11-20 11:09 Joy Zou
  2026-11-20 11:09 ` [PATCH v2 1/3] dt-bindings: arm: fsl: add i.MX937 FRDM board Joy Zou
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Joy Zou @ 2026-11-20 11:09 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Ye Li, Peng Fan, Jacky Bai
  Cc: devicetree, linux-kernel, imx, linux-arm-kernel, Joy Zou

The i.MX937 is similar to i.MX952 in terms of hardware design, so it
reuses the i.MX952 device tree as its base to avoid duplicated dts nodes.

This series adds the DT binding compatible string for the NXP i.MX937
FRDM board and the device tree support for the board.

Compared to the i.MX952, the i.MX937 drops the local dimming and ISP
blocks and runs its Cortex-A55 cores at a lower maximum frequency. The
PCAL6416 GPIO expander is at I2C address 0x21 on i.MX937 FRDM, unlike
0x20 on i.MX952 FRDM.

Signed-off-by: Joy Zou <joy.zou@oss.nxp.com>
---
Changes in v2:
- add description explaining why the i.MX952 compatible string is included
  for patch #1.
- add a new patch to replace gpio-hog with gpio-mux in preparation for
  i.MX937 code reuse for patch #2.
- replaced gpio-hog with gpio-mux in imx952-frdm.dtsi patch, so removed
  the duplicate gpio-hog change for patch #3.
- overwrite mux-gpios property due to different expander address for patch #2.
- modify commit message for patch #3.
- Link to v1: https://patch.msgid.link/20261019-b4-imx937-frdm-v1-0-76d949a61954@oss.nxp.com

---
Joy Zou (3):
      dt-bindings: arm: fsl: add i.MX937 FRDM board
      arm64: dts: imx952-frdm: model CAN/GPIO selector as gpio-mux
      arm64: dts: freescale: add i.MX937 FRDM board support

 Documentation/devicetree/bindings/arm/fsl.yaml |  7 +++
 arch/arm64/boot/dts/freescale/Makefile         |  1 +
 arch/arm64/boot/dts/freescale/imx937-frdm.dts  | 87 ++++++++++++++++++++++++++
 arch/arm64/boot/dts/freescale/imx937.dtsi      | 12 ++++
 arch/arm64/boot/dts/freescale/imx952-frdm.dtsi | 28 ++++++---
 5 files changed, 127 insertions(+), 8 deletions(-)
---
base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
change-id: 20261019-b4-imx937-frdm-84ae3d4b72c1

Best regards,
--  
Joy Zou <joy.zou@oss.nxp.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/3] dt-bindings: arm: fsl: add i.MX937 FRDM board
  2026-11-20 11:09 [PATCH v2 0/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
@ 2026-11-20 11:09 ` Joy Zou
  2026-11-20 11:12   ` sashiko-bot
  2026-11-20 11:09 ` [PATCH v2 2/3] arm64: dts: imx952-frdm: model CAN/GPIO selector as gpio-mux Joy Zou
  2026-11-20 11:09 ` [PATCH v2 3/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
  2 siblings, 1 reply; 6+ messages in thread
From: Joy Zou @ 2026-11-20 11:09 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Ye Li, Peng Fan, Jacky Bai
  Cc: devicetree, linux-kernel, imx, linux-arm-kernel, Joy Zou

Add DT compatible string for NXP i.MX937 FRDM board.

Most software on the i.MX937 is compatible with the i.MX952
including SCMI and pinctrl.

Add the fsl,imx952-frdm compatible string to reuse the existing
support and avoid code duplication.

Signed-off-by: Joy Zou <joy.zou@oss.nxp.com>
---
Changes in v2:
1. add description explaining why the i.MX952 compatible string is included.
2. remove document for imx952-frdm compatible string.
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 00930fb49b63..b67d4504c34e 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1572,6 +1572,13 @@ properties:
           - const: toradex,osm-imx93
           - const: fsl,imx93
 
+      - description: i.MX937 based Boards
+        items:
+          - enum:
+              - fsl,imx937-frdm           # i.MX937 FRDM Board
+          - const: fsl,imx937
+          - const: fsl,imx952
+
       - description: i.MX94 based Boards
         items:
           - enum:

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/3] arm64: dts: imx952-frdm: model CAN/GPIO selector as gpio-mux
  2026-11-20 11:09 [PATCH v2 0/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
  2026-11-20 11:09 ` [PATCH v2 1/3] dt-bindings: arm: fsl: add i.MX937 FRDM board Joy Zou
@ 2026-11-20 11:09 ` Joy Zou
  2026-11-20 11:09 ` [PATCH v2 3/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
  2 siblings, 0 replies; 6+ messages in thread
From: Joy Zou @ 2026-11-20 11:09 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Ye Li, Peng Fan, Jacky Bai
  Cc: devicetree, linux-kernel, imx, linux-arm-kernel, Joy Zou

Replace the gpio-hog used for CAN/GPIO selection with a gpio-mux
controller and pinctrl-multiplexer states.

The board provides a GPIO-controlled mux between CAN and GPIO.
Describe it explicitly instead of relying on a fixed GPIO state.

Signed-off-by: Joy Zou <joy.zou@oss.nxp.com>
---
Changes in v2:
1. add a new patch to replace gpio-hog with gpio-mux in preparation for
   i.MX937 code reuse.
---
 arch/arm64/boot/dts/freescale/imx952-frdm.dtsi | 28 ++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx952-frdm.dtsi b/arch/arm64/boot/dts/freescale/imx952-frdm.dtsi
index 4d325e848aa8..88e77d6e9c45 100644
--- a/arch/arm64/boot/dts/freescale/imx952-frdm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx952-frdm.dtsi
@@ -39,6 +39,25 @@ bt_sco_codec: audio-codec-bt-sco {
 		#sound-dai-cells = <1>;
 	};
 
+	can_mux: mux-controller-0 {
+		compatible = "gpio-mux";
+		#mux-control-cells = <0>;
+		#mux-state-cells = <1>;
+		mux-gpios = <&pcal6416 4 GPIO_ACTIVE_HIGH>;
+	};
+
+	can_mux_pinctrl: pinctrl-gpiomux {
+		compatible = "pinctrl-multiplexer";
+
+		can2_fun: can-grp {
+			mux-states = <&can_mux 0>;
+		};
+
+		gpio_fun: gpio-grp {
+			mux-states = <&can_mux 1>;
+		};
+	};
+
 	chosen {
 		stdout-path = &lpuart1;
 	};
@@ -274,7 +293,7 @@ &asrc2 {
 
 &flexcan2 {
 	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_flexcan2>;
+	pinctrl-0 = <&pinctrl_flexcan2>, <&can2_fun>;
 	phys = <&flexcan2_phy>;
 	status = "okay";
 };
@@ -304,13 +323,6 @@ pcal6416: gpio@20 {
 		pinctrl-0 = <&pinctrl_pcal6416>;
 		pinctrl-names = "default";
 		vcc-supply = <&reg_3p3v>;
-
-		/* When low, select CAN; When high, select gpio. */
-		can-gpio-sel-hog {
-			gpios = <4 GPIO_ACTIVE_HIGH>;
-			gpio-hog;
-			output-low;
-		};
 	};
 };
 

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 3/3] arm64: dts: freescale: add i.MX937 FRDM board support
  2026-11-20 11:09 [PATCH v2 0/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
  2026-11-20 11:09 ` [PATCH v2 1/3] dt-bindings: arm: fsl: add i.MX937 FRDM board Joy Zou
  2026-11-20 11:09 ` [PATCH v2 2/3] arm64: dts: imx952-frdm: model CAN/GPIO selector as gpio-mux Joy Zou
@ 2026-11-20 11:09 ` Joy Zou
  2026-11-20 11:11   ` sashiko-bot
  2 siblings, 1 reply; 6+ messages in thread
From: Joy Zou @ 2026-11-20 11:09 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Ye Li, Peng Fan, Jacky Bai
  Cc: devicetree, linux-kernel, imx, linux-arm-kernel, Joy Zou

Most software on the i.MX937 is compatible with the i.MX952, so it
reuses the i.MX952 device tree as its base. Add imx937.dtsi based
on imx952.dtsi and imx937-frdm.dts based on imx952-frdm.dtsi to
support the NXP i.MX937 FRDM board.

Compared to the i.MX952, the i.MX937 drops the local dimming and ISP
blocks and runs its Cortex-A55 cores at a lower maximum frequency.

The PCAL6416 GPIO expander is at I2C address 0x21 on i.MX937 FRDM,
unlike 0x20 on i.MX952 FRDM, so disable the inherited node and add
the expander at 0x21.

Signed-off-by: Joy Zou <joy.zou@oss.nxp.com>
---
Changes in v2:
1. replaced gpio-hog with gpio-mux in imx952-frdm.dtsi patch, so removed
   the duplicate gpio-hog change.
2. overwrite mux-gpios property due to different expander address.
3. modify commit message.
---
 arch/arm64/boot/dts/freescale/Makefile        |  1 +
 arch/arm64/boot/dts/freescale/imx937-frdm.dts | 87 +++++++++++++++++++++++++++
 arch/arm64/boot/dts/freescale/imx937.dtsi     | 12 ++++
 3 files changed, 100 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index cfd548284358..8bca1a6b8478 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -958,6 +958,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla-mini-ezurio-wlan.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla-mini-lvds-tm070jvhg33.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-var-dart-sonata.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-var-som-symphony.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx937-frdm.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93w-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93w-frdm.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx943-evk.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx937-frdm.dts b/arch/arm64/boot/dts/freescale/imx937-frdm.dts
new file mode 100644
index 000000000000..374cf3804581
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx937-frdm.dts
@@ -0,0 +1,87 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2026 NXP
+ */
+
+/dts-v1/;
+
+#include "imx937.dtsi"
+#include "imx952-frdm.dtsi"
+
+/ {
+	model = "NXP i.MX937 FRDM board";
+	compatible = "fsl,imx937-frdm", "fsl,imx937", "fsl,imx952";
+};
+
+/*
+ * PCAL6416 (0x21) pin 4 selects the CAN/GPIO mux:
+ * low selects CAN, high selects GPIO. With GPIO_ACTIVE_HIGH,
+ * mux state 0 drives the pin low (CAN) and state 1 high (GPIO).
+ */
+&can_mux {
+	mux-gpios = <&pcal6416_21 4 GPIO_ACTIVE_HIGH>;
+};
+
+/*
+ * The CAN transceiver silent-mode line is on the 0x21 PCAL6416 on
+ * i.MX937 FRDM (the inherited 0x20 expander is disabled below).
+ */
+&flexcan2_phy {
+	silent-gpios = <&pcal6416_21 6 GPIO_ACTIVE_HIGH>;
+};
+
+&flexcan3_phy {
+	silent-gpios = <&pcal6416_21 6 GPIO_ACTIVE_HIGH>;
+};
+
+&lpi2c2 {
+	pcal6416_21: gpio@21 {
+		compatible = "nxp,pcal6416";
+		reg = <0x21>;
+		#interrupt-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio5>;
+		interrupts = <14 IRQ_TYPE_LEVEL_LOW>;
+		#gpio-cells = <2>;
+		gpio-controller;
+		pinctrl-0 = <&pinctrl_pcal6416>;
+		pinctrl-names = "default";
+		vcc-supply = <&reg_3p3v>;
+	};
+};
+
+/*
+ * The PCAL6416 GPIO expander is at address 0x21 on i.MX937 FRDM,
+ * unlike 0x20 on i.MX952 FRDM. Disable the inherited node.
+ */
+&pcal6416 {
+	status = "disabled";
+};
+
+/*
+ * The 0x20 PCAL6416 inherited from imx952-frdm.dtsi is disabled above;
+ * re-point every consumer to the 0x21 expander (pcal6416_21).
+ */
+&reg_ext_3v3 {
+	gpio = <&pcal6416_21 13 GPIO_ACTIVE_HIGH>;
+};
+
+&reg_ext_5v {
+	gpio = <&pcal6416_21 12 GPIO_ACTIVE_HIGH>;
+};
+
+&reg_m2_pwr {
+	gpio = <&pcal6416_21 11 GPIO_ACTIVE_HIGH>;
+};
+
+&reg_usb_vbus {
+	gpio = <&pcal6416_21 15 GPIO_ACTIVE_HIGH>;
+};
+
+&reg_usdhc3_vmmc {
+	gpio = <&pcal6416_21 9 GPIO_ACTIVE_HIGH>;
+};
+
+&usdhc3_pwrseq {
+	reset-gpios = <&pcal6416_21 8 GPIO_ACTIVE_LOW>;
+};
diff --git a/arch/arm64/boot/dts/freescale/imx937.dtsi b/arch/arm64/boot/dts/freescale/imx937.dtsi
new file mode 100644
index 000000000000..7912a9c282d8
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx937.dtsi
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR MIT)
+/*
+ * Copyright 2026 NXP
+ */
+
+#include "imx952.dtsi"
+
+&gpu_opp_table {
+	opp-1000000000 {
+		status = "disabled";
+	};
+};

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 3/3] arm64: dts: freescale: add i.MX937 FRDM board support
  2026-11-20 11:09 ` [PATCH v2 3/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
@ 2026-11-20 11:11   ` sashiko-bot
  0 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-11-20 11:11 UTC (permalink / raw)
  To: Joy Zou; +Cc: devicetree, imx, robh, conor+dt, Frank.Li

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: freescale: mismatch between imx937.dtsi GPU OPP
  and commit message
--

commit afd999f203571f5f314e686dbc42facdd65a3d63
Author: Joy Zou <joy.zou@oss.nxp.com>

arm64: dts: freescale: add i.MX937 FRDM board support

This commit adds imx937.dtsi and imx937-frdm.dts, reusing imx952.dtsi and
imx952-frdm.dtsi to support the NXP i.MX937 FRDM board.

> diff --git a/arch/arm64/boot/dts/freescale/imx937.dtsi b/arch/arm64/boot/dts/freescale/imx937.dtsi
> new file mode 100644
> index 0000000000000..7912a9c282d8c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx937.dtsi
> @@ -0,0 +1,12 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR MIT)
> +/*
> + * Copyright 2026 NXP
> + */
> +
> +#include "imx952.dtsi"
> +
> +&gpu_opp_table {
> +	opp-1000000000 {
> +		status = "disabled";
> +	};
> +};

[Severity: Medium]
Should imx937.dtsi disable the 1.0 GHz OPP in gpu_opp_table, or does the
commit message describe the wrong hardware difference?

The commit message states that i.MX937 drops the local dimming and ISP
blocks and runs its Cortex-A55 cores at a lower maximum frequency, with no
mention of the GPU.  However, the only override in imx937.dtsi disables
opp-1000000000 in gpu_opp_table, which is the operating-points-v2 table
for gpu@4d900000 in imx952.dtsi, capping the Mali GPU at 800 MHz while
leaving Cortex-A55 frequencies managed by the IMX952_PERF_A55 SCMI
performance domain unchanged.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-b4-imx937-frdm-v2-0-5e27ceec02df@oss.nxp.com?part=3

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/3] dt-bindings: arm: fsl: add i.MX937 FRDM board
  2026-11-20 11:09 ` [PATCH v2 1/3] dt-bindings: arm: fsl: add i.MX937 FRDM board Joy Zou
@ 2026-11-20 11:12   ` sashiko-bot
  0 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-11-20 11:12 UTC (permalink / raw)
  To: Joy Zou; +Cc: devicetree, imx, robh, conor+dt, Frank.Li

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: arm: fsl: commit log says fsl,imx952-frdm instead
  of fsl,imx952
--

commit 42f4f6eed8a4edf16ac9cee36f90e0ee040c6e5d
Author: Joy Zou <joy.zou@oss.nxp.com>

dt-bindings: arm: fsl: add i.MX937 FRDM board

This commit adds the devicetree binding for the NXP i.MX937 FRDM board,
including the fsl,imx952 fallback SoC compatible string.

> Add the fsl,imx952-frdm compatible string to reuse the existing
> support and avoid code duplication.

[Severity: Low]
This isn't a bug, but the commit message mentions fsl,imx952-frdm instead
of the fsl,imx952 fallback compatible string added by the patch.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-b4-imx937-frdm-v2-0-5e27ceec02df@oss.nxp.com?part=1

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-20 11:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 11:09 [PATCH v2 0/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
2026-11-20 11:09 ` [PATCH v2 1/3] dt-bindings: arm: fsl: add i.MX937 FRDM board Joy Zou
2026-11-20 11:12   ` sashiko-bot
2026-11-20 11:09 ` [PATCH v2 2/3] arm64: dts: imx952-frdm: model CAN/GPIO selector as gpio-mux Joy Zou
2026-11-20 11:09 ` [PATCH v2 3/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
2026-11-20 11:11   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox