Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Bibek Kumar Patro" <bibek.patro@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 11/20] arm64: dts: qcom: sc8280xp: Add GEM_NOC interconnect for adreno SMMU
Date: Fri, 20 Nov 2026 11:18:45 +0000	[thread overview]
Message-ID: <sashiko-outbox-225019@kernel.org> (raw)
In-Reply-To: <20261120-smmu_interconnect_addition-v4-11-cab8ee8be0b3@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: sc8280xp: unintended removal of
  interconnect-names on gpu node
--

commit 31ed160ba5181c81ec7e9540c83d18c590a7bfbd
Author: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>

arm64: dts: qcom: sc8280xp: Add GEM_NOC interconnect for adreno SMMU

This commit adds the GEM_NOC to EBI1 interconnect path to the Adreno SMMU
node on SC8280XP.

> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 703b4f4e20598..6eae42384a18d 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -3405,7 +3405,6 @@ gpu: gpu@3d00000 {
>  
>  			qcom,gmu = <&gmu>;
>  			interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>;
> -			interconnect-names = "gfx-mem";
>  			#cooling-cells = <2>;
>  
>  			status = "disabled";

[Severity: Low]
Was interconnect-names = "gfx-mem" removed from gpu@3d00000 by mistake?
The gpu node retains its MASTER_GFX3D to SLAVE_EBI1 interconnect path, for
which Documentation/devicetree/bindings/display/msm/gpu.yaml defines the
gfx-mem name, while the commit message only describes adding the
interconnect to gpu_smmu.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-smmu_interconnect_addition-v4-0-cab8ee8be0b3@oss.qualcomm.com?part=11

  reply	other threads:[~2026-11-20 11:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 11:05 [PATCH v4 00/20] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 01/20] dt-bindings: iommu: arm,smmu: Document interconnects property Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 02/20] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-11-20 11:22   ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 03/20] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 04/20] arm64: dts: qcom: lemans: " Bibek Kumar Patro
2026-11-20 11:20   ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 05/20] arm64: dts: qcom: monaco: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 06/20] arm64: dts: qcom: talos: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 07/20] arm64: dts: qcom: sm8150: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 08/20] arm64: dts: qcom: sm8250: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 09/20] arm64: dts: qcom: sm8350: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 10/20] arm64: dts: qcom: sc8180x: " Bibek Kumar Patro
2026-11-20 11:17   ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 11/20] arm64: dts: qcom: sc8280xp: " Bibek Kumar Patro
2026-11-20 11:18   ` sashiko-bot [this message]
2026-11-20 11:05 ` [PATCH v4 12/20] arm64: dts: qcom: sm8450: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 13/20] arm64: dts: qcom: sm8550: " Bibek Kumar Patro
2026-11-20 11:19   ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 14/20] arm64: dts: qcom: sm8650: " Bibek Kumar Patro
2026-11-20 11:23   ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 15/20] arm64: dts: qcom: hamoa: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 16/20] arm64: dts: qcom: kaanapali: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 17/20] arm64: dts: qcom: glymur: Add HSC_NOC " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 18/20] arm64: dts: qcom: milos: Add GEM_NOC " Bibek Kumar Patro
2026-11-20 11:06 ` [PATCH v4 19/20] arm64: dts: qcom: hawi: " Bibek Kumar Patro
2026-11-20 11:06 ` [PATCH v4 20/20] arm64: dts: qcom: sar2130p: " Bibek Kumar Patro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225019@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bibek.patro@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox