From: sashiko-bot@kernel.org
To: "Bibek Kumar Patro" <bibek.patro@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 04/20] arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adreno SMMU
Date: Fri, 20 Nov 2026 11:20:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-225025@kernel.org> (raw)
In-Reply-To: <20261120-smmu_interconnect_addition-v4-4-cab8ee8be0b3@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: lemans: adreno_smmu interconnects placed in
lemans.dtsi
--
commit 91aa80f6108e778c84b304ef687907083b95b19d
Author: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adreno SMMU
This commit adds a GEM_NOC to EBI1 interconnect path to the adreno_smmu node
in lemans.dtsi.
> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> index 20f329c0df751..be71eb30f9979 100644
> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
> @@ -3127,6 +3127,8 @@ adreno_smmu: iommu@3da0000 {
> <GIC_SPI 685 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 686 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 687 IRQ_TYPE_LEVEL_HIGH>;
> + interconnects = <&gem_noc MASTER_GPU_TCU QCOM_ICC_TAG_ALWAYS
> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
> };
[Severity: High]
Should this interconnects property be placed under &adreno_smmu in
arch/arm64/boot/dts/qcom/lemans-embedded.dtsi instead of lemans.dtsi?
Commit 1f90a2bab7f6 ("arm64: dts: qcom: lemans: Move platform resources into
lemans-embedded.dtsi") moved the RPMh interconnect binding headers, the
gem_noc and mc_virt provider nodes, and &adreno_smmu's clocks and
power-domains into lemans-embedded.dtsi so that
arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi can include lemans.dtsi directly
with SCMI-managed resources. Adding these RPMh macros and phandles to
lemans.dtsi breaks compilation for any target that includes
lemans-gearvm.dtsi because neither the macros nor &gem_noc and &mc_virt are
defined there.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-smmu_interconnect_addition-v4-0-cab8ee8be0b3@oss.qualcomm.com?part=4
next prev parent reply other threads:[~2026-11-20 11:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 11:05 [PATCH v4 00/20] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 01/20] dt-bindings: iommu: arm,smmu: Document interconnects property Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 02/20] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-11-20 11:22 ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 03/20] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 04/20] arm64: dts: qcom: lemans: " Bibek Kumar Patro
2026-11-20 11:20 ` sashiko-bot [this message]
2026-11-20 11:05 ` [PATCH v4 05/20] arm64: dts: qcom: monaco: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 06/20] arm64: dts: qcom: talos: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 07/20] arm64: dts: qcom: sm8150: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 08/20] arm64: dts: qcom: sm8250: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 09/20] arm64: dts: qcom: sm8350: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 10/20] arm64: dts: qcom: sc8180x: " Bibek Kumar Patro
2026-11-20 11:17 ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 11/20] arm64: dts: qcom: sc8280xp: " Bibek Kumar Patro
2026-11-20 11:18 ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 12/20] arm64: dts: qcom: sm8450: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 13/20] arm64: dts: qcom: sm8550: " Bibek Kumar Patro
2026-11-20 11:19 ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 14/20] arm64: dts: qcom: sm8650: " Bibek Kumar Patro
2026-11-20 11:23 ` sashiko-bot
2026-11-20 11:05 ` [PATCH v4 15/20] arm64: dts: qcom: hamoa: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 16/20] arm64: dts: qcom: kaanapali: " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 17/20] arm64: dts: qcom: glymur: Add HSC_NOC " Bibek Kumar Patro
2026-11-20 11:05 ` [PATCH v4 18/20] arm64: dts: qcom: milos: Add GEM_NOC " Bibek Kumar Patro
2026-11-20 11:06 ` [PATCH v4 19/20] arm64: dts: qcom: hawi: " Bibek Kumar Patro
2026-11-20 11:06 ` [PATCH v4 20/20] arm64: dts: qcom: sar2130p: " Bibek Kumar Patro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225025@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bibek.patro@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox