Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Artem Novak" <artem122novak@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B
Date: Sun, 22 Nov 2026 10:02:38 +0000	[thread overview]
Message-ID: <sashiko-outbox-227883@kernel.org> (raw)
In-Reply-To: <20261122095225.200916-3-artem122novak@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] ARM: dts: bcm2835: dropped leds and led_act overlay symbols
  in bcm2835-rpi-b
- [Low] ARM: dts: bcm2835: inlining deprecated LED dtsi duplicates
  legacy label node
--

commit 49ba1cd9cda13f0341e152094b002fc2c5f37a35
Author: Artem Novak <artem122novak@gmail.com>

ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B

This commit removes the bcm283x-rpi-led-deprecated.dtsi include from
bcm2835-rpi-b.dts and defines a board-local gpio-leds node for the ACT LED.

> diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> index 72764be75a799..040ba7f452163 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> @@ -3,7 +3,6 @@
>  #include "bcm2835.dtsi"
>  #include "bcm2835-rpi.dtsi"
>  #include "bcm2835-rpi-common.dtsi"
> -#include "bcm283x-rpi-led-deprecated.dtsi"
>  #include "bcm283x-rpi-smsc9512.dtsi"
>  #include "bcm283x-rpi-usb-host.dtsi"
>  
> @@ -93,8 +92,17 @@ &hdmi {
>  	status = "okay";
>  };
>  
> -&led_act {
> -	gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> +/ {
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-act {

[Severity: Medium]
Does dropping the leds: and led_act: node labels here remove those symbols
from /__symbols__ in the compiled DTB?

arch/arm/boot/dts/broadcom/Makefile builds bcm2835-rpi-b.dtb with -@ for
device-tree overlay support, and bcm283x-rpi-led-deprecated.dtsi defined
leds: leds and led_act: led-act.  Omitting both labels removes leds and
led_act from /__symbols__, breaking overlays and bootloader dtparam fixups
that target &leds or &led_act.

> +			label = "ACT";
> +			gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> +			default-state = "keep";
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
>  };

[Severity: Low]
Why inline bcm283x-rpi-led-deprecated.dtsi into bcm2835-rpi-b.dts while
keeping the deprecated label = "ACT" property?

Commit 1156e3a78bcc ("ARM: dts: bcm283x: Move ACT LED into separate dtsi")
moved this node into bcm283x-rpi-led-deprecated.dtsi specifically so existing
boards could preserve the legacy /sys/class/leds/ACT userspace ABI in one
shared fragment without new boards inheriting the deprecated gpio-leds label
property.  Open-coding the same definition here also introduces a second
/ { ... }; root node block in the middle of the board's phandle overrides.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122095225.200916-1-artem122novak@gmail.com?part=2

  reply	other threads:[~2026-11-22 10:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  9:52 [PATCH 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
2026-11-22  9:52 ` [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
2026-11-22 10:02   ` sashiko-bot
2026-11-22  9:52 ` [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
2026-11-22 10:02   ` sashiko-bot [this message]
2026-11-22 10:17 ` [PATCH v2 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
2026-11-22 10:17   ` [PATCH v2 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
2026-11-22 10:27     ` sashiko-bot
2026-11-22 10:17   ` [PATCH v2 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
2026-11-22 10:26     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227883@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=artem122novak@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox