Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jonas Karlman" <jonas@kwiboo.se>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: Add ArmSoM Forge1 board
Date: Sun, 22 Nov 2026 18:53:20 +0000	[thread overview]
Message-ID: <sashiko-outbox-228202@kernel.org> (raw)
In-Reply-To: <20261122184532.1300004-3-jonas@kwiboo.se>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: rockchip: unused rtc_int pinctrl node in
  rk3506j-armsom-forge1.dts
--

commit c8399c3a39f722c5341014879ceea3f38f7b0a7e
Author: Jonas Karlman <jonas@kwiboo.se>

ARM: dts: rockchip: Add ArmSoM Forge1 board

This commit adds initial device tree support for the RK3506J-based ArmSoM
Forge1 board.

Link: https://docs.armsom.org/armsom-forge1

> diff --git a/arch/arm/boot/dts/rockchip/rk3506j-armsom-forge1.dts b/arch/arm/boot/dts/rockchip/rk3506j-armsom-forge1.dts
> new file mode 100644
> index 0000000000000..6520fa700f647
> --- /dev/null
> +++ b/arch/arm/boot/dts/rockchip/rk3506j-armsom-forge1.dts
> @@ -0,0 +1,229 @@

[ ... ]

> +&pinctrl {

[ ... ]

> +	rtc {
> +		rtc_int: rtc-int {
> +			rockchip,pins = <0 RK_PB5 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};

[Severity: Low]
Is rtc_int intentionally defined here without an RTC device node
referencing it?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122184532.1300004-1-jonas@kwiboo.se?part=2

      reply	other threads:[~2026-11-22 18:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 18:45 [PATCH 0/2] ARM: dts: rockchip: Add ArmSoM Forge1 board Jonas Karlman
2026-11-22 18:45 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add ArmSoM Forge1 Jonas Karlman
2026-11-22 18:45 ` [PATCH 2/2] ARM: dts: rockchip: Add ArmSoM Forge1 board Jonas Karlman
2026-11-22 18:53   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-228202@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonas@kwiboo.se \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox