From: sashiko-bot@kernel.org
To: "Aaron Kling" <webgeek1234@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight
Date: Sun, 22 Nov 2026 21:52:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-228395@kernel.org> (raw)
In-Reply-To: <20261122-rp-qcs8550-display-v1-1-d513d9819a34@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: qcom: unused pmk8550_pwm left enabled in
retroidpocket-nova
- [Low] arm64: dts: qcom: missing Fixes trailer for commit d4b2991e1d19
--
commit 44003ea1a3cf923727cb35cab3ca804a9a83aed7
Author: Aaron Kling <webgeek1234@gmail.com>
> arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight
>
> This device does not use a pwm backlight, it has a backlight controlled
> by dcs commands via the panel.
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
[Severity: Low]
Since this removes an invalid pwm-backlight node, should it include a
Fixes: tag for the commit that added the board?
Fixes: d4b2991e1d19 ("arm64: dts: qcom: qcs8550: Add Retroid Pocket Nova")
> diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
> index 0a0546977a026..ef1356f4c34ce 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
> @@ -10,18 +10,6 @@
> model = "Retroid Pocket Nova";
> compatible = "retroidpocket,nova", "qcom,qcs8550", "qcom,sm8550";
>
> - backlight: backlight {
> - compatible = "pwm-backlight";
> - pwms = <&pmk8550_pwm 0 860000>;
> - brightness-levels = <1023 0>;
> - num-interpolated-steps = <1023>;
> - default-brightness-level = <600>;
> - power-supply = <&vph_pwr>;
> - enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
> - pinctrl-0 = <&pwm_backlight_default>;
> - pinctrl-names = "default";
> - };
[Severity: Low]
Should the &pmk8550_pwm node further down in this file also be removed now
that its only consumer on this board is gone?
arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts:
&pmk8550_pwm {
status = "okay";
};
Without the pwm-backlight node, neither this board nor
qcs8550-ayntec-common.dtsi (which uses pm8550_pwm for its fan and LEDs)
references pmk8550_pwm, so keeping it enabled probes an unused LPG
controller at boot.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-rp-qcs8550-display-v1-0-d513d9819a34@gmail.com?part=1
next prev parent reply other threads:[~2026-11-22 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 21:46 [PATCH 0/4] arm64: dts: qcom: qcs8550-retroidpocket: Enable displays Aaron Kling via B4 Relay
2026-11-22 21:46 ` [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight Aaron Kling via B4 Relay
2026-11-22 21:52 ` sashiko-bot [this message]
2026-11-22 21:46 ` [PATCH 2/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Enable panel Aaron Kling via B4 Relay
2026-11-22 21:46 ` [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight Aaron Kling via B4 Relay
2026-11-22 21:57 ` sashiko-bot
2026-11-22 21:46 ` [PATCH 4/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Enable panel Aaron Kling via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-228395@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox