Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Aaron Kling" <webgeek1234@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight
Date: Sun, 22 Nov 2026 21:57:00 +0000	[thread overview]
Message-ID: <sashiko-outbox-228399@kernel.org> (raw)
In-Reply-To: <20261122-rp-qcs8550-display-v1-3-d513d9819a34@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: qcom: pmk8550_pwm left enabled without consumers on
  rp6
- [Low] arm64: dts: qcom: missing Fixes trailer for commit 9b9ac54e7eec
--

commit 4c928b402de67f834d479cbb2c2525592ba6bacd
Author: Aaron Kling <webgeek1234@gmail.com>

> arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight
>
> This device does not use a pwm backlight, it has a backlight controlled
> by dcs commands via the panel.
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>

[Severity: Low]
Since this fixes an erroneous hardware description, should it include a
Fixes tag:

  Fixes: 9b9ac54e7eec ("arm64: dts: qcom: qcs8550: Add Retroid Pocket 6")

> diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
> index a93fe74b83383..91fed8795d611 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
> @@ -13,18 +13,6 @@
>  	model = "Retroid Pocket 6";
>  	compatible = "retroidpocket,rp6", "qcom,qcs8550", "qcom,sm8550";
>  
> -	backlight: backlight {
> -		compatible = "pwm-backlight";
> -		pwms = <&pmk8550_pwm 0 860000>;
> -		brightness-levels = <1023 0>;
> -		num-interpolated-steps = <1023>;
> -		default-brightness-level = <600>;
> -		power-supply = <&vph_pwr>;
> -		enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
> -		pinctrl-0 = <&pwm_backlight_default>;
> -		pinctrl-names = "default";
> -	};
> -
>  	vdd_disp_1v8: regulator-vdd-disp-1v8 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vdd_disp_1v8";

[Severity: Low]
Should the &pmk8550_pwm override at the bottom of this file also be
removed?

This backlight node was the only consumer of pmk8550_pwm on the Retroid
Pocket 6 (the fan and LEDs in qcs8550-ayntec-common.dtsi use pm8550_pwm),
so leaving &pmk8550_pwm enabled probes an unused PWM controller.
Similarly, pwm_backlight_default in qcs8550-ayntec-common.dtsi appears to
have no remaining users once the pwm-backlight nodes are removed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-rp-qcs8550-display-v1-0-d513d9819a34@gmail.com?part=3

  reply	other threads:[~2026-11-22 21:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 21:46 [PATCH 0/4] arm64: dts: qcom: qcs8550-retroidpocket: Enable displays Aaron Kling via B4 Relay
2026-11-22 21:46 ` [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight Aaron Kling via B4 Relay
2026-11-22 21:52   ` sashiko-bot
2026-11-22 21:46 ` [PATCH 2/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Enable panel Aaron Kling via B4 Relay
2026-11-22 21:46 ` [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight Aaron Kling via B4 Relay
2026-11-22 21:57   ` sashiko-bot [this message]
2026-11-22 21:46 ` [PATCH 4/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Enable panel Aaron Kling via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-228399@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=webgeek1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox