Devicetree
 help / color / mirror / Atom feed
* [PATCH 0/4] arm64: dts: qcom: qcs8550-retroidpocket: Enable displays
@ 2026-11-22 21:46 Aaron Kling via B4 Relay
  2026-11-22 21:46 ` [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight Aaron Kling via B4 Relay
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Aaron Kling via B4 Relay @ 2026-11-22 21:46 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, Aaron Kling

This first cleans up unused / invalid backlight nodes, then enables the
panel for each device.

---
Aaron Kling (4):
      arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight
      arm64: dts: qcom: qcs8550-retroidpocket-nova: Enable panel
      arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight
      arm64: dts: qcom: qcs8550-retroidpocket-rp6: Enable panel

 .../boot/dts/qcom/qcs8550-retroidpocket-nova.dts   | 49 ++++++++++++++++-----
 .../boot/dts/qcom/qcs8550-retroidpocket-rp6.dts    | 51 +++++++++++++++++-----
 2 files changed, 76 insertions(+), 24 deletions(-)
---
base-commit: 909ef7a9a30fa139e69e555e3606680f5cca7726
change-id: 20261121-rp-qcs8550-display-d799e2184da5

Best regards,
-- 
Aaron Kling <webgeek1234@gmail.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight
  2026-11-22 21:46 [PATCH 0/4] arm64: dts: qcom: qcs8550-retroidpocket: Enable displays Aaron Kling via B4 Relay
@ 2026-11-22 21:46 ` Aaron Kling via B4 Relay
  2026-11-22 21:52   ` sashiko-bot
  2026-11-22 21:46 ` [PATCH 2/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Enable panel Aaron Kling via B4 Relay
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Aaron Kling via B4 Relay @ 2026-11-22 21:46 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, Aaron Kling

From: Aaron Kling <webgeek1234@gmail.com>

This device does not use a pwm backlight, it has a backlight controlled
by dcs commands via the panel.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
index 0a0546977a026..ef1356f4c34ce 100644
--- a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
@@ -10,18 +10,6 @@
 	model = "Retroid Pocket Nova";
 	compatible = "retroidpocket,nova", "qcom,qcs8550", "qcom,sm8550";
 
-	backlight: backlight {
-		compatible = "pwm-backlight";
-		pwms = <&pmk8550_pwm 0 860000>;
-		brightness-levels = <1023 0>;
-		num-interpolated-steps = <1023>;
-		default-brightness-level = <600>;
-		power-supply = <&vph_pwr>;
-		enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
-		pinctrl-0 = <&pwm_backlight_default>;
-		pinctrl-names = "default";
-	};
-
 	vdd_disp_1v8: regulator-vdd-disp-1v8 {
 		compatible = "regulator-fixed";
 		regulator-name = "vdd_disp_1v8";

-- 
2.56.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Enable panel
  2026-11-22 21:46 [PATCH 0/4] arm64: dts: qcom: qcs8550-retroidpocket: Enable displays Aaron Kling via B4 Relay
  2026-11-22 21:46 ` [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight Aaron Kling via B4 Relay
@ 2026-11-22 21:46 ` Aaron Kling via B4 Relay
  2026-11-22 21:46 ` [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight Aaron Kling via B4 Relay
  2026-11-22 21:46 ` [PATCH 4/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Enable panel Aaron Kling via B4 Relay
  3 siblings, 0 replies; 7+ messages in thread
From: Aaron Kling via B4 Relay @ 2026-11-22 21:46 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, Aaron Kling

From: Aaron Kling <webgeek1234@gmail.com>

This is supported by the Ilitek ili7836a driver.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 .../boot/dts/qcom/qcs8550-retroidpocket-nova.dts   | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
index ef1356f4c34ce..11689f1bc3d8f 100644
--- a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
@@ -80,6 +80,43 @@ touchscreen@38 {
 	};
 };
 
+&mdss_dsi0 {
+	vdda-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+
+	panel@0 {
+		reg = <0>;
+		compatible = "retroidpocket,nova-panel", "ilitek,ili7836a";
+
+		pinctrl-0 = <&dsi_p_rst_active>, <&dsi_p_te_active>;
+		pinctrl-1 = <&dsi_p_rst_suspend>, <&dsi_p_te_suspend>;
+		pinctrl-names = "default", "sleep";
+
+		vddio-supply = <&vdd_disp_1v8>;
+		avdd-supply = <&vdd_disp_2v8>;
+
+		reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+
+		port {
+			panel0_in: endpoint {
+				remote-endpoint = <&mdss_dsi0_out>;
+			};
+		};
+	};
+};
+
+&mdss_dsi0_out {
+	remote-endpoint = <&panel0_in>;
+	data-lanes = <0 1 2 3>;
+};
+
+&mdss_dsi0_phy {
+	vdds-supply = <&vreg_l1e_0p88>;
+
+	status = "okay";
+};
+
 &mdss_dsi1 {
 	status = "disabled";
 };

-- 
2.56.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight
  2026-11-22 21:46 [PATCH 0/4] arm64: dts: qcom: qcs8550-retroidpocket: Enable displays Aaron Kling via B4 Relay
  2026-11-22 21:46 ` [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight Aaron Kling via B4 Relay
  2026-11-22 21:46 ` [PATCH 2/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Enable panel Aaron Kling via B4 Relay
@ 2026-11-22 21:46 ` Aaron Kling via B4 Relay
  2026-11-22 21:57   ` sashiko-bot
  2026-11-22 21:46 ` [PATCH 4/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Enable panel Aaron Kling via B4 Relay
  3 siblings, 1 reply; 7+ messages in thread
From: Aaron Kling via B4 Relay @ 2026-11-22 21:46 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, Aaron Kling

From: Aaron Kling <webgeek1234@gmail.com>

This device does not use a pwm backlight, it has a backlight controlled
by dcs commands via the panel.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
index a93fe74b83383..91fed8795d611 100644
--- a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
@@ -13,18 +13,6 @@
 	model = "Retroid Pocket 6";
 	compatible = "retroidpocket,rp6", "qcom,qcs8550", "qcom,sm8550";
 
-	backlight: backlight {
-		compatible = "pwm-backlight";
-		pwms = <&pmk8550_pwm 0 860000>;
-		brightness-levels = <1023 0>;
-		num-interpolated-steps = <1023>;
-		default-brightness-level = <600>;
-		power-supply = <&vph_pwr>;
-		enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
-		pinctrl-0 = <&pwm_backlight_default>;
-		pinctrl-names = "default";
-	};
-
 	vdd_disp_1v8: regulator-vdd-disp-1v8 {
 		compatible = "regulator-fixed";
 		regulator-name = "vdd_disp_1v8";

-- 
2.56.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 4/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Enable panel
  2026-11-22 21:46 [PATCH 0/4] arm64: dts: qcom: qcs8550-retroidpocket: Enable displays Aaron Kling via B4 Relay
                   ` (2 preceding siblings ...)
  2026-11-22 21:46 ` [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight Aaron Kling via B4 Relay
@ 2026-11-22 21:46 ` Aaron Kling via B4 Relay
  3 siblings, 0 replies; 7+ messages in thread
From: Aaron Kling via B4 Relay @ 2026-11-22 21:46 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, Aaron Kling

From: Aaron Kling <webgeek1234@gmail.com>

This is supported by the Visionox vtdr6130 driver.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 .../boot/dts/qcom/qcs8550-retroidpocket-rp6.dts    | 39 ++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
index 91fed8795d611..5bbec9e1bae7c 100644
--- a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
@@ -84,6 +84,45 @@ touchscreen@38 {
 	};
 };
 
+&mdss_dsi0 {
+	vdda-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+
+	panel@0 {
+		reg = <0>;
+		compatible = "retroidpocket,rp6-panel", "visionox,vtdr6130";
+
+		pinctrl-0 = <&dsi_p_rst_active>, <&dsi_p_te_active>;
+		pinctrl-1 = <&dsi_p_rst_suspend>, <&dsi_p_te_suspend>;
+		pinctrl-names = "default", "sleep";
+
+		vddio-supply = <&vdd_disp_1v8>;
+		vci-supply = <&vdd_disp_2v8>;
+
+		reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+
+		rotation = <270>;
+
+		port {
+			panel0_in: endpoint {
+				remote-endpoint = <&mdss_dsi0_out>;
+			};
+		};
+	};
+};
+
+&mdss_dsi0_out {
+	remote-endpoint = <&panel0_in>;
+	data-lanes = <0 1 2 3>;
+};
+
+&mdss_dsi0_phy {
+	vdds-supply = <&vreg_l1e_0p88>;
+
+	status = "okay";
+};
+
 &mdss_dsi1 {
 	status = "disabled";
 };

-- 
2.56.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight
  2026-11-22 21:46 ` [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight Aaron Kling via B4 Relay
@ 2026-11-22 21:52   ` sashiko-bot
  0 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-11-22 21:52 UTC (permalink / raw)
  To: Aaron Kling; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: qcom: unused pmk8550_pwm left enabled in
  retroidpocket-nova
- [Low] arm64: dts: qcom: missing Fixes trailer for commit d4b2991e1d19
--

commit 44003ea1a3cf923727cb35cab3ca804a9a83aed7
Author: Aaron Kling <webgeek1234@gmail.com>

> arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight
>
> This device does not use a pwm backlight, it has a backlight controlled
> by dcs commands via the panel.
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>

[Severity: Low]
Since this removes an invalid pwm-backlight node, should it include a
Fixes: tag for the commit that added the board?

  Fixes: d4b2991e1d19 ("arm64: dts: qcom: qcs8550: Add Retroid Pocket Nova")

> diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
> index 0a0546977a026..ef1356f4c34ce 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
> @@ -10,18 +10,6 @@
>  	model = "Retroid Pocket Nova";
>  	compatible = "retroidpocket,nova", "qcom,qcs8550", "qcom,sm8550";
>  
> -	backlight: backlight {
> -		compatible = "pwm-backlight";
> -		pwms = <&pmk8550_pwm 0 860000>;
> -		brightness-levels = <1023 0>;
> -		num-interpolated-steps = <1023>;
> -		default-brightness-level = <600>;
> -		power-supply = <&vph_pwr>;
> -		enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
> -		pinctrl-0 = <&pwm_backlight_default>;
> -		pinctrl-names = "default";
> -	};

[Severity: Low]
Should the &pmk8550_pwm node further down in this file also be removed now
that its only consumer on this board is gone?

arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts:
&pmk8550_pwm {
	status = "okay";
};

Without the pwm-backlight node, neither this board nor
qcs8550-ayntec-common.dtsi (which uses pm8550_pwm for its fan and LEDs)
references pmk8550_pwm, so keeping it enabled probes an unused LPG
controller at boot.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-rp-qcs8550-display-v1-0-d513d9819a34@gmail.com?part=1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight
  2026-11-22 21:46 ` [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight Aaron Kling via B4 Relay
@ 2026-11-22 21:57   ` sashiko-bot
  0 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-11-22 21:57 UTC (permalink / raw)
  To: Aaron Kling; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: qcom: pmk8550_pwm left enabled without consumers on
  rp6
- [Low] arm64: dts: qcom: missing Fixes trailer for commit 9b9ac54e7eec
--

commit 4c928b402de67f834d479cbb2c2525592ba6bacd
Author: Aaron Kling <webgeek1234@gmail.com>

> arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight
>
> This device does not use a pwm backlight, it has a backlight controlled
> by dcs commands via the panel.
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>

[Severity: Low]
Since this fixes an erroneous hardware description, should it include a
Fixes tag:

  Fixes: 9b9ac54e7eec ("arm64: dts: qcom: qcs8550: Add Retroid Pocket 6")

> diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
> index a93fe74b83383..91fed8795d611 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-rp6.dts
> @@ -13,18 +13,6 @@
>  	model = "Retroid Pocket 6";
>  	compatible = "retroidpocket,rp6", "qcom,qcs8550", "qcom,sm8550";
>  
> -	backlight: backlight {
> -		compatible = "pwm-backlight";
> -		pwms = <&pmk8550_pwm 0 860000>;
> -		brightness-levels = <1023 0>;
> -		num-interpolated-steps = <1023>;
> -		default-brightness-level = <600>;
> -		power-supply = <&vph_pwr>;
> -		enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
> -		pinctrl-0 = <&pwm_backlight_default>;
> -		pinctrl-names = "default";
> -	};
> -
>  	vdd_disp_1v8: regulator-vdd-disp-1v8 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vdd_disp_1v8";

[Severity: Low]
Should the &pmk8550_pwm override at the bottom of this file also be
removed?

This backlight node was the only consumer of pmk8550_pwm on the Retroid
Pocket 6 (the fan and LEDs in qcs8550-ayntec-common.dtsi use pm8550_pwm),
so leaving &pmk8550_pwm enabled probes an unused PWM controller.
Similarly, pwm_backlight_default in qcs8550-ayntec-common.dtsi appears to
have no remaining users once the pwm-backlight nodes are removed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-rp-qcs8550-display-v1-0-d513d9819a34@gmail.com?part=3

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-22 21:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22 21:46 [PATCH 0/4] arm64: dts: qcom: qcs8550-retroidpocket: Enable displays Aaron Kling via B4 Relay
2026-11-22 21:46 ` [PATCH 1/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Remove pwm backlight Aaron Kling via B4 Relay
2026-11-22 21:52   ` sashiko-bot
2026-11-22 21:46 ` [PATCH 2/4] arm64: dts: qcom: qcs8550-retroidpocket-nova: Enable panel Aaron Kling via B4 Relay
2026-11-22 21:46 ` [PATCH 3/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Remove pwm backlight Aaron Kling via B4 Relay
2026-11-22 21:57   ` sashiko-bot
2026-11-22 21:46 ` [PATCH 4/4] arm64: dts: qcom: qcs8550-retroidpocket-rp6: Enable panel Aaron Kling via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox