From: John Hubbard <jhubbard@nvidia.com>
To: Sarthak Sharma <sarthak.sharma@arm.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Jason Gunthorpe <jgg@ziepe.ca>, Peter Xu <peterx@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/5] selftests/mm: separate GUP microbenchmarking from functional testing
Date: Fri, 29 May 2026 12:34:09 -0700 [thread overview]
Message-ID: <13b63b4f-6a4b-4433-93e8-78035ab62b83@nvidia.com> (raw)
In-Reply-To: <3b4176f4-e099-490c-a5e2-6a36d00b1207@arm.com>
On 5/28/26 10:57 PM, Sarthak Sharma wrote:
> On 5/28/26 12:17 AM, Andrew Morton wrote:
>> On Wed, 27 May 2026 19:54:27 +0530 Sarthak Sharma <sarthak.sharma@arm.com> wrote:
...
> Thanks! I went through Sashiko's review.
>
> Both the points are valid but look very minor to me: one is a temporary
> x86 build issue fixed by the next patch and the other is stricter
This is the sort of claim that an AI will make, in kernel code: "it's
just a temporary build issue". I've seen this happen during sessions
when I'm interrogating an AI about something.
Don't be misled by AI's evaluations, as unless it is guided very
firmly (sashiko for example has fairly firm guidance, although still
a work in progress) it will provide routinely terrible advice about
how to deal with the kernel.
I'm sure we have something in the "how to contribute" docs that
explain that patchsets must be bisectable and that there are no
"minor" build "issues"!
I'd request that you study those docs and the surrounding ones,
it won't take long and it will help immunize you against the
various AI suggestions that seem to be unavoidable problems in
2026.
thanks,
--
John Hubbard
next prev parent reply other threads:[~2026-05-29 19:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 14:24 [PATCH v4 0/5] selftests/mm: separate GUP microbenchmarking from functional testing Sarthak Sharma
2026-05-27 14:24 ` [PATCH v4 1/5] selftests/mm: make file helpers return errors Sarthak Sharma
2026-06-03 10:01 ` Mike Rapoport
2026-05-27 14:24 ` [PATCH v4 2/5] tools/lib/mm: add shared file helpers Sarthak Sharma
2026-06-01 6:10 ` Sarthak Sharma
2026-06-02 0:39 ` Andrew Morton
2026-05-27 14:24 ` [PATCH v4 3/5] tools/lib/mm: move hugepage_settings out of selftests Sarthak Sharma
2026-06-03 10:01 ` Mike Rapoport
2026-05-27 14:24 ` [PATCH v4 4/5] tools/mm: add a standalone GUP microbenchmark Sarthak Sharma
2026-05-27 14:24 ` [PATCH v4 5/5] selftests/mm: rewrite gup_test as a standalone harness-based selftest Sarthak Sharma
2026-05-27 18:47 ` [PATCH v4 0/5] selftests/mm: separate GUP microbenchmarking from functional testing Andrew Morton
2026-05-29 5:57 ` Sarthak Sharma
2026-05-29 6:06 ` Dev Jain
2026-05-29 6:31 ` Sarthak Sharma
2026-05-29 19:34 ` John Hubbard [this message]
2026-06-01 12:04 ` Sarthak Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13b63b4f-6a4b-4433-93e8-78035ab62b83@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=jgg@ziepe.ca \
--cc=lance.yang@linux.dev \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sarthak.sharma@arm.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox