Linux Documentation
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Sarthak Sharma <sarthak.sharma@arm.com>
Cc: David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	Zi Yan <ziy@nvidia.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Nico Pache <npache@redhat.com>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
	Leon Romanovsky <leon@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Mark Brown <broonie@kernel.org>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/5] tools/lib/mm: add shared file helpers
Date: Mon, 1 Jun 2026 17:39:29 -0700	[thread overview]
Message-ID: <20260601173929.aa5141c274c351ccbcabc767@linux-foundation.org> (raw)
In-Reply-To: <2fb753d0-a9cd-48f3-a24d-ea0b54330279@arm.com>

On Mon, 1 Jun 2026 11:40:52 +0530 Sarthak Sharma <sarthak.sharma@arm.com> wrote:

> On 5/27/26 7:54 PM, Sarthak Sharma wrote:
> > Move read_file(), write_file(), read_num(), and write_num() out of
> > tools/testing/selftests/mm/vm_util.c into a new shared helper under
> > tools/lib/mm/.
> > 
> > These helpers are used by mm selftests today and will also be needed by
> > shared hugepage helpers in subsequent patches. Move them to a generic
> > location so they can be reused outside selftests as well.
> > 
> > Keep the helpers exposed to mm selftests through vm_util.h by including
> > the new shared header there, and link the new helper into the
> > selftests/mm build.
> > 
> > Add tools/lib/mm/ to the MEMORY MANAGEMENT - MISC entry in MAINTAINERS.
> > 
> > Signed-off-by: Sarthak Sharma <sarthak.sharma@arm.com>
> > ---
> 
> Hi Andrew!
> 
> Can you please fold the below fixlet into patch 2, as suggested by
> Sashiko.

Thanks.  Please incorporate this (and the bisection fixlet and anything
else) into a v5 series, after 7.2-rc1?

Because it's late in 7.1-rcX and there is still much reviewing and
testing to be done (please).


  reply	other threads:[~2026-06-02  0:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 14:24 [PATCH v4 0/5] selftests/mm: separate GUP microbenchmarking from functional testing Sarthak Sharma
2026-05-27 14:24 ` [PATCH v4 1/5] selftests/mm: make file helpers return errors Sarthak Sharma
2026-06-03 10:01   ` Mike Rapoport
2026-05-27 14:24 ` [PATCH v4 2/5] tools/lib/mm: add shared file helpers Sarthak Sharma
2026-06-01  6:10   ` Sarthak Sharma
2026-06-02  0:39     ` Andrew Morton [this message]
2026-05-27 14:24 ` [PATCH v4 3/5] tools/lib/mm: move hugepage_settings out of selftests Sarthak Sharma
2026-06-03 10:01   ` Mike Rapoport
2026-05-27 14:24 ` [PATCH v4 4/5] tools/mm: add a standalone GUP microbenchmark Sarthak Sharma
2026-05-27 14:24 ` [PATCH v4 5/5] selftests/mm: rewrite gup_test as a standalone harness-based selftest Sarthak Sharma
2026-05-27 18:47 ` [PATCH v4 0/5] selftests/mm: separate GUP microbenchmarking from functional testing Andrew Morton
2026-05-29  5:57   ` Sarthak Sharma
2026-05-29  6:06     ` Dev Jain
2026-05-29  6:31       ` Sarthak Sharma
2026-05-29 19:34     ` John Hubbard
2026-06-01 12:04       ` Sarthak Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601173929.aa5141c274c351ccbcabc767@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=lance.yang@linux.dev \
    --cc=leon@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=peterx@redhat.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=sarthak.sharma@arm.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox