From: Babu Moger <babu.moger@amd.com>
To: <corbet@lwn.net>, <reinette.chatre@intel.com>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
Cc: <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
<x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
<akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
<rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
<songmuchun@bytedance.com>, <peterz@infradead.org>,
<jpoimboe@kernel.org>, <pbonzini@redhat.com>,
<babu.moger@amd.com>, <chang.seok.bae@intel.com>,
<pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
<daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
<tony.luck@intel.com>, <james.morse@arm.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bagasdotme@gmail.com>, <eranian@google.com>,
<christophe.leroy@csgroup.eu>,
<pawan.kumar.gupta@linux.intel.com>, <jarkko@kernel.org>,
<adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
<peternewman@google.com>
Subject: [PATCH v9 06/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config()
Date: Thu, 1 Dec 2022 09:36:41 -0600 [thread overview]
Message-ID: <166990900117.17806.4506067708943298894.stgit@bmoger-ubuntu> (raw)
In-Reply-To: <166990882621.17806.16780480657453071426.stgit@bmoger-ubuntu>
The function rdt_get_mon_l3_config() needs to call rdt_cpu_has() to
query the monitor related features. It cannot be called right now
because rdt_cpu_has() has the __init attribute but rdt_get_mon_l3_config()
doesn't. So, add the __init attribute to rdt_get_mon_l3_config() to
resolve it.
Also, make the function rdt_cpu_has() available outside core.c file.
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
arch/x86/kernel/cpu/resctrl/core.c | 2 +-
arch/x86/kernel/cpu/resctrl/internal.h | 1 +
arch/x86/kernel/cpu/resctrl/monitor.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index b4fc851f6489..030d3b409768 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -728,7 +728,7 @@ static int __init set_rdt_options(char *str)
}
__setup("rdt", set_rdt_options);
-static bool __init rdt_cpu_has(int flag)
+bool __init rdt_cpu_has(int flag)
{
bool ret = boot_cpu_has(flag);
struct rdt_options *o;
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index fdbbf66312ec..7bbfc10094b6 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -512,6 +512,7 @@ void closid_free(int closid);
int alloc_rmid(void);
void free_rmid(u32 rmid);
int rdt_get_mon_l3_config(struct rdt_resource *r);
+bool rdt_cpu_has(int flag);
void mon_event_count(void *info);
int rdtgroup_mondata_show(struct seq_file *m, void *arg);
void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
index efe0c30d3a12..e33e8d8bd796 100644
--- a/arch/x86/kernel/cpu/resctrl/monitor.c
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -746,7 +746,7 @@ static void l3_mon_evt_init(struct rdt_resource *r)
list_add_tail(&mbm_local_event.list, &r->evt_list);
}
-int rdt_get_mon_l3_config(struct rdt_resource *r)
+int __init rdt_get_mon_l3_config(struct rdt_resource *r)
{
unsigned int mbm_offset = boot_cpu_data.x86_cache_mbm_width_offset;
struct rdt_hw_resource *hw_res = resctrl_to_arch_res(r);
next prev parent reply other threads:[~2022-12-01 15:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 15:35 [PATCH v9 00/13] Support for AMD QoS new features Babu Moger
2022-12-01 15:36 ` [PATCH v9 01/13] x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag Babu Moger
2022-12-15 17:08 ` Reinette Chatre
2022-12-15 21:10 ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 02/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA Babu Moger
2022-12-15 17:10 ` Reinette Chatre
2022-12-15 21:30 ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 03/13] x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag Babu Moger
2022-12-15 17:11 ` Reinette Chatre
2022-12-19 15:31 ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 04/13] x86/resctrl: Include new features in command line options Babu Moger
2022-12-15 17:12 ` Reinette Chatre
2022-12-19 15:33 ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 05/13] x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation Babu Moger
2022-12-15 17:13 ` Reinette Chatre
2022-12-19 15:34 ` Moger, Babu
2022-12-01 15:36 ` Babu Moger [this message]
2022-12-15 17:17 ` [PATCH v9 06/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config() Reinette Chatre
2022-12-19 15:51 ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 07/13] x86/resctrl: Introduce data structure to support monitor configuration Babu Moger
2022-12-15 17:19 ` Reinette Chatre
2022-12-19 17:56 ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 08/13] x86/resctrl: Add sysfs interface to read mbm_total_bytes_config Babu Moger
2022-12-15 17:40 ` Reinette Chatre
2022-12-19 18:21 ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 09/13] x86/resctrl: Add sysfs interface to read mbm_local_bytes_config Babu Moger
2022-12-15 17:43 ` Reinette Chatre
2022-12-19 18:27 ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 10/13] x86/resctrl: Add sysfs interface to write mbm_total_bytes_config Babu Moger
2022-12-15 18:24 ` Reinette Chatre
2022-12-19 19:28 ` Moger, Babu
2022-12-20 17:32 ` Reinette Chatre
2022-12-20 18:58 ` Moger, Babu
2022-12-19 19:50 ` Moger, Babu
2022-12-20 17:32 ` Reinette Chatre
2022-12-20 18:00 ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 11/13] x86/resctrl: Add sysfs interface to write mbm_local_bytes_config Babu Moger
2022-12-15 18:25 ` Reinette Chatre
2022-12-19 19:51 ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 12/13] x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Babu Moger
2022-12-15 18:26 ` Reinette Chatre
2022-12-19 19:59 ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 13/13] Documentation/x86: Update resctrl.rst for new features Babu Moger
2022-12-15 18:30 ` Reinette Chatre
2022-12-19 20:05 ` Moger, Babu
2022-12-15 15:08 ` [PATCH v9 00/13] Support for AMD QoS " Moger, Babu
2022-12-15 15:35 ` Reinette Chatre
2022-12-15 16:12 ` Moger, Babu
2022-12-15 18:38 ` Reinette Chatre
2022-12-19 20:57 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166990900117.17806.4506067708943298894.stgit@bmoger-ubuntu \
--to=babu.moger@amd.com \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=quic_jiles@quicinc.com \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=sandipan.das@amd.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox