* Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore
[not found] <20180226150457.22299-1-kai.heng.feng@canonical.com>
@ 2018-02-28 23:52 ` kbuild test robot
2018-03-01 0:08 ` kbuild test robot
1 sibling, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-02-28 23:52 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: kbuild-all, gregkh, oneukum, willy, corbet, linux-doc,
linux-kernel, linux-usb, Kai-Heng Feng
[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]
Hi Kai-Heng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.16-rc3 next-20180228]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/usb-core-Add-quirks-parameter-for-usbcore/20180227-211635
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: tile-tilegx_defconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile
All errors (new ones prefixed by >>):
>> drivers/usb/core/quirks.c:15:43: error: expected ')' before 'sizeof'
module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
^~~~~~
drivers/usb/core/quirks.c:16:26: error: expected ')' before string constant
MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying quirks=vendorID:productID:quirks");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +15 drivers/usb/core/quirks.c
13
14 static char quirks_param[128];
> 15 module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
16 MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying quirks=vendorID:productID:quirks");
17
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 16771 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore
[not found] <20180226150457.22299-1-kai.heng.feng@canonical.com>
2018-02-28 23:52 ` [PATCH v4] usb: core: Add "quirks" parameter for usbcore kbuild test robot
@ 2018-03-01 0:08 ` kbuild test robot
1 sibling, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-03-01 0:08 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: kbuild-all, gregkh, oneukum, willy, corbet, linux-doc,
linux-kernel, linux-usb, Kai-Heng Feng
[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]
Hi Kai-Heng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.16-rc3 next-20180228]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/usb-core-Add-quirks-parameter-for-usbcore/20180227-211635
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: mips-sb1250_swarm_defconfig (attached as .config)
compiler: mips64-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mips
All errors (new ones prefixed by >>):
drivers/usb/core/quirks.c:15:43: error: expected ')' before 'sizeof'
module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
^~~~~~
>> drivers/usb/core/quirks.c:16:26: error: expected ')' before string constant
MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying quirks=vendorID:productID:quirks");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +16 drivers/usb/core/quirks.c
13
14 static char quirks_param[128];
> 15 module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
> 16 MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying quirks=vendorID:productID:quirks");
17
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 13255 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread