* [PATCH 2/2] Documentation/gpu: Fix no structured comments warning for drm_gem_ttm_helper.h
[not found] <20190920193558.89815-1-sean@poorly.run>
@ 2019-09-20 19:35 ` Sean Paul
2019-09-23 6:59 ` Gerd Hoffmann
2019-09-23 7:03 ` Thomas Zimmermann
0 siblings, 2 replies; 5+ messages in thread
From: Sean Paul @ 2019-09-20 19:35 UTC (permalink / raw)
To: dri-devel
Cc: Sean Paul, Gerd Hoffmann, Thomas Zimmermann, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie,
Daniel Vetter, Jonathan Corbet, linux-doc
From: Sean Paul <seanpaul@chromium.org>
Fixes
include/drm/drm_gem_ttm_helper.h:1: warning: no structured comments found
Fixes: ff540b76f14a ("drm/ttm: add drm gem ttm helpers, starting with drm_gem_ttm_print_info()")
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
Documentation/gpu/drm-mm.rst | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
index 99d56015e077..59619296c84b 100644
--- a/Documentation/gpu/drm-mm.rst
+++ b/Documentation/gpu/drm-mm.rst
@@ -406,9 +406,6 @@ GEM TTM Helper Functions Reference
.. kernel-doc:: drivers/gpu/drm/drm_gem_ttm_helper.c
:doc: overview
-.. kernel-doc:: include/drm/drm_gem_ttm_helper.h
- :internal:
-
.. kernel-doc:: drivers/gpu/drm/drm_gem_ttm_helper.c
:export:
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] Documentation/gpu: Fix no structured comments warning for drm_gem_ttm_helper.h
2019-09-20 19:35 ` [PATCH 2/2] Documentation/gpu: Fix no structured comments warning for drm_gem_ttm_helper.h Sean Paul
@ 2019-09-23 6:59 ` Gerd Hoffmann
2019-09-23 14:08 ` Sean Paul
2019-09-23 7:03 ` Thomas Zimmermann
1 sibling, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2019-09-23 6:59 UTC (permalink / raw)
To: Sean Paul
Cc: dri-devel, Sean Paul, Thomas Zimmermann, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, David Airlie, Daniel Vetter,
Jonathan Corbet, linux-doc
On Fri, Sep 20, 2019 at 03:35:52PM -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> Fixes
> include/drm/drm_gem_ttm_helper.h:1: warning: no structured comments found
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] Documentation/gpu: Fix no structured comments warning for drm_gem_ttm_helper.h
2019-09-20 19:35 ` [PATCH 2/2] Documentation/gpu: Fix no structured comments warning for drm_gem_ttm_helper.h Sean Paul
2019-09-23 6:59 ` Gerd Hoffmann
@ 2019-09-23 7:03 ` Thomas Zimmermann
2019-10-08 16:36 ` Daniel Vetter
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Zimmermann @ 2019-09-23 7:03 UTC (permalink / raw)
To: Sean Paul, dri-devel
Cc: Sean Paul, Gerd Hoffmann, Daniel Vetter, Maarten Lankhorst,
Maxime Ripard, David Airlie, Daniel Vetter, Jonathan Corbet,
linux-doc
[-- Attachment #1.1: Type: text/plain, Size: 1750 bytes --]
Hi
Am 20.09.19 um 21:35 schrieb Sean Paul:
> From: Sean Paul <seanpaul@chromium.org>
>
> Fixes
> include/drm/drm_gem_ttm_helper.h:1: warning: no structured comments found
That missing documentation looks like an oversight to me.
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
under the premise that there's not currently some patch with the missing
documentation floating around.
Best regards
Thomas
> Fixes: ff540b76f14a ("drm/ttm: add drm gem ttm helpers, starting with drm_gem_ttm_print_info()")
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> Documentation/gpu/drm-mm.rst | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
> index 99d56015e077..59619296c84b 100644
> --- a/Documentation/gpu/drm-mm.rst
> +++ b/Documentation/gpu/drm-mm.rst
> @@ -406,9 +406,6 @@ GEM TTM Helper Functions Reference
> .. kernel-doc:: drivers/gpu/drm/drm_gem_ttm_helper.c
> :doc: overview
>
> -.. kernel-doc:: include/drm/drm_gem_ttm_helper.h
> - :internal:
> -
> .. kernel-doc:: drivers/gpu/drm/drm_gem_ttm_helper.c
> :export:
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] Documentation/gpu: Fix no structured comments warning for drm_gem_ttm_helper.h
2019-09-23 6:59 ` Gerd Hoffmann
@ 2019-09-23 14:08 ` Sean Paul
0 siblings, 0 replies; 5+ messages in thread
From: Sean Paul @ 2019-09-23 14:08 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Sean Paul, dri-devel, Sean Paul, Thomas Zimmermann, Daniel Vetter,
Maarten Lankhorst, David Airlie, Daniel Vetter, Jonathan Corbet,
linux-doc
On Mon, Sep 23, 2019 at 08:59:46AM +0200, Gerd Hoffmann wrote:
> On Fri, Sep 20, 2019 at 03:35:52PM -0400, Sean Paul wrote:
> > From: Sean Paul <seanpaul@chromium.org>
> >
> > Fixes
> > include/drm/drm_gem_ttm_helper.h:1: warning: no structured comments found
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
Thanks, pushed to drm-misc-next
Sean
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] Documentation/gpu: Fix no structured comments warning for drm_gem_ttm_helper.h
2019-09-23 7:03 ` Thomas Zimmermann
@ 2019-10-08 16:36 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-10-08 16:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Sean Paul, dri-devel, Sean Paul, Gerd Hoffmann, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, David Airlie, Daniel Vetter,
Jonathan Corbet, linux-doc
On Mon, Sep 23, 2019 at 09:03:01AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 20.09.19 um 21:35 schrieb Sean Paul:
> > From: Sean Paul <seanpaul@chromium.org>
> >
> > Fixes
> > include/drm/drm_gem_ttm_helper.h:1: warning: no structured comments found
>
> That missing documentation looks like an oversight to me.
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> under the premise that there's not currently some patch with the missing
> documentation floating around.
There's no struct or inline functions in that header file, so really
nothing to document. Just need to make sure that if we add anything, we
re-add the include directive.
-Daniel
>
> Best regards
> Thomas
>
> > Fixes: ff540b76f14a ("drm/ttm: add drm gem ttm helpers, starting with drm_gem_ttm_print_info()")
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> > Documentation/gpu/drm-mm.rst | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
> > index 99d56015e077..59619296c84b 100644
> > --- a/Documentation/gpu/drm-mm.rst
> > +++ b/Documentation/gpu/drm-mm.rst
> > @@ -406,9 +406,6 @@ GEM TTM Helper Functions Reference
> > .. kernel-doc:: drivers/gpu/drm/drm_gem_ttm_helper.c
> > :doc: overview
> >
> > -.. kernel-doc:: include/drm/drm_gem_ttm_helper.h
> > - :internal:
> > -
> > .. kernel-doc:: drivers/gpu/drm/drm_gem_ttm_helper.c
> > :export:
> >
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
> HRB 21284 (AG Nürnberg)
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-08 16:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190920193558.89815-1-sean@poorly.run>
2019-09-20 19:35 ` [PATCH 2/2] Documentation/gpu: Fix no structured comments warning for drm_gem_ttm_helper.h Sean Paul
2019-09-23 6:59 ` Gerd Hoffmann
2019-09-23 14:08 ` Sean Paul
2019-09-23 7:03 ` Thomas Zimmermann
2019-10-08 16:36 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox