[PATCH] Documentation: update for gcc 4.9 requirement

[PATCH] Documentation: update for gcc 4.9 requirement

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

Update Documentation for the gcc v4.9 upgrade requirement.

Fixes: 6ec4476ac825 ("Raise gcc version requirement to 4.9")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 Documentation/admin-guide/README.rst |    2 +-
 Documentation/process/changes.rst    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20200708.orig/Documentation/admin-guide/README.rst
+++ linux-next-20200708/Documentation/admin-guide/README.rst
@@ -258,7 +258,7 @@ Configuring the kernel
 Compiling the kernel
 --------------------
 
- - Make sure you have at least gcc 4.6 available.
+ - Make sure you have at least gcc 4.9 available.
    For more information, refer to :ref:`Documentation/process/changes.rst <changes>`.
 
    Please note that you can still run a.out user programs with this kernel.
--- linux-next-20200708.orig/Documentation/process/changes.rst
+++ linux-next-20200708/Documentation/process/changes.rst
@@ -29,7 +29,7 @@ you probably needn't concern yourself wi
 ====================== ===============  ========================================
         Program        Minimal version       Command to check the version
 ====================== ===============  ========================================
-GNU C                  4.8              gcc --version
+GNU C                  4.9              gcc --version
 GNU make               3.81             make --version
 binutils               2.23             ld -v
 flex                   2.5.35           flex --version

Re: [PATCH] Documentation: update for gcc 4.9 requirement

[Linus Torvalds]

On Wed, Jul 8, 2020 at 11:45 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> - - Make sure you have at least gcc 4.6 available.
> + - Make sure you have at least gcc 4.9 available.
> -GNU C                  4.8              gcc --version
> +GNU C                  4.9              gcc --version

Heh. The docs clearly weren't in sync before either.

Maybe we should add a

  Fixes: 5429ef62bcf3 ("compiler/gcc: Raise minimum GCC version for
kernel builds to 4.8")

to your patch too.

I only grepped for the obvious GCC_VERSION string. Which is presumably
what everybody else who has ever done this have also grepped for,
although in all fairness Will at least caught the one in
Documentation/process/changes.rst when he updated it last time.

                 Linus

Re: [PATCH] Documentation: update for gcc 4.9 requirement

[Randy Dunlap]

On 7/8/20 11:57 AM, Linus Torvalds wrote:
> On Wed, Jul 8, 2020 at 11:45 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> - - Make sure you have at least gcc 4.6 available.
>> + - Make sure you have at least gcc 4.9 available.
>> -GNU C                  4.8              gcc --version
>> +GNU C                  4.9              gcc --version
> 
> Heh. The docs clearly weren't in sync before either.
> 
> Maybe we should add a
> 
>   Fixes: 5429ef62bcf3 ("compiler/gcc: Raise minimum GCC version for
> kernel builds to 4.8")

uh, yes.
Should I resend it?

> to your patch too.
> 
> I only grepped for the obvious GCC_VERSION string. Which is presumably
> what everybody else who has ever done this have also grepped for,
> although in all fairness Will at least caught the one in
> Documentation/process/changes.rst when he updated it last time.


-- 
~Randy

Re: [PATCH] Documentation: update for gcc 4.9 requirement

[Linus Torvalds]

On Wed, Jul 8, 2020 at 12:04 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Should I resend it?

Nah. I'm just wondering if I should apply it directly or let it go through Jon.

                   Linus

Re: [PATCH] Documentation: update for gcc 4.9 requirement

[Jonathan Corbet]

On Wed, 8 Jul 2020 12:05:16 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Wed, Jul 8, 2020 at 12:04 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Should I resend it?  
> 
> Nah. I'm just wondering if I should apply it directly or let it go through Jon.

Either is fine with me; I can add the Fixes: tag.  If you want it in
5.8-rc, it's maybe best if you just take it directly; I don't have another
5.8 pull in the works at the moment.

jon

Re: [PATCH] Documentation: update for gcc 4.9 requirement

[Linus Torvalds]

On Wed, Jul 8, 2020 at 12:10 PM Jonathan Corbet <corbet@lwn.net> wrote:
>
> Either is fine with me; I can add the Fixes: tag.  If you want it in
> 5.8-rc, it's maybe best if you just take it directly; I don't have another
> 5.8 pull in the works at the moment.

I took that as an ack, and applied it.

                 Linus