* [PATCH] docs: filesystems: vfs: correct flag name
@ 2020-07-26 18:43 Julia Lawall
2020-07-27 1:49 ` Darrick J. Wong
2020-07-27 22:20 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2020-07-26 18:43 UTC (permalink / raw)
To: Jonathan Corbet, Darrick J . Wong
Cc: kernel-janitors, linux-doc, linux-kernel
There is no flag REMAP_CAN_SHORTEN. Commit eca3654e3cc7 ("vfs: enable
remap callers that can handle short operations") that introduces this
text also introduces the flag REMAP_FILE_CAN_SHORTEN. Change the name
in the documentation accordingly.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
Documentation/filesystems/vfs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
index da4b735..d08357d 100644
--- a/Documentation/filesystems/vfs.rst
+++ b/Documentation/filesystems/vfs.rst
@@ -1116,7 +1116,7 @@ otherwise noted.
before any bytes were remapped. The remap_flags parameter
accepts REMAP_FILE_* flags. If REMAP_FILE_DEDUP is set then the
implementation must only remap if the requested file ranges have
- identical contents. If REMAP_CAN_SHORTEN is set, the caller is
+ identical contents. If REMAP_FILE_CAN_SHORTEN is set, the caller is
ok with the implementation shortening the request length to
satisfy alignment or EOF requirements (or any other reason).
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] docs: filesystems: vfs: correct flag name
2020-07-26 18:43 [PATCH] docs: filesystems: vfs: correct flag name Julia Lawall
@ 2020-07-27 1:49 ` Darrick J. Wong
2020-07-27 22:20 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2020-07-27 1:49 UTC (permalink / raw)
To: Julia Lawall; +Cc: Jonathan Corbet, kernel-janitors, linux-doc, linux-kernel
On Sun, Jul 26, 2020 at 08:43:40PM +0200, Julia Lawall wrote:
> There is no flag REMAP_CAN_SHORTEN. Commit eca3654e3cc7 ("vfs: enable
> remap callers that can handle short operations") that introduces this
> text also introduces the flag REMAP_FILE_CAN_SHORTEN. Change the name
> in the documentation accordingly.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
D'oh. Good catch!
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> ---
> Documentation/filesystems/vfs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
> index da4b735..d08357d 100644
> --- a/Documentation/filesystems/vfs.rst
> +++ b/Documentation/filesystems/vfs.rst
> @@ -1116,7 +1116,7 @@ otherwise noted.
> before any bytes were remapped. The remap_flags parameter
> accepts REMAP_FILE_* flags. If REMAP_FILE_DEDUP is set then the
> implementation must only remap if the requested file ranges have
> - identical contents. If REMAP_CAN_SHORTEN is set, the caller is
> + identical contents. If REMAP_FILE_CAN_SHORTEN is set, the caller is
> ok with the implementation shortening the request length to
> satisfy alignment or EOF requirements (or any other reason).
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] docs: filesystems: vfs: correct flag name
2020-07-26 18:43 [PATCH] docs: filesystems: vfs: correct flag name Julia Lawall
2020-07-27 1:49 ` Darrick J. Wong
@ 2020-07-27 22:20 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2020-07-27 22:20 UTC (permalink / raw)
To: Julia Lawall; +Cc: Darrick J . Wong, kernel-janitors, linux-doc, linux-kernel
On Sun, 26 Jul 2020 20:43:40 +0200
Julia Lawall <Julia.Lawall@inria.fr> wrote:
> There is no flag REMAP_CAN_SHORTEN. Commit eca3654e3cc7 ("vfs: enable
> remap callers that can handle short operations") that introduces this
> text also introduces the flag REMAP_FILE_CAN_SHORTEN. Change the name
> in the documentation accordingly.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> Documentation/filesystems/vfs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
> index da4b735..d08357d 100644
> --- a/Documentation/filesystems/vfs.rst
> +++ b/Documentation/filesystems/vfs.rst
> @@ -1116,7 +1116,7 @@ otherwise noted.
> before any bytes were remapped. The remap_flags parameter
> accepts REMAP_FILE_* flags. If REMAP_FILE_DEDUP is set then the
> implementation must only remap if the requested file ranges have
> - identical contents. If REMAP_CAN_SHORTEN is set, the caller is
> + identical contents. If REMAP_FILE_CAN_SHORTEN is set, the caller is
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-27 22:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-26 18:43 [PATCH] docs: filesystems: vfs: correct flag name Julia Lawall
2020-07-27 1:49 ` Darrick J. Wong
2020-07-27 22:20 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox