* [PATCH] rcu-tasks: rectify kernel-doc for struct rcu_tasks
@ 2021-01-25 7:41 Lukas Bulwahn
2021-01-25 16:58 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2021-01-25 7:41 UTC (permalink / raw)
To: Paul E . McKenney, Josh Triplett, rcu
Cc: Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes,
Jonathan Corbet, Mauro Carvalho Chehab, linux-doc,
kernel-janitors, linux-kernel, Lukas Bulwahn
The command 'find ./kernel/rcu/ | xargs ./scripts/kernel-doc -none'
reported an issue with the kernel-doc of struct rcu_tasks.
Rectify the kernel-doc, such that no issues remain for ./kernel/rcu/.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
applies cleanly on v5.11-rc5 and next-20210122
Paul, please pick this minor kerneldoc cleanup.
kernel/rcu/tasks.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index af7c19439f4e..17c8ebe131af 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -20,7 +20,7 @@ typedef void (*holdouts_func_t)(struct list_head *hop, bool ndrpt, bool *frptp);
typedef void (*postgp_func_t)(struct rcu_tasks *rtp);
/**
- * Definition for a Tasks-RCU-like mechanism.
+ * struct rcu_tasks - Definition for a Tasks-RCU-like mechanism.
* @cbs_head: Head of callback list.
* @cbs_tail: Tail pointer for callback list.
* @cbs_wq: Wait queue allowning new callback to get kthread's attention.
@@ -38,7 +38,7 @@ typedef void (*postgp_func_t)(struct rcu_tasks *rtp);
* @pregp_func: This flavor's pre-grace-period function (optional).
* @pertask_func: This flavor's per-task scan function (optional).
* @postscan_func: This flavor's post-task scan function (optional).
- * @holdout_func: This flavor's holdout-list scan function (optional).
+ * @holdouts_func: This flavor's holdout-list scan function (optional).
* @postgp_func: This flavor's post-grace-period function (optional).
* @call_func: This flavor's call_rcu()-equivalent function.
* @name: This flavor's textual name.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rcu-tasks: rectify kernel-doc for struct rcu_tasks
2021-01-25 7:41 [PATCH] rcu-tasks: rectify kernel-doc for struct rcu_tasks Lukas Bulwahn
@ 2021-01-25 16:58 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2021-01-25 16:58 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Josh Triplett, rcu, Steven Rostedt, Mathieu Desnoyers,
Lai Jiangshan, Joel Fernandes, Jonathan Corbet,
Mauro Carvalho Chehab, linux-doc, kernel-janitors, linux-kernel
On Mon, Jan 25, 2021 at 08:41:05AM +0100, Lukas Bulwahn wrote:
> The command 'find ./kernel/rcu/ | xargs ./scripts/kernel-doc -none'
> reported an issue with the kernel-doc of struct rcu_tasks.
>
> Rectify the kernel-doc, such that no issues remain for ./kernel/rcu/.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Applied for the v5.13 merge window with the usual wordsmithing, thank you!
Thanx, Paul
> ---
> applies cleanly on v5.11-rc5 and next-20210122
>
> Paul, please pick this minor kerneldoc cleanup.
>
> kernel/rcu/tasks.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index af7c19439f4e..17c8ebe131af 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -20,7 +20,7 @@ typedef void (*holdouts_func_t)(struct list_head *hop, bool ndrpt, bool *frptp);
> typedef void (*postgp_func_t)(struct rcu_tasks *rtp);
>
> /**
> - * Definition for a Tasks-RCU-like mechanism.
> + * struct rcu_tasks - Definition for a Tasks-RCU-like mechanism.
> * @cbs_head: Head of callback list.
> * @cbs_tail: Tail pointer for callback list.
> * @cbs_wq: Wait queue allowning new callback to get kthread's attention.
> @@ -38,7 +38,7 @@ typedef void (*postgp_func_t)(struct rcu_tasks *rtp);
> * @pregp_func: This flavor's pre-grace-period function (optional).
> * @pertask_func: This flavor's per-task scan function (optional).
> * @postscan_func: This flavor's post-task scan function (optional).
> - * @holdout_func: This flavor's holdout-list scan function (optional).
> + * @holdouts_func: This flavor's holdout-list scan function (optional).
> * @postgp_func: This flavor's post-grace-period function (optional).
> * @call_func: This flavor's call_rcu()-equivalent function.
> * @name: This flavor's textual name.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-25 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-25 7:41 [PATCH] rcu-tasks: rectify kernel-doc for struct rcu_tasks Lukas Bulwahn
2021-01-25 16:58 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox