From: "Michal Koutný" <mkoutny@suse.com>
To: Waiman Long <longman@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>, Phil Auld <pauld@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v8 5/6] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst
Date: Wed, 1 Dec 2021 15:13:50 +0100 [thread overview]
Message-ID: <20211201141350.GA54766@blackbody.suse.cz> (raw)
In-Reply-To: <2347fe66-dc68-6d58-e63b-7ed2b8077b48@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Tue, Nov 30, 2021 at 10:56:34PM -0500, Waiman Long <longman@redhat.com> wrote:
> > > A valid parent partition may distribute out all its CPUs to
> > > its child partitions as long as it is not the root cgroup and
> > > there is no task associated with it.
> > A valid parent partition which isn't root never has tasks in them to begin
> > with.
> I believe there is some corner cases where it is possible to put task in an
> intermediate partition. That is why I put down this statement.
Just mind the threads -- cpuset controller is threaded and having tasks
in inner cgroup nodes is a real scenario. I wouldn't consider it a
corner case.
[ Actually, the paragraph could IMO be simplified:
> A valid parent partition may distribute out all its CPUs to
> its child partitions as long as there is no task associated with it.
Assuming there's always at least one kernel thread in the root cgroup
that can't be migrated anyway.]
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-12-01 14:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 14:36 [PATCH v8 0/6] cgroup/cpuset: Add new cpuset partition type & empty effecitve cpus Waiman Long
2021-10-18 14:36 ` [PATCH v8 1/6] cgroup/cpuset: Allow no-task partition to have empty cpuset.cpus.effective Waiman Long
2021-10-18 14:36 ` [PATCH v8 2/6] cgroup/cpuset: Refining features and constraints of a partition Waiman Long
2021-10-18 14:36 ` [PATCH v8 3/6] cgroup/cpuset: Add a new isolated cpus.partition type Waiman Long
2021-10-18 14:36 ` [PATCH v8 4/6] cgroup/cpuset: Show invalid partition reason string Waiman Long
2021-10-18 14:36 ` [PATCH v8 5/6] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst Waiman Long
2021-11-15 19:31 ` Michal Koutný
2021-11-15 20:11 ` Tejun Heo
2021-11-15 21:27 ` Waiman Long
2021-11-15 21:10 ` Waiman Long
2021-11-16 17:54 ` Michal Koutný
2021-11-30 15:35 ` Waiman Long
2021-11-30 17:11 ` Tejun Heo
2021-12-01 3:56 ` Waiman Long
2021-12-01 14:13 ` Michal Koutný [this message]
2021-12-01 14:56 ` Waiman Long
2021-12-01 16:39 ` Tejun Heo
2021-12-01 17:49 ` Waiman Long
2021-12-01 14:26 ` Waiman Long
2021-12-01 16:46 ` Tejun Heo
2021-12-01 18:05 ` Waiman Long
2021-12-02 1:28 ` Waiman Long
2021-12-03 18:25 ` Michal Koutný
2021-12-03 19:27 ` Waiman Long
2021-10-18 14:36 ` [PATCH v8 6/6] kselftest/cgroup: Add cpuset v2 partition root state test Waiman Long
2021-10-27 23:05 ` [PATCH v8 0/6] cgroup/cpuset: Add new cpuset partition type & empty effecitve cpus Waiman Long
2021-11-10 11:13 ` Felix Moessbauer
2021-11-10 13:21 ` Marcelo Tosatti
2021-11-10 13:56 ` Michal Koutný
2021-11-10 15:21 ` Moessbauer, Felix
2021-11-10 16:10 ` Marcelo Tosatti
2021-11-10 16:14 ` Marcelo Tosatti
2021-11-10 16:15 ` Jan Kiszka
2021-11-10 17:29 ` Marcelo Tosatti
2021-11-10 18:30 ` Waiman Long
2021-11-10 17:52 ` Michal Koutný
2021-11-10 18:04 ` Jan Kiszka
2021-11-10 18:15 ` Michal Koutný
2021-11-10 15:20 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201141350.GA54766@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=frederic@kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox