* [PATCH] Documentation: kbuild: fix typo in kconfig-language.rst
@ 2022-06-19 17:03 SangYuhiter
2022-06-19 17:06 ` Randy Dunlap
2022-06-19 19:12 ` Matthew Wilcox
0 siblings, 2 replies; 3+ messages in thread
From: SangYuhiter @ 2022-06-19 17:03 UTC (permalink / raw)
To: linux-kbuild; +Cc: masahiroy, linux-doc, SangYuhiter
change "default y/m" to "default y/n"
add " should be "default y" " in default section d)
Signed-off-by: SangYuhiter <sangyu.code@gmail.com>
---
Documentation/kbuild/kconfig-language.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/kbuild/kconfig-language.rst b/Documentation/kbuild/kconfig-language.rst
index a7173843a294..ae3add11d5e7 100644
--- a/Documentation/kbuild/kconfig-language.rst
+++ b/Documentation/kbuild/kconfig-language.rst
@@ -92,7 +92,7 @@ applicable everywhere (see syntax).
release to release.
Note:
- Things that merit "default y/m" include:
+ Things that merit "default y/n" include:
a) A new Kconfig option for something that used to always be built
should be "default y".
@@ -105,7 +105,7 @@ applicable everywhere (see syntax).
"default n". This allows you to provide sane defaults.
d) Hardware or infrastructure that everybody expects, such as CONFIG_NET
- or CONFIG_BLOCK. These are rare exceptions.
+ or CONFIG_BLOCK, should be "default y". These are rare exceptions.
- type definition + default value::
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: kbuild: fix typo in kconfig-language.rst
2022-06-19 17:03 [PATCH] Documentation: kbuild: fix typo in kconfig-language.rst SangYuhiter
@ 2022-06-19 17:06 ` Randy Dunlap
2022-06-19 19:12 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-06-19 17:06 UTC (permalink / raw)
To: SangYuhiter, linux-kbuild; +Cc: masahiroy, linux-doc
On 6/19/22 10:03, SangYuhiter wrote:
> change "default y/m" to "default y/n"
> add " should be "default y" " in default section d)
>
> Signed-off-by: SangYuhiter <sangyu.code@gmail.com>
> ---
> Documentation/kbuild/kconfig-language.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kbuild/kconfig-language.rst b/Documentation/kbuild/kconfig-language.rst
> index a7173843a294..ae3add11d5e7 100644
> --- a/Documentation/kbuild/kconfig-language.rst
> +++ b/Documentation/kbuild/kconfig-language.rst
> @@ -92,7 +92,7 @@ applicable everywhere (see syntax).
> release to release.
>
> Note:
> - Things that merit "default y/m" include:
> + Things that merit "default y/n" include:
"y/m" is correct here, so NAK.
>
> a) A new Kconfig option for something that used to always be built
> should be "default y".
> @@ -105,7 +105,7 @@ applicable everywhere (see syntax).
> "default n". This allows you to provide sane defaults.
>
> d) Hardware or infrastructure that everybody expects, such as CONFIG_NET
> - or CONFIG_BLOCK. These are rare exceptions.
> + or CONFIG_BLOCK, should be "default y". These are rare exceptions.
>
> - type definition + default value::
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: kbuild: fix typo in kconfig-language.rst
2022-06-19 17:03 [PATCH] Documentation: kbuild: fix typo in kconfig-language.rst SangYuhiter
2022-06-19 17:06 ` Randy Dunlap
@ 2022-06-19 19:12 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2022-06-19 19:12 UTC (permalink / raw)
To: SangYuhiter; +Cc: linux-kbuild, masahiroy, linux-doc
On Mon, Jun 20, 2022 at 01:03:37AM +0800, SangYuhiter wrote:
> Note:
> - Things that merit "default y/m" include:
> + Things that merit "default y/n" include:
This is incorrect. it's Y(es) or M(odule).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-19 19:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-19 17:03 [PATCH] Documentation: kbuild: fix typo in kconfig-language.rst SangYuhiter
2022-06-19 17:06 ` Randy Dunlap
2022-06-19 19:12 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox