[PATCH] sfc: fix builds without CONFIG_RTC

Linux Documentation
 help / color / mirror / Atom feed

* [PATCH] sfc: fix builds without CONFIG_RTC_LIB
@ 2023-02-17 10:22 alejandro.lucero-palau
  2023-02-17 14:47 ` Alexander Lobakin
  2023-02-17 15:13 ` Manank Patel
  0 siblings, 2 replies; 7+ messages in thread
From: alejandro.lucero-palau @ 2023-02-17 10:22 UTC (permalink / raw)
  To: netdev, linux-net-drivers
  Cc: davem, kuba, pabeni, edumazet, habetsm.xilinx, ecree.xilinx,
	linux-doc, corbet, jiri, Alejandro Lucero

From: Alejandro Lucero <alejandro.lucero-palau@amd.com>

Adding an embarrasing missing semicolon precluding kernel building
in ia64 configs.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com>
---
 drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
index d2eb6712ba35..3eb355fd4282 100644
--- a/drivers/net/ethernet/sfc/efx_devlink.c
+++ b/drivers/net/ethernet/sfc/efx_devlink.c
@@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
 				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
 		rtc_time64_to_tm(tstamp, &build_date);
 #else
-		memset(&build_date, 0, sizeof(build_date)
+		memset(&build_date, 0, sizeof(build_date);
 #endif
 		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] sfc: fix builds without CONFIG_RTC_LIB
  2023-02-17 10:22 [PATCH] sfc: fix builds without CONFIG_RTC_LIB alejandro.lucero-palau
@ 2023-02-17 14:47 ` Alexander Lobakin
  2023-02-17 15:20   ` Lucero Palau, Alejandro
  2023-02-17 15:13 ` Manank Patel
  1 sibling, 1 reply; 7+ messages in thread
From: Alexander Lobakin @ 2023-02-17 14:47 UTC (permalink / raw)
  To: alejandro.lucero-palau
  Cc: netdev, linux-net-drivers, davem, kuba, pabeni, edumazet,
	habetsm.xilinx, ecree.xilinx, linux-doc, corbet, jiri

From: Lucero Palau, Alejandro <alejandro.lucero-palau@amd.com>
Date: Fri, 17 Feb 2023 10:22:36 +0000

> From: Alejandro Lucero <alejandro.lucero-palau@amd.com>
> 
> Adding an embarrasing missing semicolon precluding kernel building

:D

'Embarrassing' tho, with two 's'. And I guess "embarrassingly missed",
since a semicolon itself can't be "embarrassing" I believe? :D

+ "add", not "adding"
+ "precluding"? You mean "breaking"?

> in ia64 configs.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com>
> ---
>  drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
> index d2eb6712ba35..3eb355fd4282 100644
> --- a/drivers/net/ethernet/sfc/efx_devlink.c
> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
>  				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
>  		rtc_time64_to_tm(tstamp, &build_date);
>  #else
> -		memset(&build_date, 0, sizeof(build_date)
> +		memset(&build_date, 0, sizeof(build_date);
>  #endif
>  		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>  

Thanks,
Olek

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] sfc: fix builds without CONFIG_RTC_LIB
  2023-02-17 14:47 ` Alexander Lobakin
@ 2023-02-17 15:20   ` Lucero Palau, Alejandro
  2023-02-17 15:30     ` Lucero Palau, Alejandro
  2023-02-23 15:29     ` Alexander Lobakin
  0 siblings, 2 replies; 7+ messages in thread
From: Lucero Palau, Alejandro @ 2023-02-17 15:20 UTC (permalink / raw)
  To: Alexander Lobakin, Lucero Palau, Alejandro
  Cc: netdev@vger.kernel.org, linux-net-drivers (AMD-Xilinx),
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	edumazet@google.com, habetsm.xilinx@gmail.com,
	ecree.xilinx@gmail.com, linux-doc@vger.kernel.org, corbet@lwn.net,
	jiri@nvidia.com


On 2/17/23 14:47, Alexander Lobakin wrote:
> From: Lucero Palau, Alejandro <alejandro.lucero-palau@amd.com>
> Date: Fri, 17 Feb 2023 10:22:36 +0000
>
>> From: Alejandro Lucero <alejandro.lucero-palau@amd.com>
>>
>> Adding an embarrasing missing semicolon precluding kernel building
> :D
>
> 'Embarrassing' tho, with two 's'. And I guess "embarrassingly missed",
> since a semicolon itself can't be "embarrassing" I believe? :D

This is going worse ... :D

I'll change it.

> + "add", not "adding"
> + "precluding"? You mean "breaking"?

Preclude: "prevent from happening; make impossible."

But I can use breaking instead.

Thanks!

>> in ia64 configs.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
>> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
>> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com>
>> ---
>>   drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
>> index d2eb6712ba35..3eb355fd4282 100644
>> --- a/drivers/net/ethernet/sfc/efx_devlink.c
>> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
>> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
>>   				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
>>   		rtc_time64_to_tm(tstamp, &build_date);
>>   #else
>> -		memset(&build_date, 0, sizeof(build_date)
>> +		memset(&build_date, 0, sizeof(build_date);
>>   #endif
>>   		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>>   
> Thanks,
> Olek

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] sfc: fix builds without CONFIG_RTC_LIB
  2023-02-17 15:20   ` Lucero Palau, Alejandro
@ 2023-02-17 15:30     ` Lucero Palau, Alejandro
  2023-02-17 16:46       ` Paolo Abeni
  2023-02-23 15:29     ` Alexander Lobakin
  1 sibling, 1 reply; 7+ messages in thread
From: Lucero Palau, Alejandro @ 2023-02-17 15:30 UTC (permalink / raw)
  To: Lucero Palau, Alejandro, Alexander Lobakin
  Cc: netdev@vger.kernel.org, linux-net-drivers (AMD-Xilinx),
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	edumazet@google.com, habetsm.xilinx@gmail.com,
	ecree.xilinx@gmail.com, linux-doc@vger.kernel.org, corbet@lwn.net,
	jiri@nvidia.com

BTW, I did not send the net-next tag what I'm not sure if it is required 
(I would say so).

Should I add it?

Thanks

On 2/17/23 15:20, Lucero Palau, Alejandro wrote:
> On 2/17/23 14:47, Alexander Lobakin wrote:
>> From: Lucero Palau, Alejandro <alejandro.lucero-palau@amd.com>
>> Date: Fri, 17 Feb 2023 10:22:36 +0000
>>
>>> From: Alejandro Lucero <alejandro.lucero-palau@amd.com>
>>>
>>> Adding an embarrasing missing semicolon precluding kernel building
>> :D
>>
>> 'Embarrassing' tho, with two 's'. And I guess "embarrassingly missed",
>> since a semicolon itself can't be "embarrassing" I believe? :D
> This is going worse ... :D
>
> I'll change it.
>
>> + "add", not "adding"
>> + "precluding"? You mean "breaking"?
> Preclude: "prevent from happening; make impossible."
>
> But I can use breaking instead.
>
> Thanks!
>
>>> in ia64 configs.
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
>>> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
>>> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com>
>>> ---
>>>    drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
>>> index d2eb6712ba35..3eb355fd4282 100644
>>> --- a/drivers/net/ethernet/sfc/efx_devlink.c
>>> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
>>> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
>>>    				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
>>>    		rtc_time64_to_tm(tstamp, &build_date);
>>>    #else
>>> -		memset(&build_date, 0, sizeof(build_date)
>>> +		memset(&build_date, 0, sizeof(build_date);
>>>    #endif
>>>    		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>>>    
>> Thanks,
>> Olek

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] sfc: fix builds without CONFIG_RTC_LIB
  2023-02-17 15:30     ` Lucero Palau, Alejandro
@ 2023-02-17 16:46       ` Paolo Abeni
  0 siblings, 0 replies; 7+ messages in thread
From: Paolo Abeni @ 2023-02-17 16:46 UTC (permalink / raw)
  To: Lucero Palau, Alejandro, Alexander Lobakin
  Cc: netdev@vger.kernel.org, linux-net-drivers (AMD-Xilinx),
	davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
	habetsm.xilinx@gmail.com, ecree.xilinx@gmail.com,
	linux-doc@vger.kernel.org, corbet@lwn.net, jiri@nvidia.com

On Fri, 2023-02-17 at 15:30 +0000, Lucero Palau, Alejandro wrote:
> BTW, I did not send the net-next tag what I'm not sure if it is required 
> (I would say so).
> 
> Should I add it?

Indeed is required and you should add it when you will post v2.

Thanks,

Paolo


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] sfc: fix builds without CONFIG_RTC_LIB
  2023-02-17 15:20   ` Lucero Palau, Alejandro
  2023-02-17 15:30     ` Lucero Palau, Alejandro
@ 2023-02-23 15:29     ` Alexander Lobakin
  1 sibling, 0 replies; 7+ messages in thread
From: Alexander Lobakin @ 2023-02-23 15:29 UTC (permalink / raw)
  To: Lucero Palau, Alejandro
  Cc: netdev@vger.kernel.org, linux-net-drivers (AMD-Xilinx),
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	edumazet@google.com, habetsm.xilinx@gmail.com,
	ecree.xilinx@gmail.com, linux-doc@vger.kernel.org, corbet@lwn.net,
	jiri@nvidia.com

From: Lucero Palau, Alejandro <alejandro.lucero-palau@amd.com>
Date: Fri, 17 Feb 2023 15:20:27 +0000

> 
> On 2/17/23 14:47, Alexander Lobakin wrote:
>> From: Lucero Palau, Alejandro <alejandro.lucero-palau@amd.com>
>> Date: Fri, 17 Feb 2023 10:22:36 +0000
>>
>>> From: Alejandro Lucero <alejandro.lucero-palau@amd.com>
>>>
>>> Adding an embarrasing missing semicolon precluding kernel building
>> :D
>>
>> 'Embarrassing' tho, with two 's'. And I guess "embarrassingly missed",
>> since a semicolon itself can't be "embarrassing" I believe? :D
> 
> This is going worse ... :D
> 
> I'll change it.
> 
>> + "add", not "adding"
>> + "precluding"? You mean "breaking"?
> 
> Preclude: "prevent from happening; make impossible."

Now I'm embarrassed xD You can leave it as it is, it's my dictionary's
fault :D

> 
> But I can use breaking instead.
> 
> Thanks!
Thanks,
Olek

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] sfc: fix builds without CONFIG_RTC_LIB
  2023-02-17 10:22 [PATCH] sfc: fix builds without CONFIG_RTC_LIB alejandro.lucero-palau
  2023-02-17 14:47 ` Alexander Lobakin
@ 2023-02-17 15:13 ` Manank Patel
  1 sibling, 0 replies; 7+ messages in thread
From: Manank Patel @ 2023-02-17 15:13 UTC (permalink / raw)
  To: alejandro.lucero-palau
  Cc: netdev, linux-net-drivers, davem, kuba, pabeni, edumazet,
	habetsm.xilinx, ecree.xilinx, linux-doc, corbet, jiri

On 17/02/23 10:22AM, alejandro.lucero-palau@amd.com wrote:
> From: Alejandro Lucero <alejandro.lucero-palau@amd.com>
> 
> Adding an embarrasing missing semicolon precluding kernel building
> in ia64 configs.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com>
> ---
>  drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
> index d2eb6712ba35..3eb355fd4282 100644
> --- a/drivers/net/ethernet/sfc/efx_devlink.c
> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
>  				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
>  		rtc_time64_to_tm(tstamp, &build_date);
>  #else
> -		memset(&build_date, 0, sizeof(build_date)
> +		memset(&build_date, 0, sizeof(build_date);
                                                ^
                                It looks like there's a missing closing
                                parenthesis here.
>  #endif
>  		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>  
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-02-23 15:30 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-17 10:22 [PATCH] sfc: fix builds without CONFIG_RTC_LIB alejandro.lucero-palau
2023-02-17 14:47 ` Alexander Lobakin
2023-02-17 15:20   ` Lucero Palau, Alejandro
2023-02-17 15:30     ` Lucero Palau, Alejandro
2023-02-17 16:46       ` Paolo Abeni
2023-02-23 15:29     ` Alexander Lobakin
2023-02-17 15:13 ` Manank Patel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox