* [PATCH] docs: admin-guide: sysctl: fix details of struct dentry_stat_t
@ 2023-09-23 19:51 Randy Dunlap
2023-09-25 12:50 ` Christian Brauner
2023-10-03 15:28 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-09-23 19:51 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Jonathan Corbet, linux-doc, Alexander Viro,
Christian Brauner, linux-fsdevel, Luis Chamberlain, Arnd Bergmann,
Glauber Costa
Commit c8c0c239d5ab moved struct dentry_stat_t to fs/dcache.c but
did not update its location in Documentation, so update that now.
Also change each struct member from int to long as done in
commit 3942c07ccf98.
Fixes: c8c0c239d5ab ("fs: move dcache sysctls to its own file")
Fixes: 3942c07ccf98 ("fs: bump inode and dentry counters to long")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Glauber Costa <glommer@openvz.org>
---
Documentation/admin-guide/sysctl/fs.rst | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff -- a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst
--- a/Documentation/admin-guide/sysctl/fs.rst
+++ b/Documentation/admin-guide/sysctl/fs.rst
@@ -42,16 +42,16 @@ pre-allocation or re-sizing of any kerne
dentry-state
------------
-This file shows the values in ``struct dentry_stat``, as defined in
-``linux/include/linux/dcache.h``::
+This file shows the values in ``struct dentry_stat_t``, as defined in
+``fs/dcache.c``::
struct dentry_stat_t dentry_stat {
- int nr_dentry;
- int nr_unused;
- int age_limit; /* age in seconds */
- int want_pages; /* pages requested by system */
- int nr_negative; /* # of unused negative dentries */
- int dummy; /* Reserved for future use */
+ long nr_dentry;
+ long nr_unused;
+ long age_limit; /* age in seconds */
+ long want_pages; /* pages requested by system */
+ long nr_negative; /* # of unused negative dentries */
+ long dummy; /* Reserved for future use */
};
Dentries are dynamically allocated and deallocated.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] docs: admin-guide: sysctl: fix details of struct dentry_stat_t
2023-09-23 19:51 [PATCH] docs: admin-guide: sysctl: fix details of struct dentry_stat_t Randy Dunlap
@ 2023-09-25 12:50 ` Christian Brauner
2023-10-03 15:28 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2023-09-25 12:50 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Jonathan Corbet, linux-doc, Alexander Viro,
linux-fsdevel, Luis Chamberlain, Arnd Bergmann, Glauber Costa
On Sat, Sep 23, 2023 at 12:51:44PM -0700, Randy Dunlap wrote:
> Commit c8c0c239d5ab moved struct dentry_stat_t to fs/dcache.c but
> did not update its location in Documentation, so update that now.
> Also change each struct member from int to long as done in
> commit 3942c07ccf98.
>
> Fixes: c8c0c239d5ab ("fs: move dcache sysctls to its own file")
> Fixes: 3942c07ccf98 ("fs: bump inode and dentry counters to long")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Glauber Costa <glommer@openvz.org>
> ---
Acked-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] docs: admin-guide: sysctl: fix details of struct dentry_stat_t
2023-09-23 19:51 [PATCH] docs: admin-guide: sysctl: fix details of struct dentry_stat_t Randy Dunlap
2023-09-25 12:50 ` Christian Brauner
@ 2023-10-03 15:28 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2023-10-03 15:28 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Randy Dunlap, linux-doc, Alexander Viro, Christian Brauner,
linux-fsdevel, Luis Chamberlain, Arnd Bergmann, Glauber Costa
Randy Dunlap <rdunlap@infradead.org> writes:
> Commit c8c0c239d5ab moved struct dentry_stat_t to fs/dcache.c but
> did not update its location in Documentation, so update that now.
> Also change each struct member from int to long as done in
> commit 3942c07ccf98.
>
> Fixes: c8c0c239d5ab ("fs: move dcache sysctls to its own file")
> Fixes: 3942c07ccf98 ("fs: bump inode and dentry counters to long")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Glauber Costa <glommer@openvz.org>
> ---
> Documentation/admin-guide/sysctl/fs.rst | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff -- a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst
> --- a/Documentation/admin-guide/sysctl/fs.rst
> +++ b/Documentation/admin-guide/sysctl/fs.rst
> @@ -42,16 +42,16 @@ pre-allocation or re-sizing of any kerne
> dentry-state
> ------------
>
> -This file shows the values in ``struct dentry_stat``, as defined in
> -``linux/include/linux/dcache.h``::
> +This file shows the values in ``struct dentry_stat_t``, as defined in
> +``fs/dcache.c``::
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-03 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-23 19:51 [PATCH] docs: admin-guide: sysctl: fix details of struct dentry_stat_t Randy Dunlap
2023-09-25 12:50 ` Christian Brauner
2023-10-03 15:28 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox