From: Conor Dooley <conor@kernel.org>
To: "Clément Léger" <cleger@rivosinc.com>
Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Palmer Dabbelt <palmer@rivosinc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Jones <ajones@ventanamicro.com>,
Evan Green <evan@rivosinc.com>
Subject: Re: [PATCH v1 01/13] riscv: fatorize hwprobe ISA extension reporting
Date: Thu, 12 Oct 2023 14:53:43 +0100 [thread overview]
Message-ID: <20231012-matriarch-lunar-819c1d2d7996@spud> (raw)
In-Reply-To: <20231011111438.909552-2-cleger@rivosinc.com>
[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]
Drew,
On Wed, Oct 11, 2023 at 01:14:26PM +0200, Clément Léger wrote:
> Factorize ISA extension reporting by using a macro rather than
> copy/pasting extension names. This will allow adding new extensions more
> easily.
>
> Signed-off-by: Clément Léger <cleger@rivosinc.com>
> ---
> arch/riscv/kernel/sys_riscv.c | 26 ++++++++++++--------------
> 1 file changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
> index 473159b5f303..5ce593ce07a4 100644
> --- a/arch/riscv/kernel/sys_riscv.c
> +++ b/arch/riscv/kernel/sys_riscv.c
> @@ -145,20 +145,18 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe *pair,
> for_each_cpu(cpu, cpus) {
We were gonna add a comment here about when it is and is not safe to use
riscv_isa_extension_available() IIRC. Did that ever end up in a patch?
> struct riscv_isainfo *isainfo = &hart_isa[cpu];
>
> - if (riscv_isa_extension_available(isainfo->isa, ZBA))
> - pair->value |= RISCV_HWPROBE_EXT_ZBA;
> - else
> - missing |= RISCV_HWPROBE_EXT_ZBA;
> -
> - if (riscv_isa_extension_available(isainfo->isa, ZBB))
> - pair->value |= RISCV_HWPROBE_EXT_ZBB;
> - else
> - missing |= RISCV_HWPROBE_EXT_ZBB;
> -
> - if (riscv_isa_extension_available(isainfo->isa, ZBS))
> - pair->value |= RISCV_HWPROBE_EXT_ZBS;
> - else
> - missing |= RISCV_HWPROBE_EXT_ZBS;
> +#define CHECK_ISA_EXT(__ext) \
> + do { \
> + if (riscv_isa_extension_available(isainfo->isa, __ext)) \
> + pair->value |= RISCV_HWPROBE_EXT_##__ext; \
> + else \
> + missing |= RISCV_HWPROBE_EXT_##__ext; \
> + } while (false) \
> +
> + CHECK_ISA_EXT(ZBA);
> + CHECK_ISA_EXT(ZBB);
> + CHECK_ISA_EXT(ZBS);
> +#undef CHECK_ISA_EXT
> }
>
> /* Now turn off reporting features if any CPU is missing it. */
> --
> 2.42.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-12 13:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 11:14 [PATCH v1 00/13] riscv: report more ISA extensions through hwprobe Clément Léger
2023-10-11 11:14 ` [PATCH v1 01/13] riscv: fatorize hwprobe ISA extension reporting Clément Léger
2023-10-11 11:37 ` Robert P. J. Day
2023-10-12 13:53 ` Conor Dooley [this message]
2023-10-12 16:32 ` Andrew Jones
2023-10-11 11:14 ` [PATCH v1 02/13] riscv: add ISA extension probing for Zv* extensions Clément Léger
2023-10-12 13:17 ` Clément Léger
2023-10-12 14:10 ` Conor Dooley
2023-10-12 15:15 ` Clément Léger
2023-10-12 16:29 ` Conor Dooley
2023-10-11 11:14 ` [PATCH v1 03/13] riscv: hwprobe: export Zv* ISA extensions Clément Léger
2023-10-11 11:14 ` [PATCH v1 04/13] dt-bindings: riscv: add Zv* ratified crypto ISA extensions description Clément Léger
2023-10-12 13:47 ` Conor Dooley
2023-10-11 11:14 ` [PATCH v1 05/13] riscv: add ISA extension probing for Zfh/Zfhmin Clément Léger
2023-10-11 11:14 ` [PATCH v1 06/13] riscv: hwprobe: export Zfh/Zfhmin ISA extensions Clément Léger
2023-10-11 11:14 ` [PATCH v1 07/13] dt-bindings: riscv: add Zfh/Zfhmin ISA extensions description Clément Léger
2023-10-12 13:49 ` Conor Dooley
2023-10-11 11:14 ` [PATCH v1 08/13] riscv: add ISA extension probing for Zihintntl Clément Léger
2023-10-11 11:14 ` [PATCH v1 09/13] riscv: hwprobe: export Zhintntl ISA extension Clément Léger
2023-10-11 11:14 ` [PATCH v1 10/13] dt-bindings: riscv: add Zihintntl ISA extension description Clément Léger
2023-10-12 13:50 ` Conor Dooley
2023-10-12 13:58 ` Clément Léger
2023-10-11 11:14 ` [PATCH v1 11/13] riscv: add ISA extension probing for Zvfh[min] Clément Léger
2023-10-11 11:14 ` [PATCH v1 12/13] riscv: hwprobe: export Zvfh[min] ISA extensions Clément Léger
2023-10-11 11:14 ` [PATCH v1 13/13] dt-bindings: riscv: add Zvfh[min] ISA extension description Clément Léger
2023-10-12 13:51 ` Conor Dooley
2023-10-12 7:15 ` [PATCH v1 00/13] riscv: report more ISA extensions through hwprobe Clément Léger
2023-10-12 8:21 ` Conor Dooley
2023-10-12 8:25 ` Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012-matriarch-lunar-819c1d2d7996@spud \
--to=conor@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=cleger@rivosinc.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=evan@rivosinc.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox