Linux Documentation
 help / color / mirror / Atom feed
From: "Clément Léger" <cleger@rivosinc.com>
To: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Cc: "Clément Léger" <cleger@rivosinc.com>,
	"Palmer Dabbelt" <palmer@rivosinc.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Evan Green" <evan@rivosinc.com>,
	"Conor Dooley" <conor@kernel.org>,
	"Samuel Ortiz" <sameo@rivosinc.com>
Subject: [PATCH v2 01/19] riscv: hwprobe: factorize hwprobe ISA extension reporting
Date: Tue, 17 Oct 2023 15:14:38 +0200	[thread overview]
Message-ID: <20231017131456.2053396-2-cleger@rivosinc.com> (raw)
In-Reply-To: <20231017131456.2053396-1-cleger@rivosinc.com>

Factorize ISA extension reporting by using a macro rather than
copy/pasting extension names. This will allow adding new extensions more
easily.

Signed-off-by: Clément Léger <cleger@rivosinc.com>
---
 arch/riscv/kernel/sys_riscv.c | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
index 473159b5f303..e207874e686e 100644
--- a/arch/riscv/kernel/sys_riscv.c
+++ b/arch/riscv/kernel/sys_riscv.c
@@ -145,20 +145,24 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe *pair,
 	for_each_cpu(cpu, cpus) {
 		struct riscv_isainfo *isainfo = &hart_isa[cpu];
 
-		if (riscv_isa_extension_available(isainfo->isa, ZBA))
-			pair->value |= RISCV_HWPROBE_EXT_ZBA;
-		else
-			missing |= RISCV_HWPROBE_EXT_ZBA;
-
-		if (riscv_isa_extension_available(isainfo->isa, ZBB))
-			pair->value |= RISCV_HWPROBE_EXT_ZBB;
-		else
-			missing |= RISCV_HWPROBE_EXT_ZBB;
-
-		if (riscv_isa_extension_available(isainfo->isa, ZBS))
-			pair->value |= RISCV_HWPROBE_EXT_ZBS;
-		else
-			missing |= RISCV_HWPROBE_EXT_ZBS;
+#define CHECK_ISA_EXT(__ext)							\
+		do {								\
+			if (riscv_isa_extension_available(isainfo->isa, __ext))	\
+				pair->value |= RISCV_HWPROBE_EXT_##__ext;	\
+			else							\
+				missing |= RISCV_HWPROBE_EXT_##__ext;		\
+		} while (false)
+
+		/*
+		 * Only use CHECK_ISA_EXT() for extensions which can be exposed
+		 * to userspace, regardless of the kernel's configuration, as no
+		 * other checks, besides presence in the hart_isa bitmap, are
+		 * made.
+		 */
+		CHECK_ISA_EXT(ZBA);
+		CHECK_ISA_EXT(ZBB);
+		CHECK_ISA_EXT(ZBS);
+#undef CHECK_ISA_EXT
 	}
 
 	/* Now turn off reporting features if any CPU is missing it. */
-- 
2.42.0


  reply	other threads:[~2023-10-17 13:15 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 13:14 [PATCH v2 00/19] riscv: report more ISA extensions through hwprobe Clément Léger
2023-10-17 13:14 ` Clément Léger [this message]
2023-10-18 17:24   ` [PATCH v2 01/19] riscv: hwprobe: factorize hwprobe ISA extension reporting Evan Green
2023-10-18 17:33     ` Conor Dooley
2023-10-18 17:36       ` Conor Dooley
2023-10-18 17:45         ` Evan Green
2023-10-19  9:46           ` Clément Léger
2023-10-19 10:24             ` Conor Dooley
2023-10-19 15:58               ` Evan Green
2023-10-19  7:26         ` Clément Léger
2023-10-19 10:22           ` Conor Dooley
2023-10-19 12:29             ` Clément Léger
2023-10-20 10:27             ` Andrew Jones
2023-10-17 13:14 ` [PATCH v2 02/19] riscv: add ISA extension parsing for scalar crypto Clément Léger
2023-10-23 16:21   ` Evan Green
2023-10-24  7:18     ` Clément Léger
2023-10-24  9:30       ` Clément Léger
2023-10-24 16:37         ` Evan Green
2023-10-24 18:11           ` Clément Léger
2023-10-17 13:14 ` [PATCH v2 03/19] riscv: hwprobe: add support for scalar crypto ISA extensions Clément Léger
2023-10-18 17:24   ` Evan Green
2023-10-19  7:21     ` Clément Léger
2023-10-17 13:14 ` [PATCH v2 04/19] dt-bindings: riscv: add scalar crypto ISA extensions description Clément Léger
2023-10-17 13:14 ` [PATCH v2 05/19] riscv: add ISA extension parsing for vector crypto extensions Clément Léger
2023-10-18  1:45   ` Jerry Shih
2023-10-18 12:52     ` Clément Léger
2023-10-18 17:26       ` Evan Green
2023-10-19  9:35         ` Clément Léger
2023-10-19 15:33           ` Conor Dooley
2023-10-19 16:19             ` Evan Green
2023-10-23  7:24               ` Clément Léger
2023-10-23 16:18                 ` Evan Green
2023-10-20  2:43           ` Jerry Shih
2023-10-23  7:14             ` Clément Léger
2023-10-17 13:14 ` [PATCH v2 06/19] riscv: hwprobe: export vector crypto ISA extensions Clément Léger
2023-10-18 17:27   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 07/19] dt-bindings: riscv: add vector crypto ISA extensions description Clément Léger
2023-10-17 13:14 ` [PATCH v2 08/19] riscv: add ISA extension parsing for Zfh/Zfhmin Clément Léger
2023-10-18 17:28   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 09/19] riscv: hwprobe: export Zfh/Zfhmin ISA extensions Clément Léger
2023-10-18 17:28   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 10/19] dt-bindings: riscv: add Zfh[min] ISA extensions description Clément Léger
2023-10-17 13:14 ` [PATCH v2 11/19] riscv: add ISA extension parsing for Zihintntl Clément Léger
2023-10-18 17:28   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 12/19] riscv: hwprobe: export Zhintntl ISA extension Clément Léger
2023-10-18 17:28   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 13/19] dt-bindings: riscv: add Zihintntl ISA extension description Clément Léger
2023-10-17 13:14 ` [PATCH v2 14/19] riscv: add ISA extension parsing for Zvfh[min] Clément Léger
2023-10-18 17:28   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 15/19] riscv: hwprobe: export Zvfh[min] ISA extensions Clément Léger
2023-10-18 17:28   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 16/19] dt-bindings: riscv: add Zvfh[min] ISA extension description Clément Léger
2023-10-17 13:14 ` [PATCH v2 17/19] riscv: add ISA extension parsing for Zfa Clément Léger
2023-10-18 17:28   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 18/19] riscv: hwprobe: export Zfa ISA extension Clément Léger
2023-10-18 17:28   ` Evan Green
2023-10-17 13:14 ` [PATCH v2 19/19] dt-bindings: riscv: add Zfa ISA extension description Clément Léger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231017131456.2053396-2-cleger@rivosinc.com \
    --to=cleger@rivosinc.com \
    --cc=ajones@ventanamicro.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=evan@rivosinc.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@rivosinc.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox