From: Qais Yousef <qyousef@layalina.io>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, corbet@lwn.net, alexs@kernel.org,
siyanteng@loongson.cn, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, lukasz.luba@arm.com,
hongyan.xia2@arm.com, yizhou.tang@shopee.com
Subject: Re: [PATCH v2 2/2] sched/fair: Simplify util_est
Date: Sat, 2 Dec 2023 23:38:12 +0000 [thread overview]
Message-ID: <20231202233812.cq2nodia3estdexy@airbuntu> (raw)
In-Reply-To: <20231201161652.1241695-3-vincent.guittot@linaro.org>
On 12/01/23 17:16, Vincent Guittot wrote:
> /*
> * The load/runnable/util_avg accumulates an infinite geometric series
> * (see __update_load_avg_cfs_rq() in kernel/sched/pelt.c).
> @@ -505,9 +469,20 @@ struct sched_avg {
> unsigned long load_avg;
> unsigned long runnable_avg;
> unsigned long util_avg;
> - struct util_est util_est;
> + unsigned int util_est;
> } ____cacheline_aligned;
unsigned long would be better?
next prev parent reply other threads:[~2023-12-02 23:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 16:16 [PATCH v2 0/2] Simplify Util_est Vincent Guittot
2023-12-01 16:16 ` [PATCH v2 1/2] sched/fair: Remove SCHED_FEAT(UTIL_EST_FASTUP, true) Vincent Guittot
2023-12-02 2:41 ` Yanteng Si
2023-12-07 3:44 ` Alex Shi
2023-12-01 16:16 ` [PATCH v2 2/2] sched/fair: Simplify util_est Vincent Guittot
2023-12-02 23:38 ` Qais Yousef [this message]
2023-12-04 9:54 ` Vincent Guittot
2023-12-07 3:46 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231202233812.cq2nodia3estdexy@airbuntu \
--to=qyousef@layalina.io \
--cc=alexs@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=hongyan.xia2@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=siyanteng@loongson.cn \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yizhou.tang@shopee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox