From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
james.morse@arm.com, fenghua.yu@intel.com, babu.moger@amd.com,
bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, hpa@zytor.com,
peternewman@google.com, x86@kernel.org,
linux-kernel@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 0/2] x86/resctrl: Track llc_occupancy of RMIDs in limbo list
Date: Mon, 8 Apr 2024 11:29:26 -0400 [thread overview]
Message-ID: <20240408-stalwart-tomato-sloth-bddbae@lemur> (raw)
In-Reply-To: <ca45f32d-b526-4bcd-b177-08698babaf3d@shopee.com>
On Mon, Apr 08, 2024 at 03:44:00PM +0800, Haifeng Xu wrote:
> I can also reproduced it. After digging into it, I found that our DKIM signature header
> has 't' and 'x' flags. They are recommended as a means to help identify spam.
>
> t= is the DKIM signature timestamp.
> x= is the DKIM signature expiration time.
>
> The source code of DKIM Validation can be seen in dkim/__init__.py(line 351), I paste it
> here.
>
> 343 if b'x' in sig:
> 344 if re.match(br"\d+$", sig[b'x']) is None:
> 345 raise ValidationError(
> 346 "x= value is not a decimal integer (%s)" % sig[b'x'])
> 347 x_sign = int(sig[b'x'])
> 348 now = int(time.time())
> 349 slop = 36000 # 10H leeway for mailers with inaccurate clocks
> 350 if x_sign < now - slop:
> 351 raise ValidationError(
> 352 "x= value is past (%s)" % sig[b'x'])
> 353 if x_sign < t_sign:
> 354 raise ValidationError(
> 355 "x= value is less than t= value (x=%s t=%s)" %
> 356 (sig[b'x'], sig[b't']))
>
> The expiry time is less than the time point you download the patch, so the validation
> fails. If I comment out these lines, this series can be successfully downloaded.
FWIW, I've requested ability to ignore the x= flag when validating signatures:
https://bugs.launchpad.net/dkimpy/+bug/2047054
-K
next prev parent reply other threads:[~2024-04-08 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 8:30 [PATCH v6 0/2] x86/resctrl: Track llc_occupancy of RMIDs in limbo list Haifeng Xu
2024-03-19 8:30 ` [PATCH v6 1/2] x86/resctrl: Rename pseudo_lock_event.h to trace.h Haifeng Xu
2024-03-19 8:30 ` [PATCH v6 2/2] x86/resctrl: Add tracepoint for llc_occupancy tracking Haifeng Xu
2024-03-29 23:06 ` [PATCH v6 0/2] x86/resctrl: Track llc_occupancy of RMIDs in limbo list Reinette Chatre
2024-04-08 7:44 ` Haifeng Xu
2024-04-08 15:29 ` Konstantin Ryabitsev [this message]
2024-04-08 15:58 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408-stalwart-tomato-sloth-bddbae@lemur \
--to=konstantin@linuxfoundation.org \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=haifeng.xu@shopee.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox