* Re: linux-next: build warnings after merge of the mm tree [not found] <20240701184912.01f1f9ce@canb.auug.org.au> @ 2024-07-02 3:14 ` Andrew Morton 2024-07-02 4:15 ` Jiaqi Yan 0 siblings, 1 reply; 15+ messages in thread From: Andrew Morton @ 2024-07-02 3:14 UTC (permalink / raw) To: Stephen Rothwell Cc: Jiaqi Yan, Linux Kernel Mailing List, Linux Next Mailing List, linux-doc On Mon, 1 Jul 2024 18:49:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi all, > > After merging the mm tree, today's linux-next build (htmldocs) produced > these warnings: > > Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation. > Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote ends without a blank line; unexpected unindent. > > Introduced by commit > > 2cba7831f62c ("docs: mm: add enable_soft_offline sysctl") Well that's annoying. @@ -267,6 +268,37 @@ used:: These are informational only. They do not mean that anything is wrong with your system. To disable them, echo 4 (bit 2) into drop_caches. +enable_soft_offline +=================== +Correctable memory errors are very common on servers. Soft-offline is kernel's +solution for memory pages having (excessive) corrected memory errors. + +For different types of page, soft-offline has different behaviors / costs. +- For a raw error page, soft-offline migrates the in-use page's content to + a new raw page. +- For a page that is part of a transparent hugepage, soft-offline splits the + transparent hugepage into raw pages, then migrates only the raw error page. + As a result, user is transparently backed by 1 less hugepage, impacting + memory access performance. +- For a page that is part of a HugeTLB hugepage, soft-offline first migrates + the entire HugeTLB hugepage, during which a free hugepage will be consumed + as migration target. Then the original hugepage is dissolved into raw + pages without compensation, reducing the capacity of the HugeTLB pool by 1. + + ... This seems a reasonable thing to do so there's probably some way in which to do it, but a bit of grepping failed to turn up examples in existing .rst files. Can someone please suggest? ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-07-02 3:14 ` linux-next: build warnings after merge of the mm tree Andrew Morton @ 2024-07-02 4:15 ` Jiaqi Yan 2024-07-02 4:33 ` Jiaqi Yan 0 siblings, 1 reply; 15+ messages in thread From: Jiaqi Yan @ 2024-07-02 4:15 UTC (permalink / raw) To: Andrew Morton Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List, linux-doc On Mon, Jul 1, 2024 at 8:15 PM Andrew Morton <akpm@linux-foundation.org> wrote: > > On Mon, 1 Jul 2024 18:49:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > Hi all, > > > > After merging the mm tree, today's linux-next build (htmldocs) produced > > these warnings: > > > > Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation. > > Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote ends without a blank line; unexpected unindent. > > > > Introduced by commit > > > > 2cba7831f62c ("docs: mm: add enable_soft_offline sysctl") > > Well that's annoying. > > @@ -267,6 +268,37 @@ used:: > These are informational only. They do not mean that anything is wrong > with your system. To disable them, echo 4 (bit 2) into drop_caches. > > +enable_soft_offline > +=================== > +Correctable memory errors are very common on servers. Soft-offline is kernel's > +solution for memory pages having (excessive) corrected memory errors. > + > +For different types of page, soft-offline has different behaviors / costs. > +- For a raw error page, soft-offline migrates the in-use page's content to > + a new raw page. > +- For a page that is part of a transparent hugepage, soft-offline splits the > + transparent hugepage into raw pages, then migrates only the raw error page. > + As a result, user is transparently backed by 1 less hugepage, impacting > + memory access performance. > +- For a page that is part of a HugeTLB hugepage, soft-offline first migrates > + the entire HugeTLB hugepage, during which a free hugepage will be consumed > + as migration target. Then the original hugepage is dissolved into raw > + pages without compensation, reducing the capacity of the HugeTLB pool by 1. > + > + ... > > This seems a reasonable thing to do so there's probably some way in > which to do it, but a bit of grepping failed to turn up examples in > existing .rst files. Can someone please suggest? It seems I need to add some blank lines according to [1], especially to add a blank line above the first list item: diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst index 75e22137d849..74b4c0f65213 100644 --- a/Documentation/admin-guide/sysctl/vm.rst +++ b/Documentation/admin-guide/sysctl/vm.rst @@ -274,12 +274,15 @@ Correctable memory errors are very common on servers. Soft-offline is kernel's solution for memory pages having (excessive) corrected memory errors. For different types of page, soft-offline has different behaviors / costs. + - For a raw error page, soft-offline migrates the in-use page's content to a new raw page. + - For a page that is part of a transparent hugepage, soft-offline splits the transparent hugepage into raw pages, then migrates only the raw error page. As a result, user is transparently backed by 1 less hugepage, impacting memory access performance. + - For a page that is part of a HugeTLB hugepage, soft-offline first migrates the entire HugeTLB hugepage, during which a free hugepage will be consumed as migration target. Then the original hugepage is dissolved into raw But I am having trouble testing the build, so wasn't able to validate the change above: Documentation$ make /tools/net/ynl/ynl-gen-rst.py -o /Documentation/networking/netlink_spec/index.rst -x make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory make: *** [Makefile:113: /Documentation/networking/netlink_spec/index.rst] Error 127 [1] https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#bullet-lists ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-07-02 4:15 ` Jiaqi Yan @ 2024-07-02 4:33 ` Jiaqi Yan 2024-07-02 6:18 ` Andrew Morton 0 siblings, 1 reply; 15+ messages in thread From: Jiaqi Yan @ 2024-07-02 4:33 UTC (permalink / raw) To: Andrew Morton, Stephen Rothwell Cc: Linux Kernel Mailing List, Linux Next Mailing List, linux-doc On Mon, Jul 1, 2024 at 9:15 PM Jiaqi Yan <jiaqiyan@google.com> wrote: > > On Mon, Jul 1, 2024 at 8:15 PM Andrew Morton <akpm@linux-foundation.org> wrote: > > > > On Mon, 1 Jul 2024 18:49:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > Hi all, > > > > > > After merging the mm tree, today's linux-next build (htmldocs) produced > > > these warnings: > > > > > > Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation. > > > Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote ends without a blank line; unexpected unindent. > > > > > > Introduced by commit > > > > > > 2cba7831f62c ("docs: mm: add enable_soft_offline sysctl") > > > > Well that's annoying. > > > > @@ -267,6 +268,37 @@ used:: > > These are informational only. They do not mean that anything is wrong > > with your system. To disable them, echo 4 (bit 2) into drop_caches. > > > > +enable_soft_offline > > +=================== > > +Correctable memory errors are very common on servers. Soft-offline is kernel's > > +solution for memory pages having (excessive) corrected memory errors. > > + > > +For different types of page, soft-offline has different behaviors / costs. > > +- For a raw error page, soft-offline migrates the in-use page's content to > > + a new raw page. > > +- For a page that is part of a transparent hugepage, soft-offline splits the > > + transparent hugepage into raw pages, then migrates only the raw error page. > > + As a result, user is transparently backed by 1 less hugepage, impacting > > + memory access performance. > > +- For a page that is part of a HugeTLB hugepage, soft-offline first migrates > > + the entire HugeTLB hugepage, during which a free hugepage will be consumed > > + as migration target. Then the original hugepage is dissolved into raw > > + pages without compensation, reducing the capacity of the HugeTLB pool by 1. > > + > > + ... > > > > This seems a reasonable thing to do so there's probably some way in > > which to do it, but a bit of grepping failed to turn up examples in > > existing .rst files. Can someone please suggest? > > It seems I need to add some blank lines according to [1], especially > to add a blank line above the first list item: > > diff --git a/Documentation/admin-guide/sysctl/vm.rst > b/Documentation/admin-guide/sysctl/vm.rst > index 75e22137d849..74b4c0f65213 100644 > --- a/Documentation/admin-guide/sysctl/vm.rst > +++ b/Documentation/admin-guide/sysctl/vm.rst > @@ -274,12 +274,15 @@ Correctable memory errors are very common on > servers. Soft-offline is kernel's > solution for memory pages having (excessive) corrected memory errors. > > For different types of page, soft-offline has different behaviors / costs. > + > - For a raw error page, soft-offline migrates the in-use page's content to > a new raw page. > + > - For a page that is part of a transparent hugepage, soft-offline splits the > transparent hugepage into raw pages, then migrates only the raw error page. > As a result, user is transparently backed by 1 less hugepage, impacting > memory access performance. > + > - For a page that is part of a HugeTLB hugepage, soft-offline first migrates > the entire HugeTLB hugepage, during which a free hugepage will be consumed > as migration target. Then the original hugepage is dissolved into raw > > But I am having trouble testing the build, so wasn't able to validate > the change above: > > Documentation$ make > /tools/net/ynl/ynl-gen-rst.py -o > /Documentation/networking/netlink_spec/index.rst -x > make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory > make: *** [Makefile:113: > /Documentation/networking/netlink_spec/index.rst] Error 127 I tried another way: make htmldocs at repo's root directory. Although I wasn't able to finish the make process, - without the blank lines: Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation. Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote ends without a blank line; unexpected unindent. - with the blank lines added, the ERROR and WARNING in vm/rst are gone. Andrew and Stephen, what is the best way to post the fix for this? Should I send out a v8 of the patch with the blank lines added? or a standalone commit for this fix? > > [1] https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#bullet-lists ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-07-02 4:33 ` Jiaqi Yan @ 2024-07-02 6:18 ` Andrew Morton 2024-07-02 6:37 ` Jiaqi Yan 0 siblings, 1 reply; 15+ messages in thread From: Andrew Morton @ 2024-07-02 6:18 UTC (permalink / raw) To: Jiaqi Yan Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List, linux-doc On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote: > > > This seems a reasonable thing to do so there's probably some way in > > > which to do it, but a bit of grepping failed to turn up examples in > > > existing .rst files. Can someone please suggest? > > > > It seems I need to add some blank lines according to [1], especially > > to add a blank line above the first list item: > > > > diff --git a/Documentation/admin-guide/sysctl/vm.rst > > b/Documentation/admin-guide/sysctl/vm.rst > > index 75e22137d849..74b4c0f65213 100644 > > --- a/Documentation/admin-guide/sysctl/vm.rst > > +++ b/Documentation/admin-guide/sysctl/vm.rst > > @@ -274,12 +274,15 @@ Correctable memory errors are very common on > > servers. Soft-offline is kernel's > > solution for memory pages having (excessive) corrected memory errors. > > > > For different types of page, soft-offline has different behaviors / costs. > > + > > - For a raw error page, soft-offline migrates the in-use page's content to > > a new raw page. > > + > > - For a page that is part of a transparent hugepage, soft-offline splits the > > transparent hugepage into raw pages, then migrates only the raw error page. > > As a result, user is transparently backed by 1 less hugepage, impacting > > memory access performance. > > + > > - For a page that is part of a HugeTLB hugepage, soft-offline first migrates > > the entire HugeTLB hugepage, during which a free hugepage will be consumed > > as migration target. Then the original hugepage is dissolved into raw > > > > But I am having trouble testing the build, so wasn't able to validate > > the change above: > > > > Documentation$ make > > /tools/net/ynl/ynl-gen-rst.py -o > > /Documentation/networking/netlink_spec/index.rst -x > > make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory > > make: *** [Makefile:113: > > /Documentation/networking/netlink_spec/index.rst] Error 127 You need to install all sorts of whacky system and python packages. The (failed) build process should guide you through this. > I tried another way: make htmldocs at repo's root directory. Although > I wasn't able to finish the make process, > > - without the blank lines: > > Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation. > Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote > ends without a blank line; unexpected unindent. > > - with the blank lines added, the ERROR and WARNING in vm/rst are gone. > > Andrew and Stephen, what is the best way to post the fix for this? > Should I send out a v8 of the patch with the blank lines added? or a > standalone commit for this fix? I added your fix, thanks. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-07-02 6:18 ` Andrew Morton @ 2024-07-02 6:37 ` Jiaqi Yan 2024-07-02 23:09 ` SeongJae Park 0 siblings, 1 reply; 15+ messages in thread From: Jiaqi Yan @ 2024-07-02 6:37 UTC (permalink / raw) To: Andrew Morton Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List, linux-doc On Mon, Jul 1, 2024 at 11:18 PM Andrew Morton <akpm@linux-foundation.org> wrote: > > On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote: > > > > > This seems a reasonable thing to do so there's probably some way in > > > > which to do it, but a bit of grepping failed to turn up examples in > > > > existing .rst files. Can someone please suggest? > > > > > > It seems I need to add some blank lines according to [1], especially > > > to add a blank line above the first list item: > > > > > > diff --git a/Documentation/admin-guide/sysctl/vm.rst > > > b/Documentation/admin-guide/sysctl/vm.rst > > > index 75e22137d849..74b4c0f65213 100644 > > > --- a/Documentation/admin-guide/sysctl/vm.rst > > > +++ b/Documentation/admin-guide/sysctl/vm.rst > > > @@ -274,12 +274,15 @@ Correctable memory errors are very common on > > > servers. Soft-offline is kernel's > > > solution for memory pages having (excessive) corrected memory errors. > > > > > > For different types of page, soft-offline has different behaviors / costs. > > > + > > > - For a raw error page, soft-offline migrates the in-use page's content to > > > a new raw page. > > > + > > > - For a page that is part of a transparent hugepage, soft-offline splits the > > > transparent hugepage into raw pages, then migrates only the raw error page. > > > As a result, user is transparently backed by 1 less hugepage, impacting > > > memory access performance. > > > + > > > - For a page that is part of a HugeTLB hugepage, soft-offline first migrates > > > the entire HugeTLB hugepage, during which a free hugepage will be consumed > > > as migration target. Then the original hugepage is dissolved into raw > > > > > > But I am having trouble testing the build, so wasn't able to validate > > > the change above: > > > > > > Documentation$ make > > > /tools/net/ynl/ynl-gen-rst.py -o > > > /Documentation/networking/netlink_spec/index.rst -x > > > make: /tools/net/ynl/ynl-gen-rst.py: No such file or directory > > > make: *** [Makefile:113: > > > /Documentation/networking/netlink_spec/index.rst] Error 127 > > You need to install all sorts of whacky system and python packages. > The (failed) build process should guide you through this. > > > I tried another way: make htmldocs at repo's root directory. Although > > I wasn't able to finish the make process, > > > > - without the blank lines: > > > > Documentation/admin-guide/sysctl/vm.rst:278: ERROR: Unexpected indentation. > > Documentation/admin-guide/sysctl/vm.rst:279: WARNING: Block quote > > ends without a blank line; unexpected unindent. > > > > - with the blank lines added, the ERROR and WARNING in vm/rst are gone. > > > > Andrew and Stephen, what is the best way to post the fix for this? > > Should I send out a v8 of the patch with the blank lines added? or a > > standalone commit for this fix? > > I added your fix, thanks. Ah, sorry Andrew, I should sent out this diff, as there are more blank lines needed: diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst index 75e22137d849..f48eaa98d22d 100644 --- a/Documentation/admin-guide/sysctl/vm.rst +++ b/Documentation/admin-guide/sysctl/vm.rst @@ -274,12 +274,15 @@ Correctable memory errors are very common on servers. Soft-offline is kernel's solution for memory pages having (excessive) corrected memory errors. For different types of page, soft-offline has different behaviors / costs. + - For a raw error page, soft-offline migrates the in-use page's content to a new raw page. + - For a page that is part of a transparent hugepage, soft-offline splits the transparent hugepage into raw pages, then migrates only the raw error page. As a result, user is transparently backed by 1 less hugepage, impacting memory access performance. + - For a page that is part of a HugeTLB hugepage, soft-offline first migrates the entire HugeTLB hugepage, during which a free hugepage will be consumed as migration target. Then the original hugepage is dissolved into raw @@ -296,8 +299,11 @@ the request to soft offline the pages. Its default value is 1. It is worth mentioning that after setting enable_soft_offline to 0, the following requests to soft offline pages will not be performed: + - Request to soft offline pages from RAS Correctable Errors Collector. + - On ARM, the request to soft offline pages from GHES driver. + - On PARISC, the request to soft offline pages from Page Deallocation Table. extfrag_threshold ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-07-02 6:37 ` Jiaqi Yan @ 2024-07-02 23:09 ` SeongJae Park 2024-07-02 23:55 ` Jiaqi Yan 0 siblings, 1 reply; 15+ messages in thread From: SeongJae Park @ 2024-07-02 23:09 UTC (permalink / raw) To: Jiaqi Yan Cc: SeongJae Park, Andrew Morton, Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List, linux-doc Hello Jiaqi, On Mon, 1 Jul 2024 23:37:55 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote: > On Mon, Jul 1, 2024 at 11:18 PM Andrew Morton <akpm@linux-foundation.org> wrote: > > > > On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote: > > > > > > > This seems a reasonable thing to do so there's probably some way in > > > > > which to do it, but a bit of grepping failed to turn up examples in > > > > > existing .rst files. Can someone please suggest? > > > > > > > > It seems I need to add some blank lines according to [1], especially > > > > to add a blank line above the first list item: According to my understanding and testing on my machine, it seems we need blank lines only before and after the blocks. [...] > > Ah, sorry Andrew, I should sent out this diff, as there are more blank > lines needed: > > diff --git a/Documentation/admin-guide/sysctl/vm.rst > b/Documentation/admin-guide/sysctl/vm.rst > index 75e22137d849..f48eaa98d22d 100644 > --- a/Documentation/admin-guide/sysctl/vm.rst > +++ b/Documentation/admin-guide/sysctl/vm.rst > @@ -274,12 +274,15 @@ Correctable memory errors are very common on > servers. Soft-offline is kernel's > solution for memory pages having (excessive) corrected memory errors. > > For different types of page, soft-offline has different behaviors / costs. > + So, this was needed to make 'make htmldocs' quiet on my machine. > - For a raw error page, soft-offline migrates the in-use page's content to > a new raw page. > + > - For a page that is part of a transparent hugepage, soft-offline splits the > transparent hugepage into raw pages, then migrates only the raw error page. > As a result, user is transparently backed by 1 less hugepage, impacting > memory access performance. > + But above two blank lines were not really needed to make 'make htmldocs' calm, at least on my setup. Many other documents also don't have this kind of blank line. > - For a page that is part of a HugeTLB hugepage, soft-offline first migrates > the entire HugeTLB hugepage, during which a free hugepage will be consumed > as migration target. Then the original hugepage is dissolved into raw > @@ -296,8 +299,11 @@ the request to soft offline the pages. Its > default value is 1. > > It is worth mentioning that after setting enable_soft_offline to 0, the > following requests to soft offline pages will not be performed: > + Interestingly, 'make htmldocs' didn't complain even if I don't put this blank line. But for consistency (see the beginning of sysctl/vm.rst), I think having this would be good. > - Request to soft offline pages from RAS Correctable Errors Collector. > + > - On ARM, the request to soft offline pages from GHES driver. > + Again, same to the reason above, it seems above two blank lines are not really needed. > - On PARISC, the request to soft offline pages from Page Deallocation Table. > > extfrag_threshold > I have no strong opinion about these, though. Having four more blank lines that might unnecessary is obviously no problem. Thanks, SJ ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-07-02 23:09 ` SeongJae Park @ 2024-07-02 23:55 ` Jiaqi Yan 0 siblings, 0 replies; 15+ messages in thread From: Jiaqi Yan @ 2024-07-02 23:55 UTC (permalink / raw) To: SeongJae Park Cc: Andrew Morton, Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List, linux-doc On Tue, Jul 2, 2024 at 4:10 PM SeongJae Park <sj@kernel.org> wrote: > > Hello Jiaqi, > > > On Mon, 1 Jul 2024 23:37:55 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote: > > > On Mon, Jul 1, 2024 at 11:18 PM Andrew Morton <akpm@linux-foundation.org> wrote: > > > > > > On Mon, 1 Jul 2024 21:33:20 -0700 Jiaqi Yan <jiaqiyan@google.com> wrote: > > > > > > > > > This seems a reasonable thing to do so there's probably some way in > > > > > > which to do it, but a bit of grepping failed to turn up examples in > > > > > > existing .rst files. Can someone please suggest? > > > > > > > > > > It seems I need to add some blank lines according to [1], especially > > > > > to add a blank line above the first list item: > > According to my understanding and testing on my machine, it seems we need blank > lines only before and after the blocks. Yes, as stated in [1], "The blank line above the first list item is required; blank lines between list items (such as below this paragraph) are optional." > > [...] > > > > Ah, sorry Andrew, I should sent out this diff, as there are more blank > > lines needed: > > > > diff --git a/Documentation/admin-guide/sysctl/vm.rst > > b/Documentation/admin-guide/sysctl/vm.rst > > index 75e22137d849..f48eaa98d22d 100644 > > --- a/Documentation/admin-guide/sysctl/vm.rst > > +++ b/Documentation/admin-guide/sysctl/vm.rst > > @@ -274,12 +274,15 @@ Correctable memory errors are very common on > > servers. Soft-offline is kernel's > > solution for memory pages having (excessive) corrected memory errors. > > > > For different types of page, soft-offline has different behaviors / costs. > > + > > So, this was needed to make 'make htmldocs' quiet on my machine. Absolutely. > > > - For a raw error page, soft-offline migrates the in-use page's content to > > a new raw page. > > + > > - For a page that is part of a transparent hugepage, soft-offline splits the > > transparent hugepage into raw pages, then migrates only the raw error page. > > As a result, user is transparently backed by 1 less hugepage, impacting > > memory access performance. > > + > > But above two blank lines were not really needed to make 'make htmldocs' calm, > at least on my setup. Many other documents also don't have this kind of blank > line. Yes, they are optional. > > > - For a page that is part of a HugeTLB hugepage, soft-offline first migrates > > the entire HugeTLB hugepage, during which a free hugepage will be consumed > > as migration target. Then the original hugepage is dissolved into raw > > @@ -296,8 +299,11 @@ the request to soft offline the pages. Its > > default value is 1. > > > > It is worth mentioning that after setting enable_soft_offline to 0, the > > following requests to soft offline pages will not be performed: > > + > > Interestingly, 'make htmldocs' didn't complain even if I don't put this blank In fact, without this blank line, even though make htmldocs doesn't throw ERROR or WARNING, the output html file is broken: there is no bullet point for the list items below. > line. But for consistency (see the beginning of sysctl/vm.rst), I think having > this would be good. Agreed. > > > - Request to soft offline pages from RAS Correctable Errors Collector. > > + > > - On ARM, the request to soft offline pages from GHES driver. > > + > > Again, same to the reason above, it seems above two blank lines are not really > needed. Yep, optional again. I mainly just want to be consistent. > > > - On PARISC, the request to soft offline pages from Page Deallocation Table. > > > > extfrag_threshold > > > > I have no strong opinion about these, though. Having four more blank lines > that might unnecessary is obviously no problem. > > > Thanks, > SJ ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20240325123603.1bdd6588@canb.auug.org.au>]
[parent not found: <CAJuCfpH4Ee00hM9+B7=mi5Dwjrhov8vUK-KwPuoO3wsD7iJSAQ@mail.gmail.com>]
* Re: linux-next: build warnings after merge of the mm tree [not found] ` <CAJuCfpH4Ee00hM9+B7=mi5Dwjrhov8vUK-KwPuoO3wsD7iJSAQ@mail.gmail.com> @ 2024-03-26 5:44 ` Randy Dunlap 2024-03-26 6:16 ` Suren Baghdasaryan 0 siblings, 1 reply; 15+ messages in thread From: Randy Dunlap @ 2024-03-26 5:44 UTC (permalink / raw) To: Suren Baghdasaryan, Stephen Rothwell, Linux Doc Mailing List, Jonathan Corbet Cc: Andrew Morton, Kent Overstreet, Linux Kernel Mailing List, Linux Next Mailing List On 3/25/24 19:19, Suren Baghdasaryan wrote: > On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> >> Hi all, >> >> After merging the mm tree, today's linux-next build (htmldocs) produced >> these warnings: >> >> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead >> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead >> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead >> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead >> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc' >> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc' >> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc' >> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc' >> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc' >> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc' >> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead >> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead >> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead >> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead >> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead >> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead >> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead >> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof' >> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof' >> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead >> >> Introduced by commits >> >> c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends") >> ea7b8933f21b ("mempool: hook up to memory allocation profiling") >> 576477564ede ("mm: vmalloc: enable memory allocation profiling") >> >> from the mm-unstable branch of the mm tree. > > Thanks for the report, Stephen! > Let us check with Randy Dunlap how we should handle these. I assume we > still want documentation to document kmalloc(), not kmalloc_noprof(). > Maybe there is a way to mute these warnings. A proposed patch is here: https://lore.kernel.org/lkml/20240326054149.2121-1-rdunlap@infradead.org/T/#u -- #Randy ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-03-26 5:44 ` Randy Dunlap @ 2024-03-26 6:16 ` Suren Baghdasaryan 2024-03-28 4:39 ` Stephen Rothwell 0 siblings, 1 reply; 15+ messages in thread From: Suren Baghdasaryan @ 2024-03-26 6:16 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, Linux Doc Mailing List, Jonathan Corbet, Andrew Morton, Kent Overstreet, Linux Kernel Mailing List, Linux Next Mailing List On Mon, Mar 25, 2024 at 10:44 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > > > On 3/25/24 19:19, Suren Baghdasaryan wrote: > > On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > >> > >> Hi all, > >> > >> After merging the mm tree, today's linux-next build (htmldocs) produced > >> these warnings: > >> > >> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead > >> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead > >> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead > >> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead > >> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc' > >> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc' > >> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc' > >> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc' > >> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc' > >> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc' > >> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead > >> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead > >> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead > >> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead > >> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead > >> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead > >> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead > >> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof' > >> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof' > >> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead > >> > >> Introduced by commits > >> > >> c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends") > >> ea7b8933f21b ("mempool: hook up to memory allocation profiling") > >> 576477564ede ("mm: vmalloc: enable memory allocation profiling") > >> > >> from the mm-unstable branch of the mm tree. > > > > Thanks for the report, Stephen! > > Let us check with Randy Dunlap how we should handle these. I assume we > > still want documentation to document kmalloc(), not kmalloc_noprof(). > > Maybe there is a way to mute these warnings. > > A proposed patch is here: > https://lore.kernel.org/lkml/20240326054149.2121-1-rdunlap@infradead.org/T/#u Thanks! I'll change back all the instances in the documentation where we replaced original names with _noprof versions. > > > -- > #Randy ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-03-26 6:16 ` Suren Baghdasaryan @ 2024-03-28 4:39 ` Stephen Rothwell 2024-03-28 4:44 ` Stephen Rothwell 0 siblings, 1 reply; 15+ messages in thread From: Stephen Rothwell @ 2024-03-28 4:39 UTC (permalink / raw) To: Suren Baghdasaryan Cc: Randy Dunlap, Linux Doc Mailing List, Jonathan Corbet, Andrew Morton, Kent Overstreet, Linux Kernel Mailing List, Linux Next Mailing List [-- Attachment #1: Type: text/plain, Size: 9103 bytes --] Hi all, On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <surenb@google.com> wrote: > > Thanks! I'll change back all the instances in the documentation where > we replaced original names with _noprof versions. I now have the following: mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured comments found drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured comments found drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1: warning: no structured comments found drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'read_mpcc_state' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'mpc_init_single_inst' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpcc_for_dpp_from_secondary' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpcc_for_dpp' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'wait_for_idle' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'assert_mpcc_idle_before_connect' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'init_mpcc_list_from_hw' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_denorm' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_denorm_clamp' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_output_csc' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_ocsc_default' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_output_gamma' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'power_on_mpc_mem_pwr' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_dwb_mux' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'disable_dwb_mux' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'is_dwb_idle' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_out_rate_control' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_gamut_remap' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_1dlut' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_shaper' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'acquire_rmu' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_3dlut' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'release_rmu' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpc_out_mux' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_bg_color' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_mpc_mem_lp_mode' not described in 'mpc_funcs' drivers/gpu/drm/amd/display/dc/inc/hw/opp.h:1: warning: no structured comments found drivers/gpu/drm/amd/display/dc/inc/hw/opp.h:1: warning: no structured comments found drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_dio.h:1: warning: no structured comments found drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_dio.h:1: warning: no structured comments found drivers/slimbus/stream.c:49: warning: Excess struct member 'segdist_codes' description in 'segdist_code' include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc' include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc' include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc' include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc' include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc' include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc' mm/slub.c:3969: warning: expecting prototype for kmem_cache_alloc_node_noprof(). Prototype was for kmem_cache_alloc_node() instead mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead mm/vmalloc.c:3722: warning: expecting prototype for __vmalloc_node_range_noprof(). Prototype was for __vmalloc_node_range() instead mm/vmalloc.c:3867: warning: expecting prototype for __vmalloc_node_noprof(). Prototype was for __vmalloc_node() instead mm/vmalloc.c:3940: warning: expecting prototype for vzalloc_noprof(). Prototype was for vzalloc() instead mm/vmalloc.c:3978: warning: expecting prototype for vmalloc_node_noprof(). Prototype was for vmalloc_node() instead mm/vmalloc.c:3996: warning: expecting prototype for vzalloc_node_noprof(). Prototype was for vzalloc_node() instead mm/vmalloc.c:4024: warning: expecting prototype for vmalloc_32_noprof(). Prototype was for vmalloc_32() instead mm/vmalloc.c:4040: warning: expecting prototype for vmalloc_32_user_noprof(). Prototype was for vmalloc_32_user() instead mm/mempool.c:383: warning: expecting prototype for mempool_alloc_noprof(). Prototype was for mempool_alloc() instead mm/page_alloc.c:4991: warning: expecting prototype for alloc_pages_exact_noprof(). Prototype was for alloc_pages_exact() instead mm/page_alloc.c:5016: warning: expecting prototype for alloc_pages_exact_nid_noprof(). Prototype was for alloc_pages_exact_nid() instead mm/page_alloc.c:6463: warning: expecting prototype for alloc_contig_range_noprof(). Prototype was for alloc_contig_range() instead mm/page_alloc.c:6627: warning: expecting prototype for alloc_contig_pages_noprof(). Prototype was for alloc_contig_pages() instead mm/mempolicy.c:2223: warning: expecting prototype for alloc_pages_mpol_noprof(). Prototype was for alloc_pages_mpol() instead mm/mempolicy.c:2298: warning: expecting prototype for vma_alloc_folio_noprof(). Prototype was for vma_alloc_folio() instead mm/mempolicy.c:2326: warning: expecting prototype for alloc_pages_noprof(). Prototype was for alloc_pages() instead mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead mm/percpu.c:1745: warning: expecting prototype for pcpu_alloc_noprof(). Prototype was for pcpu_alloc() instead -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-03-28 4:39 ` Stephen Rothwell @ 2024-03-28 4:44 ` Stephen Rothwell 2024-03-28 5:35 ` Suren Baghdasaryan 0 siblings, 1 reply; 15+ messages in thread From: Stephen Rothwell @ 2024-03-28 4:44 UTC (permalink / raw) To: Suren Baghdasaryan Cc: Randy Dunlap, Linux Doc Mailing List, Jonathan Corbet, Andrew Morton, Kent Overstreet, Linux Kernel Mailing List, Linux Next Mailing List [-- Attachment #1: Type: text/plain, Size: 456 bytes --] Hi all, On Thu, 28 Mar 2024 15:39:47 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <surenb@google.com> wrote: > > > > Thanks! I'll change back all the instances in the documentation where > > we replaced original names with _noprof versions. > > I now have the following: Sorry, some of those are not relevant here, just the _noprof stuff. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-03-28 4:44 ` Stephen Rothwell @ 2024-03-28 5:35 ` Suren Baghdasaryan 2024-03-29 22:49 ` Stephen Rothwell 0 siblings, 1 reply; 15+ messages in thread From: Suren Baghdasaryan @ 2024-03-28 5:35 UTC (permalink / raw) To: Stephen Rothwell Cc: Randy Dunlap, Linux Doc Mailing List, Jonathan Corbet, Andrew Morton, Kent Overstreet, Linux Kernel Mailing List, Linux Next Mailing List On Wed, Mar 27, 2024 at 9:44 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi all, > > On Thu, 28 Mar 2024 15:39:47 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <surenb@google.com> wrote: > > > > > > Thanks! I'll change back all the instances in the documentation where > > > we replaced original names with _noprof versions. > > > > I now have the following: > > Sorry, some of those are not relevant here, just the _noprof stuff. https://lore.kernel.org/all/20240327044649.9199-1-rdunlap@infradead.org/ which seems to not yet been pulled into mm-unstable should fix the following warnings: include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc' include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc' include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc' include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc' include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc' include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc' And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradead.org/ should handle the _noprof warnings. I can see this patch in mm-unstable and running "make htmldocs" in mm-unstable does not show the _noprof warnings anymore. Please let me know if I should try some other command to reproduce these. Thanks, Suren. > > -- > Cheers, > Stephen Rothwell ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-03-28 5:35 ` Suren Baghdasaryan @ 2024-03-29 22:49 ` Stephen Rothwell 2024-03-29 23:01 ` Suren Baghdasaryan 0 siblings, 1 reply; 15+ messages in thread From: Stephen Rothwell @ 2024-03-29 22:49 UTC (permalink / raw) To: Suren Baghdasaryan Cc: Randy Dunlap, Linux Doc Mailing List, Jonathan Corbet, Andrew Morton, Kent Overstreet, Linux Kernel Mailing List, Linux Next Mailing List [-- Attachment #1: Type: text/plain, Size: 1370 bytes --] Hi Suren, On Wed, 27 Mar 2024 22:35:56 -0700 Suren Baghdasaryan <surenb@google.com> wrote: > > https://lore.kernel.org/all/20240327044649.9199-1-rdunlap@infradead.org/ > which seems to not yet been pulled into mm-unstable should fix the > following warnings: > > include/linux/slab.h:730: warning: Function parameter or struct member > '_n' not described in 'kcalloc' > include/linux/slab.h:730: warning: Function parameter or struct member > '_size' not described in 'kcalloc' > include/linux/slab.h:730: warning: Function parameter or struct member > '_flags' not described in 'kcalloc' > include/linux/slab.h:730: warning: Excess function parameter 'n' > description in 'kcalloc' > include/linux/slab.h:730: warning: Excess function parameter 'size' > description in 'kcalloc' > include/linux/slab.h:730: warning: Excess function parameter 'flags' > description in 'kcalloc' > > And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradead.org/ > should handle the _noprof warnings. I can see this patch in > mm-unstable and running "make htmldocs" in mm-unstable does not show > the _noprof warnings anymore. Please let me know if I should try some > other command to reproduce these. Those patches entered the mm tree after I had merge it on Thursday. It should all be good on Tuesday. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-03-29 22:49 ` Stephen Rothwell @ 2024-03-29 23:01 ` Suren Baghdasaryan 2024-03-29 23:01 ` Suren Baghdasaryan 0 siblings, 1 reply; 15+ messages in thread From: Suren Baghdasaryan @ 2024-03-29 23:01 UTC (permalink / raw) To: Stephen Rothwell Cc: Randy Dunlap, Linux Doc Mailing List, Jonathan Corbet, Andrew Morton, Kent Overstreet, Linux Kernel Mailing List, Linux Next Mailing List On Fri, Mar 29, 2024 at 3:49 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi Suren, > > On Wed, 27 Mar 2024 22:35:56 -0700 Suren Baghdasaryan <surenb@google.com> wrote: > > > > https://lore.kernel.org/all/20240327044649.9199-1-rdunlap@infradead.org/ > > which seems to not yet been pulled into mm-unstable should fix the > > following warnings: > > > > include/linux/slab.h:730: warning: Function parameter or struct member > > '_n' not described in 'kcalloc' > > include/linux/slab.h:730: warning: Function parameter or struct member > > '_size' not described in 'kcalloc' > > include/linux/slab.h:730: warning: Function parameter or struct member > > '_flags' not described in 'kcalloc' > > include/linux/slab.h:730: warning: Excess function parameter 'n' > > description in 'kcalloc' > > include/linux/slab.h:730: warning: Excess function parameter 'size' > > description in 'kcalloc' > > include/linux/slab.h:730: warning: Excess function parameter 'flags' > > description in 'kcalloc' > > > > And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradead.org/ > > should handle the _noprof warnings. I can see this patch in > > mm-unstable and running "make htmldocs" in mm-unstable does not show > > the _noprof warnings anymore. Please let me know if I should try some > > other command to reproduce these. > > Those patches entered the mm tree after I had merge it on Thursday. It > should all be good on Tuesday. Perfect. I'll ignore similar reports with _noprof prototype warnings until then. Thank you! > > -- > Cheers, > Stephen Rothwell ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warnings after merge of the mm tree 2024-03-29 23:01 ` Suren Baghdasaryan @ 2024-03-29 23:01 ` Suren Baghdasaryan 0 siblings, 0 replies; 15+ messages in thread From: Suren Baghdasaryan @ 2024-03-29 23:01 UTC (permalink / raw) To: Stephen Rothwell Cc: Randy Dunlap, Linux Doc Mailing List, Jonathan Corbet, Andrew Morton, Kent Overstreet, Linux Kernel Mailing List, Linux Next Mailing List On Fri, Mar 29, 2024 at 3:49 PM Stephen Rothwell <sfr@canb.auug.orgau> wrote: > > Hi Suren, > > On Wed, 27 Mar 2024 22:35:56 -0700 Suren Baghdasaryan <surenb@google.com> wrote: > > > > https://lore.kernel.org/all/20240327044649.9199-1-rdunlap@infradead.org/ > > which seems to not yet been pulled into mm-unstable should fix the > > following warnings: > > > > include/linux/slab.h:730: warning: Function parameter or struct member > > '_n' not described in 'kcalloc' > > include/linux/slab.h:730: warning: Function parameter or struct member > > '_size' not described in 'kcalloc' > > include/linux/slab.h:730: warning: Function parameter or struct member > > '_flags' not described in 'kcalloc' > > include/linux/slab.h:730: warning: Excess function parameter 'n' > > description in 'kcalloc' > > include/linux/slab.h:730: warning: Excess function parameter 'size' > > description in 'kcalloc' > > include/linux/slab.h:730: warning: Excess function parameter 'flags' > > description in 'kcalloc' > > > > And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradeadorg/ > > should handle the _noprof warnings. I can see this patch in > > mm-unstable and running "make htmldocs" in mm-unstable does not show > > the _noprof warnings anymore. Please let me know if I should try some > > other command to reproduce these. > > Those patches entered the mm tree after I had merge it on Thursday. It > should all be good on Tuesday. Perfect. I'll ignore similar reports with _noprof prototype warnings until then. Thank you! > > -- > Cheers, > Stephen Rothwell ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2024-07-02 23:55 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240701184912.01f1f9ce@canb.auug.org.au>
2024-07-02 3:14 ` linux-next: build warnings after merge of the mm tree Andrew Morton
2024-07-02 4:15 ` Jiaqi Yan
2024-07-02 4:33 ` Jiaqi Yan
2024-07-02 6:18 ` Andrew Morton
2024-07-02 6:37 ` Jiaqi Yan
2024-07-02 23:09 ` SeongJae Park
2024-07-02 23:55 ` Jiaqi Yan
[not found] <20240325123603.1bdd6588@canb.auug.org.au>
[not found] ` <CAJuCfpH4Ee00hM9+B7=mi5Dwjrhov8vUK-KwPuoO3wsD7iJSAQ@mail.gmail.com>
2024-03-26 5:44 ` Randy Dunlap
2024-03-26 6:16 ` Suren Baghdasaryan
2024-03-28 4:39 ` Stephen Rothwell
2024-03-28 4:44 ` Stephen Rothwell
2024-03-28 5:35 ` Suren Baghdasaryan
2024-03-29 22:49 ` Stephen Rothwell
2024-03-29 23:01 ` Suren Baghdasaryan
2024-03-29 23:01 ` Suren Baghdasaryan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox