From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] doc: iio: ad4695: document buffered read
Date: Sat, 10 Aug 2024 10:36:30 +0100 [thread overview]
Message-ID: <20240810103630.0fbe8610@jic23-huawei> (raw)
In-Reply-To: <20240807-iio-adc-ad4695-buffered-read-v1-2-bdafc39b2283@baylibre.com>
On Wed, 7 Aug 2024 15:02:11 -0500
David Lechner <dlechner@baylibre.com> wrote:
> The ad4695 driver has a quirk where the temperature channel can't be
> enabled on its own for buffered reads, so we should document this.
>
> Also, since there are 4 possible modes of reading conversion data, it
> is useful to know which one is actually being used, namely the advanced
> sequencer mode.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> Documentation/iio/ad4695.rst | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/iio/ad4695.rst b/Documentation/iio/ad4695.rst
> index a33e573d61d6..af76ce2d0702 100644
> --- a/Documentation/iio/ad4695.rst
> +++ b/Documentation/iio/ad4695.rst
> @@ -147,9 +147,19 @@ Unimplemented features
> ----------------------
>
> - Additional wiring modes
> -- Buffered reads
> - Threshold events
> - Oversampling
> - Gain/offset calibration
> - GPIO support
> - CRC support
> +
> +Device buffers
> +==============
> +
> +This driver supports hardware triggered buffers. This uses the "advanced
> +sequencer" feature of the chip to trigger a burst of conversions.
> +
> +Due to hardware constraints, the temperature channel cannot be read on its own
> +for buffered reads. At least one voltage channel must also be enabled.
As per driver review, userspace shouldn't care about that.
We can always read too much and throw the extra away :)
Jonathan
> +
> +Also see :doc:`iio_devbuf` for more general information.
>
prev parent reply other threads:[~2024-08-10 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 20:02 [PATCH 0/2] iio: adc: ad4695: implement triggered buffer David Lechner
2024-08-07 20:02 ` [PATCH 1/2] " David Lechner
2024-08-08 8:52 ` kernel test robot
2024-08-10 9:20 ` Jonathan Cameron
2024-08-09 14:24 ` Nuno Sá
2024-08-09 16:01 ` David Lechner
2024-08-10 9:35 ` Jonathan Cameron
2024-08-12 17:03 ` David Lechner
2024-08-13 7:28 ` Nuno Sá
2024-08-14 18:56 ` Jonathan Cameron
2024-08-07 20:02 ` [PATCH 2/2] doc: iio: ad4695: document buffered read David Lechner
2024-08-10 9:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240810103630.0fbe8610@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox