From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Jorge Marques <jorge.marques@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
David Lechner <dlechner@baylibre.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: iio: adc: Add adi,ad4052
Date: Sat, 8 Mar 2025 15:05:55 +0000 [thread overview]
Message-ID: <20250308150555.1aa46abe@jic23-huawei> (raw)
In-Reply-To: <20250306-promotion-tarmac-bc5172f38f31@spud>
> > + vdd-supply: true
> > + vdd_1_8-supply: true
>
> You're allowed to use . in property names, and the _s should be -s.
> That said, vdd and vdd 1.8? Shouldn't both have the voltage in them in
> that case?
I got curious and opened datasheet. Only seeing two supplies (vdd and vio)
So checked driver and that doesn't enable any of them.
>
> > + vio-supply: true
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > +
Supplies that are not actually optional (i.e. device can run without them)
should be in required list even though the regulator core will provide
stubs if they aren't in your dts. The aim is to reflect what should
be provided, not what Linux does with it.
Jonathan
next prev parent reply other threads:[~2025-03-08 15:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 14:03 [PATCH 0/4] Add support for AD4052 device family Jorge Marques
2025-03-06 14:03 ` [PATCH 1/4] iio: code: mark iio_dev as const in iio_buffer_enabled Jorge Marques
2025-03-06 14:03 ` [PATCH 2/4] dt-bindings: iio: adc: Add adi,ad4052 Jorge Marques
2025-03-06 16:31 ` Conor Dooley
2025-03-08 15:05 ` Jonathan Cameron [this message]
2025-03-09 19:43 ` Jorge Marques
2025-03-10 19:35 ` Jonathan Cameron
2025-03-07 10:51 ` David Lechner
2025-03-09 20:11 ` Jorge Marques
2025-03-08 15:10 ` Jonathan Cameron
2025-03-09 20:25 ` Jorge Marques
2025-03-06 14:03 ` [PATCH 3/4] docs: iio: new docs for ad4052 driver Jorge Marques
2025-03-07 10:52 ` David Lechner
2025-03-09 20:49 ` Jorge Marques
2025-03-10 14:31 ` David Lechner
2025-03-10 19:56 ` Jonathan Cameron
2025-03-14 17:34 ` Jorge Marques
2025-03-15 18:24 ` Jonathan Cameron
2025-03-10 19:54 ` Jonathan Cameron
2025-03-14 18:13 ` Jorge Marques
2025-03-14 18:56 ` David Lechner
2025-03-19 16:59 ` Jorge Marques
2025-03-06 14:03 ` [PATCH 4/4] iio: adc: add support for ad4052 Jorge Marques
2025-03-07 12:06 ` kernel test robot
2025-03-07 12:39 ` kernel test robot
2025-03-07 14:22 ` kernel test robot
2025-03-08 16:02 ` Jonathan Cameron
2025-03-10 11:36 ` Jorge Marques
2025-03-08 16:12 ` Christophe JAILLET
2025-03-10 11:37 ` Jorge Marques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250308150555.1aa46abe@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jorge.marques@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox