Re: [PATCH v6 0/8] iio: accel: adxl313: add power-save on activity/inactivity

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 22 Jun 2025 15:34:23 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Sun, 22 Jun 2025 12:29:29 +0000
> Lothar Rubusch <l.rubusch@gmail.com> wrote:
> 
> > The patch set covers the following topics:
> > - add debug register and regmap cache
> > - prepare iio channel scan_type and scan_index
> > - prepare interrupt handling
> > - implement fifo with watermark
> > - add activity/inactivity together with auto-sleep with link bit
> > - add ac coupled activity/inactivity, integrate with auto-sleep and link bit
> > - documentation
> > 
> > Sorry for the fuzz: when I was about to rebase for submitting I
> > noticed Jonathan actually already applied parts of this. I'd recommend
> > to consider v6 rather over v5.
> > 
> > Since activity and inactivity here are implemented covering all axis, I
> > assumed x&y&z and x|y|z, respectively. Thus the driver uses a fake
> > channel for activity/inactiviy. AC-coupling is similar to other Analog Device
> > accelerometers, so MAG_ADAPTIVE events are chosen. Combinations are
> > documented and functionality tested and verified working.
> >   
> Given reply to wrong email thread probably meant first few patches of v5 that
> I picked up, I've dropped them for now.
> 
The series looks mostly good to me, just those couple of function naming things
need tidying up + I guess there might be something else from the adxl345 series
review that applies here that I've not noticed. So maybe have a last read through
with those changes in mind.

Thanks,

Jonathan